GithubHelp home page GithubHelp logo

Comments (5)

weslambert avatar weslambert commented on June 15, 2024 1

This is bundled into the just released v2.7.0 version.

Thank you!

from whoisit.

meeb avatar meeb commented on June 15, 2024

Thanks for the issue. It doesn't look like DEFAULT_CIPHERS is used at all now so setting it to a default list of ciphers probably won't fix this. Likely this needs a requests HTTPAdapter (which didn't fully support SSL/TLS tweaking when I originally wrote the cipher overwrite hacks). For reference and mostly for future notes:

https://requests.readthedocs.io/en/latest/user/advanced/#example-specific-ssl-version

The ConnctionPool passes down the **kwargs to HTTPSConnection which supports a custom ssl_context where custom ciphers could be specified:

https://urllib3.readthedocs.io/en/stable/reference/urllib3.connection.html#urllib3.connection.HTTPSConnection

from whoisit.

weslambert avatar weslambert commented on June 15, 2024

Understood. Thanks for looking into it!

from whoisit.

meeb avatar meeb commented on June 15, 2024

The above commit should resolve this and be backwards as well as forward compatible. I've added a regression test as well. It'll be bundled into the next release.

from whoisit.

meeb avatar meeb commented on June 15, 2024

This is bundled into the just released v2.7.0 version.

from whoisit.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.