[1.x] Increased event handlers SIP logging buffer size one more time or make it configurable about janus-gateway

[lminiero]

I still don't understand how SIP messages can get that large, when the SIP plugin doesn't even support multistream and so can only do two m-lines. Are you using event handlers (which is the only thing using those log buffers) or not (in which case we'd need to check why the errors appear in the first place)?

[ywmoyue]

Hello lminiero, I break point here found that the judgment "if(line[3] == '-')" has never been hit, and then "sofia_log[0] = '\0';" will never be executed to clear the buffer.

After executing several more sip operations, sofia_log will be full. If continue to execute sip operations, the error "Truncation occurred" will be reported.

I don’t understand sofia’s log structure. Should every log received be forwarded to the event handler without making this judgment?

[ywmoyue]

I copied the value of 'line' with a registered sip message. It is like this:

0x7fffb67eb270 "recv 361 bytes from udp/[192.168.19.59]:5060 at 14:54:04.204265:\n", '-' <repeats 72 times>, "\nSIP/2.0 200 OK\nVia: SIP/2.0/UDP 192.168.9.245:32868;rport=32868;branch=z9hG4bK3Bet6r1mgNp7p;received=192.168.9.245\nFrom: <sip:[email protected]>;tag=3345Fm7Fj4vQB\nTo: <sip:[email protected]>;tag=cd1747d9\nCall-ID: 6eec95a2-86e1-123d-768e-aa22c5774c0e\nCSeq: 82978630 REGISTER\nContact: \"3827\"<sip:[email protected]:32868;transport=udp>;expires=360\nContent-Length: 0\n\n\n"

the character - is in bits 62 to 133. I guess the judgment of line[3] == '-' is actually Want to judge these characters?

[ycherniavskyi]

I suspect that the log output may be related to the sofia-sip version. Currently, I am using version 1.13.17.

[lminiero]

Yes, I think so too: there's was an issue some time ago that was opened about that, #3031. The user that opened the issue contributed a tentative PR , but then disappeared so it never went anywhere. If you have ways to replicate the problem and maybe revisit the original PR (#3063) to see if it works for you, it would help having an up-to-date fix for that.