meghnathomas / milpnet Goto Github PK

add PRV plotting code to apply_milpnet.py so users can visualize PRV flow rate, upstream node head, downstream node head, H_setting

Based on tests with BWSN1:
add ability to parse rule-based controls. This will require additional if-then to prioritize certain rules over others

Hi
I tried to run the apply_milpnet.py example and got the following error:
Traceback (most recent call last): File "C:\Users\User\Documents\GitHub\MILPNet\apply_milpnet.py", line 29, in <module> milpnet_results = run_gurobi(inp_file, no_ts, pump_on = False) File "C:\Users\User\Documents\GitHub\MILPNet\set_up_milpnet.py", line 689, in run_gurobi largest_q = max(np.max(results.link['flowrate'])) TypeError: 'numpy.float32' object is not iterable

The error points to set_up_milpnet.py line 689:
largest_q = max(np.max(results.link['flowrate']))
smallest_q = min(np.min(results.link['flowrate']))

It seems like there is a redundant max function
Where the first np.max returns a float\int and then the outer max fails to find the maximum of a scalar
Deleting the outer max and min solved this issue