melihaksoy / android-kotlin-modulerized-cleanarchitecture

🚀 Example modularized android application with single activity written in Kotlin

Hi there 👋

android-kotlin-modulerized-cleanarchitecture's Issues

Polish UI

Create example use cases with using new material library components

Add JaCoCo for code coverage

Replace navigation

Current state has multiple activities. Goal is to introduce single activity approach with deeplink navigation.

Fix package name for launches feature

It's com.melih.list, should be com.melih.launches.

Encapsulate repository internals

Classes such as Api, ApiImpl, daos etc. are public. They should be internal and closed off from outer access.

.gitignore jacoco.exec files

Add flavors for demonstration

Right now project has build types but not product flavors. It'd be nice to demonstrate them.

Improve documentation with examples, goals & achievements

Adding CONTRIBUTING with descriptions and current state.

Add CI

Remove duplication of snackbar creation when there's an error

Possibly move it to base for handling errorData out of the box. This may require introducing a new generic for viewModel in base.

Making calls async

Right now fetching rockets are sequential:

Fetch -> Save -> Return

This should be async. It's good to take al ook at Room's LiveData support. flow can be replaced with liveData builder in BaseInteractor in this case.

Change static parameter name in detail navigation when safeArgs bug is fixed

Ticket here -> https://issuetracker.google.com/issues/139793883

Update versions

Update library versions. Room's new Flow support might be option to replace suspension.

Snackbar behaviour pushes view up, causing list to snuck under toolbar

This is due to translationY

Change use of deprecated NetworkInfo

NetworkInfo is deprecated. Should check how to achieve same functionality with ConnectivityManager.

Leak @LaunchesFragment RecyclerView due to adapter

Setting adapter to null would fix this leak

Reduce complexity in `onCreateOptionsMenu` of `LaunchesFragment`

Extract query processing logic and reduce complexity

Search functionality

Need to add search functionality that runs on different feature, that will present query results in a separate list. We should use https://launchlibrary.net/1.4/launch method - there are examples under section.

Documentation: https://launchlibrary.net/docs/1.4.1/api.html

Organzie scripts folder

A good approach might be using gradle as in here: https://jeroenmols.com/blog/2019/06/12/modularizationtips/

Add boundary callback for pager

Introduce scope for features & fragments

Right now feature module & fragments inside are not scoped. Add scopes for dependency hierarchy.

Increase test coverage

Check out other navigation options for single activity pattern

Boradcasting might be an idea to worth looking, just need to experiment.

Add paging

Right now repository only fetches 10 responses statically defined. Introduce paging with paging library.

Separate `repository` from `core`

Right now core uses api to provide repository as usable to other modules that include it. repository should be included exclusively instead.

Moving activity contributors to corresponding modules

AppModule contributes activities of features. This contribution should be moved to corresponding module.

Update README.md

Applying styles and themes

Use material library to apply styles and themes, make use of attributes that platform uses for better effect.

Modulerize repository

Right now repository is a single module using persistence and network. Network and persistence can be separate modules.

Add License

Applying dependency inversion

Some modules depend on concrete classes that are in other modules. This can be a good case to apply dependency inversion.

Fix `detail` di package names

Righ now it's com.melih.list somehow. Should be com.melih.detail.