merge-api / react-merge-link Goto Github PK

Hello!

Most browsers try to block popup when I want to connect an HR system (BambooHR in this case) through BambooHR's website.
When i choose this option I see an error message about blocking popup and new popup is not opened till I allow it in browser's settings.

It looks like there is an approach to fix it by emulating user's click event.
Here is details https://javascript.info/popup-windows#popup-blocking

Could you look at this and try to apply?

Is there a changelog for this repository? Or anyway for me to see the differences between past versions? For some reason this Github repo only has the latest version, which makes it really hard for me to assess the risk (or what code would need to change) when updating this package.

For example, I currently have 2.0.6 installed. How would I know what I need to change in order to upgrade to the latest (2.1.2)?

We would like still be able to display notifications to the user when the merge link is open, however cannot do that as the iframes default z-index is the maximum possible.

If you download the latest tarball from npm and open it up. You'll see that everything in the src directory has tenant config code, but that nothing in the dist directory does.

Maybe a step was missed when publishing to npm?

Tarball here: https://registry.npmjs.org/@mergeapi/react-merge-link/-/react-merge-link-1.3.1.tgz

When using this hook, the script pulled in at https://cdn.merge.dev/initialize.js appears to attempt to restore the body styles upon exit, though it is hard to tell since the source is minified.

When calling open() and then selecting an integration, if the modal is closed then the body.style keeps the overflow: hidden attribute. This has the effect of breaking scroll on our site until refresh.

When checking the types for UseMergeLinkProps in the repo it includes onExit & onLoad but for some reason the package downloaded from npm doesn't have those types despite the fact that the implementation is working correctly. An error when building maybe?

Types in the repo:

Types in the downloaded package:

  export declare type UseMergeLinkProps = {
    linkToken: string;
    onSuccess: (publicTokenID: string) => void;
  };

Is it possible to use merge-link without a modal?

I would love to display the merge link UI without using the overlay.

Is there a setting to display the component in line?

Please let me know if I'm missing something - there doesn't seem to be any release notes or a CHANGELOG to reference with version upgrades which means we're having to read commit diffs to attempt to determine what changes have been made. Since there doesn't seem to be any tagging either (again please tell me if I'm missing it!), it's essentially a bit of guesswork to determine what commits are part of what release. I guess we could take the code downloads from npm and do a diff there?

Anyway, if I'm missing something I'm happy to be corrected; we'd love to have some documentation about what's going into each release so we aren't just upgrading blindly.

We've identified a UX failure mode where a customer will successfully authenticate with some integration but they do not click on the Finish Setup button at the bottom of the modal. Perhaps they just quickly scan the Successfully set up your integration! text and click away from the modal, or close the tab or what have you, because they think they are done. In a perfect world we'd expect everyone to see and click on that button, but if they don't it's a rather problematic failure mode for us.

If that button is not clicked the public token callback isn't fired. If it isn't fired we have neither the public token or a means to exchange it for an account token. But from the perspective of merge, the account is linked and its status is complete.

Production account tokens are no longer accessible on the merge admin website. They are only available via the API. But in order to make the API request you need the public token. We have neither.

A potential solution is to trigger the callback as soon as you have a public token available and add some other callback akin to the onExit one, or just overload that one to be triggered both by the X in the top right or the finish setup button, for those who care about the Finish Setup button being pressed and the modal dismissed. But if the public token is already generated once the Finish Setup button please just give it to us without requiring that they click the button.

I am not being able to customize the link window. For example, I don't want all the HRIS providers to show, I only want a subset of available providers.

Is that possible?

After upgrading to version 2.0.5, our app doesn't compile.

Looking at the diff, it looks like something went wrong with this release: https://app.renovatebot.com/package-diff?name=@mergeapi%2freact-merge-link&from=2.0.4&to=2.0.5

I'm consistently getting

Cannot find module '@mergeapi/react-merge-link' or its corresponding type declarations.ts(2307)

from my import, though it is definitely installed, shows up in package, package-lock, node_modules

import { useMergeLink } from "@mergeapi/react-merge-link"

Additional info:

In package.json for @mergeapi/react-merge-link I see "main": "dist/index.umd.js",, but there is no dist folder in node_modules/@mergeapi/react-merge-link

Looks like you guys forgot to transpile this version, I see dist is in 2.0.6

Apologies in advance if this isn't the right repo for this issue.

The Merge Link modal can't be closed without clicking/tapping the close button, which means the modal is broken for keyboard/AT users.

To fix this:

• The close button should be written with the <button> tag so it is focusable
• Pressing the escape key should close the modal

It is also considered good practice to auto-focus the close button once the modal opens so that keyboard/AT users can start interacting with the modal's contents.