merk / dough Goto Github PK

Not all currencies will use a default rounding and may need to be configured.

I have encountered an error when MultiCurrencyMoney is being converted to string using the __toString() method.

Here are test cases that reproduce the error, add them to MultiCurrencyMoneyText:

public function testToStringIncorrectBank()
    {
        $fiveDollars = $this->bank->createMoney(5, 'USD');

        try {
            $fiveDollars->__toString();
            $is_ok = true;
        } catch(\Exception $e) {
            $is_ok = $e->getMessage();
        }

        $this->assertTrue($is_ok, 'Unable to convert MultiCurrencyMoney to string: '.$is_ok);
    }

    public function testToStringCorrectBank()
    {
        $fiveDollars = $this->bank->createMoney(5, 'USD');
        $fiveDollars->setBank( $this->bank );

        try {
            $fiveDollars->__toString();
            $is_ok = true;
        } catch(\Exception $e) {
            $is_ok = $e->getMessage();
        }

        $this->assertTrue($is_ok, 'Unable to convert MultiCurrencyMoney to string: '.$is_ok);
    }

First one returns: Unable to convert MultiCurrencyMoney to string: The supplied bank must implement MultiCurrencyBankInterface
This is because when using $this->bank->createMoney it doesnt set the bank.
To fix this i need to manually call ->setBank( $this->bank );

Second one returns: Unable to convert MultiCurrencyMoney to string: "" is an unknown currency code.
This is because when BaseMoney method __toString() calls $this->reduce()->getAmount(), the MultiCurrencyMoney reduce() method has $toCurrency = null. So when it calls $bank->getRate(..) it passes null as the fromCurrency parameter, and the MultiCurrencyBank calls $this->checkCurrencies(array($fromCurrency, $toCurrency)) and the checkCurrencies method crashes because of the null.

Suggested fix: when calling MultiCurrencyMoney reduce() withtoCurrency == null, dont call getRate, we dont need to convert to other currency, so this is not needed.