Comments (3)
Surely, as you say, we can leave it alone until someone is in trouble.
I will wait a few more days and then close this issue. In the meantime, if anyone needs Int128 support, they will comment. I'm sure they will, maybe.
By the way, I myself use UInt128 as a column in my database via EF Core.
endianness
As a messagepack integer, Big-Endian seems appropriate. Vector<128>.Shuffle
seems performant.
from messagepack-csharp.
I like Option 1
.
from messagepack-csharp.
There is precedent in this library for inventing our own encoding for a particular type and then conforming to a later msgpack spec while maintaining backward compatibility. Unfortunately, the public bool OldSpec
property doesn't scale well to that happening again, but I'm sure we could come up with something.
But I wouldn't rush into it unless there was actually something that needed it.
The concern I have with option 1 is that it doesn't appear to account for endianness. MsgPack already has a 128-bit encoding for Guids. In fact IIRC it has two: a binary copy and one that is 'safe' for cross-endian interop. If we were to do something for 128 bit integers within the library, I think we should start with an cross-endian safe encoding, and couple that with a 'native' binary copy formatter that can be opted into by interested parties.
from messagepack-csharp.
Related Issues (20)
- Add Support for external types via class libraries HOT 1
- MsgPack003 errors showing in Rider for type with custom formatter HOT 5
- Typeless serializer fails to serialize simple type, unless fields are prefixed with "_" HOT 2
- Explicit interface implementation
- Help request - using different (derived-)types for serialize/deserialize (IMessagePackFormatter<Tser, Tdes>)? HOT 2
- Discrepancy in Serialized Size with MessagePack for Complex Object Graphs HOT 1
- Serialize/deserialize of interface types failing with ContractlessStandardResolver HOT 1
- Make System.Runtime.CompilerServices.Unsafe a conditional based on TFM
- Serializing a property without a setter throws "No set accessor" when the class has a constructor HOT 4
- Source generated formatter support of sparse/patch objects via BitArray HOT 5
- A conflict issue using MessagePack.Unityshims HOT 2
- Securely Save and Load for my game? HOT 1
- Wrong type of formatter for record with string keys HOT 2
- GeneratedResolver does not exist in the namespace MessagePack.Resolvers
- Recursive serialization with custom formatter only writes last member HOT 2
- How to avoid cast and multiple Deserialize in code. HOT 1
- [Optimization] Locate formatters only if dictionary has elements HOT 1
- Unable to Deserialize Data Serialized with Typeless Resolver after Migrating to Attributed Objects HOT 16
- [Performance][Optimization] Method inline question HOT 3
- Message Pack Compiler just freezes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from messagepack-csharp.