GithubHelp home page GithubHelp logo

Comments (3)

pCYSl5EDgo avatar pCYSl5EDgo commented on June 4, 2024 1

Surely, as you say, we can leave it alone until someone is in trouble.
I will wait a few more days and then close this issue. In the meantime, if anyone needs Int128 support, they will comment. I'm sure they will, maybe.
By the way, I myself use UInt128 as a column in my database via EF Core.

endianness

As a messagepack integer, Big-Endian seems appropriate. Vector<128>.Shuffle seems performant.

from messagepack-csharp.

pCYSl5EDgo avatar pCYSl5EDgo commented on June 4, 2024

I like Option 1.

from messagepack-csharp.

AArnott avatar AArnott commented on June 4, 2024

There is precedent in this library for inventing our own encoding for a particular type and then conforming to a later msgpack spec while maintaining backward compatibility. Unfortunately, the public bool OldSpec property doesn't scale well to that happening again, but I'm sure we could come up with something.

But I wouldn't rush into it unless there was actually something that needed it.

The concern I have with option 1 is that it doesn't appear to account for endianness. MsgPack already has a 128-bit encoding for Guids. In fact IIRC it has two: a binary copy and one that is 'safe' for cross-endian interop. If we were to do something for 128 bit integers within the library, I think we should start with an cross-endian safe encoding, and couple that with a 'native' binary copy formatter that can be opted into by interested parties.

from messagepack-csharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.