metacomet10 / mpmb-v13-content-catchup Goto Github PK

TCoE Rune Knight subclass forgets to give smith's tools proficiency and giant language

Collecting everything that still needs to be done and/or fixed in TCoE.

To see current progress, click here.

For some reason, when TCoE is added (not even activated, just imported into the sheet and then moved to the "Excluded from the Automation" column in the resources window), Monk loses it's martial arts ability in the attacks section of the sheet (i.e. Unarmed Strike defaults to Str based and does 1+Str damage).

If you already have a lvl 1+ monk with the martial arts active it still seems to work if you subsequently add TCoE, activate it and then level up.

However, if you add TCoE (and even if you immediately move it to the excluded column) and start a new character (or Reset the sheet to start anew) it forgets that you can use Dex and that damage scales from 1d4+.

Bug details:
With the script for the UA: Spells & Magic Tattoos, there is a coding error with the Barrier Tattoo regarding its rarity options and AC provision. No "Uncommon" option is available, and the three options provided all only allow the AC to be 18 instead of the varied options. From examination of script within GitHub, it seems the script may be missing code or may have incorrect code.

Reproduction for Evidence:

1. Have script ua_20200326_Spells-and-Magic-Tattoos added into sheet. (Testing done on Printer-Friendly version as no selection tabs available in Colorful sheet.)
2. Scroll to "Magic Items" section and select item to be "Barrier Tattoo" of either of three options. (Can be found in source > UA: Spells & Magic Tattoos.)
3. Scroll to first page and change description on Armor box to "Barrier Tattoo". AC then becomes 18.

Expected Behaviour:
When option is selected for Barrier Tattoo, the description should be correct to the rarity selected.
When selected, the Rarity should also be within the Magic Item name box with name of Tattoo.
When Uncommon/Rare/Very Rare is selected for specific tattoo, the AC should in fact match the correct information when chosen in the description box of Armor.

Screenshots:
Screen of Magic Item description:

Screen of supposed "Rarity" selections in option box:

Screen of Armor description box and applied AC value:

Screen of possible error in script code design leading to bug in question:

Version of sheet used:
v13.0.4 Printer-Friendly - Redesign

Describe the bug
When attempting to create a Fey Wanderer Ranger the following error gets thrown after saving and re-opening a sheet that has the TCoE content added where a Fey Wanderer character has been selected via the Class menu.
The script '2020/10/27 - all_WotC_pub+UA.min.js' is faulty, it returns the following error when run: "TypeError: origNatExpl[origNatExplCurSel] is undefined" The script ahs been removed from this pdf.

To Reproduce
Steps to reproduce the behavior:

1. Open a fresh copy of the base MPMB character sheet.
2. Add TCoE js file from this repo.
3. Create a character with the Fey Wanderer class
4. Save the file and close it.
5. Open the file.
6. The error appears and the related JS file is removed.

Expected behavior
No error pop-up should occur and the base JS files included with a fresh sheet should not be removed.

Screenshots

Version of the sheet:

• v13.0.5

Additional context
The included classes selection shows other classes and higher than 1 level in the class but it will happen with just a single level in Fey Wanderer.

Describe the bug
When attempting to add a firearm to my attacks list, the following error shows up in the JavaScript Debugger
`The custom ApplyWeapon/atkAdd script 'Gunner (feat)' produced an error! It will be removed from the sheet for now, but please contact the author of the feature to have this issue corrected:
ReferenceError: isRangedWeapon is not defined
fileName: Document-Level:FunctionsImport;
lineNumber: 8442;
columnNumber: 0;

`

To Reproduce
Steps to reproduce the behavior:

1. Add Gunner Feat
2. Enable Firearms
3. Add Firearm to attack list
4. See error

Expected behavior
No error popup

Screenshots

Version of the sheet:

• [v13.0.4]

Deft Explorer only works if the UA ranger is active. Looks like the script is disabled at this point for use without the UA. I haven't tested if activating this script section will break the sheet yet. Will try tonight to verify.