metlifelegalplans / django-willing-zg Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 4.0 105 KB

A Django app to hold common utilities for Zygoat-managed applications

Python 93.83% HTML 6.17%

django-willing-zg's People

Watchers

Forkers

kborer ian-macleod babahasscode hvoelkerai

django-willing-zg's Issues

EMAIL: BCC field not working

I don't think bcc emails are getting sent. Tested by turning off email re-routing on a lower environment and sending an email that has a bcc user. Only the user in the TO field receives the email.

copy PortunusUser to this repo

https://github.com/MetLifeLegalPlans/members/blob/d37b7e2423e6376451b08001e1af084053cf86ea/backend/users/models.py#L20

Once it is here, we can update apps that need it to use this version.

Move secrets manager logic (originally a PR in willing-zg) to this repo

EMAIL: report errors to sentry rather than printing

we should be reporting errors to sentry here:

django-willing-zg/willing_zg/mailer.py

Lines 100 to 103 in 2a2744d

 except Exception as e: 

 # TODO: report exception 

 print(e, vars(e)) 

 return False

i've only thought about this for literally a minute, but one idea for doing this: have the children of this class define the needed sentry configs on their class, so that in this mailer we can check whether they exist and if they do send this to sentry (and if not, keep the print)

Recommend Projects