metwork-framework / xattrfile

This is a python module for dealing with files with tags stored in a redis instance.

xattrfile

Status (master branch)

What is it?

This is a python module for dealing with files with tags stored in a redis instance.

• Documentation
• Coverage

Contributing guide

See CONTRIBUTING.md file.

Code of Conduct

See CODE_OF_CONDUCT.md file.

Sponsors

(If you are officially paid to work on MetWork Framework, please contact us to add your company logo here!)

xattrfile's Issues

os.rename() raises "OSError: [Errno 18] Invalid cross-device link" when using different FS

if we set the input data dir for mfdata in another file system, the switch plugin displays the below error message :

[DEBUG] (mfdata.switch.main#24286) Can't move /data/drbd/var/in/input/foobar.txt to /home/mfdata/var/in/tmp/switch.main/28397e0964614d9991771515ff18d920: file does not exist any more ?

it appears the call of os.rename() in XattrFile raises an OSError

OSError: [Errno 18] Invalid cross-device link: '/data/drbd/var/in/input/foobar.txt' -> '/home/mfdata/var/in/tmp/switch.main/28397e0964614d9991771515ff18d920'

because the file is not on the same FS.

• Possible solution(s) :

1. (1) stop mfdata
   (2) move /home/mfdata into /data/mfdata (as root)
   (3) ln -s /data/mfdata /home/mfdata
   (4) restart mfdata

2. replace os.rename(old_filepath, new_filepath) by shutil.move(old_filepath, new_filepath) in XattrFile.rename()

note that shutils.move() first try to do os.rename() then only if it raises an OSError it makes a copy+delete... so it can cause a decrease in performance, as the user's own risk? (maybe we can add a warning message)