Comments (45)
I understand where you're coming from and agree with you in principle, but I prefer to keep things as simple as possible for those willing to contribute.
from coronatracker.
Great. I'll prepare the project for localization.
UPDATE:
To make it easier to update the translations and contribute, I created a project on poeditor.com and imported all existing translations. From now on, you can easily update the translations from poeditor.com website. No need for manual updates and pull requests anymore.
The project link: https://poeditor.com/join/project/UTZyE0GKiT
from coronatracker.
I prepared the project and added two localization files for:
- German:
https://github.com/MhdHejazi/CoronaTracker/blob/master/Corona/Localization/de.lproj/Localizable.strings - Swedish:
https://github.com/MhdHejazi/CoronaTracker/blob/master/Corona/Localization/sv.lproj/Localizable.strings
The strings need to be translated.
from coronatracker.
@sebastianbinder So what's the point to commit the file and setup? Also this should be a PR.
from coronatracker.
Thank you guys for the great work!
BTW, I didn't add country names to the localization files because they're part of the data and may change at any time (happened twice before). Do you think we should also translate them?
from coronatracker.
Sure. Here you go:
https://github.com/MhdHejazi/CoronaTracker/blob/master/Corona/Localization/it.lproj/Localizable.strings
from coronatracker.
I did that. Check the app and let me know how it's looking.
I also translated the month names and rotated the country names in the charts to make sure they don't overlap with each other. If you find any other problem let me know, please.
from coronatracker.
Yes, check the replies from above. I added the seed files to simplify the process of translation. With the file added, you don't need Xcode anymore, and you can even do everything from the browser.
from coronatracker.
I collected all the country names from the data source in one file and added the ISO code for each country name.
So all country names are now auto-translated.
from coronatracker.
@mhdhejazi Instead of adding wrongly set up translation and fix after, we should add the translations without linking it into the project and a developer with access to Xcode should setup what is needed to embed it in the project.
from coronatracker.
Thank you for your kind reply!! I've already done my work.
from coronatracker.
Merged. Thank you!
from coronatracker.
Merged. Thank you!
from coronatracker.
I would suggest adding this to the libre software https://weblate.org/hosting/ to make it easier to contribute.(Gratis for libre software as you can see.) Noticed some languages using triple-dot ... instead of ellipis … and various stings missing, which would become more apparent if displayed as "not translated" on the platform.
from coronatracker.
To make it easier to update the translations and contribute, I created a project on poeditor.com and imported all existing translations. From now on, you can easily update the translations from poeditor.com website. No need for manual updates and pull requests anymore.
The project link: https://poeditor.com/join/project/UTZyE0GKiT
from coronatracker.
Just reload the page. The words are added.
from coronatracker.
I would gladly help out with a Swedish (Svensk) trasnaltion.
from coronatracker.
Created a PR #27
from coronatracker.
Created a PR #28
from coronatracker.
Of course, just point me were to do that.
Sweden = Sverige
Swedish = Svenska
from coronatracker.
Hi, I would glad to help out with Italian translation. Can you add the italian localization?
from coronatracker.
Regarding country names: Isn’t there a way to use the Apple Map Kit for that? I think there should be translations somewhere already so you could try to solve this programmatically first. Kinda source says „Germany“ -> query Maps -> getting a country object -> output name in device language. Don’t know if this is possible but might be worth a try.
from coronatracker.
There is a way to translate country names in iOS. The problem is the non-standard names used in the data (e.g. "Korea, South" vs. "South Korea"). See the country names here.
Anyway, I think I'll try to get the translated names from iOS, and when that fails, use the original name. If the result isn't good enough we can work on normalizing the country names.
from coronatracker.
@mhdhejazi Why the italian translation has the values in english?
from coronatracker.
If you read above the Italian file still needs translation 🤷🏼♂️
from coronatracker.
I‘m not speaking Italian. Need to wait for @Ale111 to translate the file. If it’s important for you feel free to translate it yourself.
from coronatracker.
So @Ale111 should be the person to open the PR like a did in my translation to Portuguese. #29
from coronatracker.
We have two new strings to be translated:
P.S. The translations can be updated from the web browser if you wish. Just find the proper file here and press the edit button.
from coronatracker.
If you still don't have any 'Japanese' translator, I'll be the one.
from coronatracker.
@dev-sora Sure! And thank you in advance.
from coronatracker.
@mhdhejazi So could you add Japanese directory under Corona/Localization? Or is it my task?
from coronatracker.
Sure. Here you go: https://github.com/mhdhejazi/CoronaTracker/blob/master/Corona/Localization/ja.lproj/Localizable.strings
from coronatracker.
Hi. I couldn't push my work on 'master'. Could you add me as a contributor, or another way?
from coronatracker.
You need to work on your fork and then create a pull request. Or you can update the file directly in the browser by pressing the edit button, and GitHub will create a fork and a pull request for you when you're done.
from coronatracker.
Submitted a PR with Dutch translations: #78
from coronatracker.
Submitted the Arabic language, #86
from coronatracker.
Fails to compile, saying that localization is in an invalid format. Go figure. Latest version of everything.
from coronatracker.
@comradekingu Yeah. I think we have to do that.
@surak I merged a fix for the German translation. Try again now.
from coronatracker.
Hi there, I'm from Indonesia. I'm trying to contribute to this app and I'm add Indonesian translation to this app. Maybe you can check this? #92
Thanks before 😃
from coronatracker.
@nikotidar Merged. Thank you for taking the time to contribute.
from coronatracker.
@nikotidar Merged. Thank you for taking the time to contribute.
You're welcome 😃
from coronatracker.
#88
Norwegian Bokmål by "Allan Nordhøy" e-mail in my profile. Only use @comradekingu for communication here.
from coronatracker.
@comradekingu I used the mentions for all contributors as they provide more info. One can see your user card (which contains far more than your name) when they hover over your mention, and they can also open your page and see even more. And I already added the full names and GitHub pages to all translation files.
But if you don't like how your name is mentioned, please feel free to change it and create a PR.
Thank you for your contribution again.
from coronatracker.
I figured that GitHub doesn't show a user card for mentions in the readme file, so I added the full names for everybody with a link to their profile.
from coronatracker.
Not sure if these lines require translation
from coronatracker.
Related Issues (20)
- Scrolling issue on Mac HOT 4
- Lernen
- Provide IPA file for use with services like AltStore HOT 1
- performance issue on Mac Catalyst app HOT 13
- Compile iPA for sideloaders? HOT 1
- iOS 14 Widget HOT 8
- MacOS High Sierra with xcode 9.x HOT 2
- Bar title in "Daily New Cases" fails for USA HOT 1
- Loss of date HOT 4
- Diagram is clipping / not scaling correctly in logarithmic mode
- Corina
- Does not work for iOS 10.3. No such module WidgetKit
- Enable iOS widget on Big Sur
- iOS Widget not working
- Add the vaccination data HOT 1
- Zoom-in and zoom-out
- Project is crashing
- Corona tracker
- Repo
- AppStore download links HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coronatracker.