GithubHelp home page GithubHelp logo

Comments (13)

Micalobia avatar Micalobia commented on July 19, 2024

If it doesn't happen with 3.1.2, then it has to do with the fix I made for the server-client desync in 3.1.3. I'll look into it, I don't expect it to be too difficult to fix

Basically, it's sorting a list every time a slab is added outside of vanilla, which I didn't think about the performance implications of. The fix should just be making it sort the list after all mods have loaded

from full-slabs.

SplendidAlakey avatar SplendidAlakey commented on July 19, 2024

Just to be absolutely sure, I tested 3.1.2 again and yes, it loads normally.

Here's the log if it's of any use: [removed]

Thanks for looking into it!

from full-slabs.

Micalobia avatar Micalobia commented on July 19, 2024

So there's a new version called 3.1.4.exp1, which should fix this issue but I'm not sure. If you could test it I would be grateful.

from full-slabs.

SplendidAlakey avatar SplendidAlakey commented on July 19, 2024

Just tested it, the fix worked. Loaded in just 2 minutes, which is only like ~20 seconds longer than with 3.1.2, at which point it might just be a margin of error.

Thanks again!

from full-slabs.

SplendidAlakey avatar SplendidAlakey commented on July 19, 2024

Upon further testing, it seems like loading times moved into the worldgen. It seems a bit faster anyway, though. When I loaded up my world it took 5 minutes to load. Tested it on a server as well, it loaded fast, but 50% of the blocks are invisible/wrong.

Client log: [removed]

What happens when joining a server:

2021-10-02_16 00 45

What's weird is that most of it should be stone bricks, yet only some are invisible.

And this is how it should look like:

2021-10-02_16 11 05

from full-slabs.

Micalobia avatar Micalobia commented on July 19, 2024

Are you using a mod pack that you've built off of, or is this just something you put together? Going to attempt to download it myself, just want to make sure 😄

from full-slabs.

Micalobia avatar Micalobia commented on July 19, 2024

Also thank you for being patient and continuing to reply, it's extremely helpful

from full-slabs.

SplendidAlakey avatar SplendidAlakey commented on July 19, 2024

I put it together myself. You will need to edit MineGate config in order to be able to create worlds with this modpack, in its ini files or modmenu change "useMixins" to false. Other than that I don't think any of my custom configs matter, but, if needed, I can provide all of them.

And no problem at all, I love your mod, it's the best slab mod I've seen and I'd love to include it in my modpack.

from full-slabs.

SplendidAlakey avatar SplendidAlakey commented on July 19, 2024

These 2 modpacks are the closest to what I have: BetterMinecraft and All of Fabric 4. But they don't have all the mods I do, and I don't use some mods that they include.

from full-slabs.

Micalobia avatar Micalobia commented on July 19, 2024

I've released a new experimental version if you could take a look

Thank you for reminding me to give explicit permission to use in modpacks, btw, that's a good idea

from full-slabs.

SplendidAlakey avatar SplendidAlakey commented on July 19, 2024

The second experimental version works flawlessly so far. Initial start at about 2.5min, single-player world loaded in just ~30s. While connected to a server all blocks appear as intended. Amazing job! I will be keeping an eye out for any issues down the line, but this one can be considered fixed.

from full-slabs.

Micalobia avatar Micalobia commented on July 19, 2024

Cool beans, thank you for reporting!

from full-slabs.

SplendidAlakey avatar SplendidAlakey commented on July 19, 2024

Ignore that, it was caused by some other mod (I think Eating animation).

Oh, just 1 thing I forgot to mention (not related to this issue at all, so let me know if it's worth opening another one for it) - Cut copper slab doesn't have the HUD elements when it's placed as a horizontal slab:

2021-10-02_19 56 25

2021-10-02_19 56 28

I don't know if this is an issue with the experimental version or just in general with the mod.

from full-slabs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.