michael-rubel / laravel-couponables Goto Github PK

i want to give users the oppourtunity to check if coupon is still valid, before user redeem, but my code isnt working

 public $code;
    public function check($id)
    {
        $user = User::find($id);
        $user->verifyCouponOr($this->code, function ($exception) {
            throw ValidationException::withMessages(['code' => 'Your coupon code is already use',]);
        });

        $user->isCouponAlreadyUsed($this->code);
    }

blade

<div class="my-5">
    <div class="bg-white rounded-md p-3 mx-2">
        <form wire:submit="check({{ auth()->user()->id }})" action="" class="space-y-3">
            <input wire:model="code" placeholder="Check If Coupon Is Valid" type="text" class="px-4 py-2 rounded-md w-full">
            <button class="bg-blue-500 rounded-md  py-2 px-3">Check Coupon</button>
        </form>
        @error($code)
            {{ $message }}
        @enderror
    </div>
</div>

my coupon:
redeemer_type: App\Models\Member,
redeemer_id: 30,

$redeemer = Member::find(18);
$redeemer->verifyCoupon($coupon_code); //return no exception

no matter which redeemer it is, always pass the validation.

i found the issue in this function.

public function isAllowedToRedeemBy(Model $redeemer): bool
    {
        return with(static::$bindable, function ($coupon) use ($redeemer) {
            if ($coupon->isMorphColumnsFilled() && ! $coupon->redeemer?->is($redeemer)) {
                return false;
            }

            if ($coupon->isOnlyRedeemerTypeFilled() && ! $coupon->isSameRedeemerModel($redeemer)) {
                return false;
            }

            return true;
        });
    }

$coupon is always null inside this function >> $coupon->redeemer_type and $coupon->redeemer_id are null >> always return true.

and if i use $this instead of static::$bindable, everything works.

Please help to fix this issue, thanks!

Hi,

I try this code

$user->verifyCouponOr("ABC123", function($exception){
    dump($exception);
});

I expected the output will be the exception (e.g MichaelRubel\Couponables\Exceptions\OverQuantityException The coupon is exhausted.)

.

but instead, it return the coupon code:

"ABC123"

.

I encountered error with this line.

$course->coupons()->get();

Column not found: 1054 Unknown column 'couponables.couponable_id' in 'field list'

Simple solution would be to rename column name in couponables table.
Rename the morph field couponables to couponable ?

i want to all users to create coupon and also get the list of coupon created them

I assigned the coupon to $redeemer by saving

redeemer_type=members
redeemer_id=46 (in this case)

I try to use another member to verifyCoupon the coupon and it returns true

$member = Member::find(47);
$coupon = $member->verifyCoupon($code); << it return no exception

I want to get all coupons with redeemer

like:
Coupon::with(['redeemer'])->get();

thanks.