michaelbeutler / poker

Online Poker App

♠️ Poker

Poker is a websocket based online poker app for you to play against your friends. I just wanted to know poker and decided that the best way to learn it, is to build my own poker application.

🚀 Installation

Clone the git repository and run yarn install or npm install.

cd poker-server
yarn install
cd ../poker-client
yarn install

📦 Dependencies

• node-sass (^4.13.1)
• react (^16.13.1)
• react-dom (^16.13.1)
• react-redux (^7.2.0)
• react-scripts (3.4.1)
• redux (^4.0.5)
• redux-logger (^3.0.6)
• redux-thunk (^2.3.0)
• express (^4.17.1)
• http (^0.0.1-security)
• socket.io (^2.3.0)
• socket.io-client (^2.3.0)
• uuid (^7.0.3)
• jest (^25.3.0)
• jest-dom (^4.2.4)

🚨 Testing

All modules and components are tested with jest. To run the tests simply install the dev dependencies and run yarn test. For further information visit the wiki.

🔎 Usage

coming soon

Authors

• Michael Beutler - initial work - michaelbeutler
• hdptrck - design work - hdptrck

♥️ Contributing

Pull requests are welcome. For major changes, please open an issue first to discuss what you would like to change.

Please make sure to update tests as appropriate.

📃 License

This project is licensed under the MIT License - see the LICENSE file for details

👌 Acknowledgments

• play poker with your friends 😝

poker's Issues

Usernames not uniqe

socket.on(LOGIN, async (data) => {
        if (data && data.username && data.username.length > 0 && !data.username.isEmpty()) {
            const username = data.username.trim().trunc(10);
            if (DEBUG) { console.log(`login ${username}`.debug) }

            players.push(new Player(io, socket, username));
            socket.login = true;
            io.to(socket.id).emit(LOGIN_SUCCESS, { username });
        } else {
            if (DEBUG) { console.log(`invalid username`.debug) }
            io.to(socket.id).emit(LOGIN_ERROR, { text: "invalid username" });
        }
});

Handle games with only one player after restore

When the game ist started and the server restarts, the game can be played with only one player...

Applay "ducks pattern"

Ducks pattern

Players can still join after game started

maybe add another start condition...

When a user joins a room he don’t knows the others.

Add loop and send all members before socket joins room.

JWT Auth

using jwt middleware: JWT Middleware

var io = require('socket.io')();
var jwtAuth = require('socketio-jwt-auth');
 
// using middleware
io.use(jwtAuth.authenticate({
  secret: 'Your Secret',    // required, used to verify the token's signature
  algorithm: 'HS256'        // optional, default to be HS256
}, function(payload, done) {
  // done is a callback, you can use it as follows
  User.findOne({id: payload.sub}, function(err, user) {
    if (err) {
      // return error
      return done(err);
    }
    if (!user) {
      // return fail with an error message
      return done(null, false, 'user does not exist');
    }
    // return success with a user info
    return done(null, user);
  });
}));