michaelhettmer / react-hooks-use-previous Goto Github PK

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Invalid npm token.

The npm token configured in the NPM_TOKEN environment variable must be a valid token allowing to publish to the registry https://registry.npmjs.org/.

If you are using Two-Factor Authentication, make configure the auth-only level is supported. semantic-release cannot publish with the default auth-and-writes level.

Please make sure to set the NPM_TOKEN environment variable in your CI with the exact value of the npm token.

Good luck with your project ✨

Your semantic-release bot 📦🚀

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): replace dependency npm-run-all with npm-run-all2 5.0.0
• chore(deps): update codecov orb to v3.3.0
• chore(deps): update dependency prettier to v2.8.8
• chore(deps): update dependency typescript to v4.9.5
• chore(deps): update typescript-eslint monorepo to v5.62.0 (minor) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• chore(deps): update codecov orb to v4
• chore(deps): update commitlint monorepo to v19 (major) (@commitlint/cli, @commitlint/config-conventional)
• chore(deps): update dependency @testing-library/react-hooks to v8
• chore(deps): update dependency eslint-config-prettier to v9
• chore(deps): update dependency eslint-plugin-prettier to v5
• chore(deps): update dependency husky to v9
• chore(deps): update dependency jest-junit to v16
• chore(deps): update dependency jest-mock-console to v2
• chore(deps): update dependency lint-staged to v15
• chore(deps): update dependency prettier to v3
• chore(deps): update dependency typescript to v5
• chore(deps): update jest monorepo to v29 (major) (@types/jest, jest, ts-jest)
• chore(deps): update react monorepo to v18 (major) (@types/react, react, react-test-renderer)
• chore(deps): update typescript-eslint monorepo to v7 (major) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• 🔐 Create all rate-limited PRs at once 🔐

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

• chore(deps): update dependency semantic-release to v19 [security]

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update codecov orb to v3.2.5
• chore(deps): update dependency @types/react to v17.0.76
• chore(deps): update dependency dot-json to v1.3.0
• chore(deps): update dependency eslint to v8.57.0
• chore(deps): update dependency eslint-plugin-react-hooks to v4.6.0
• chore(deps): update dependency jest-junit to v13.2.0
• chore(deps): update dependency jest-mock-console to v1.3.0
• chore(deps): update dependency lint-staged to v12.5.0
• chore(deps): update semantic-release monorepo (major) (@semantic-release/changelog, @semantic-release/git)
• Click on this checkbox to rebase all open PRs at once

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• chore(deps): update dependency @types/jest to v27.4.1
• chore(deps): update dependency lint-staged to v12.3.8
• chore(deps): update dependency ts-jest to v27.1.5
• chore(deps): update dependency @types/jest to v27.5.2
• chore(deps): update dependency eslint-plugin-prettier to v4.2.1
• chore(deps): update node.js to v17

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Bug Description
The hook will return a value that I would not consider to be the previous value of a supplied prop.

To Reproduce
run the test

it('should not update on rerender if prop is unchanged', () => {
  const { result, rerender } = renderHook(() => usePrevious('current', 'initial'));

  rerender();

  expect(result.current).not.toBe('current');
});

Suggested Fix
Instead of using useEffect, use a simple if statement to check for update (similarly to how useEffect checks its own array, effectively cutting out the middleman)