GithubHelp home page GithubHelp logo

Comments (4)

michaelklishin avatar michaelklishin commented on September 21, 2024

What examples violate this? I couldn't find any in the Getting Started guide.

Everything that's true for the Java client applies to Langohr. Sharing channels between threads is a bad idea when publishing, although even that is not always true: publishing from a consumer callback is safe because consumer work service in the Java client dispatches consume methods with a per-channel ordering guarantee.

I welcome specific documentation improvements. Java, .NET and Ruby (Bunny) clients have decent concurrency considerations sections in their docs.

from langohr.

eigenhombre avatar eigenhombre commented on September 21, 2024

@michaelklishin thanks for your reply. I could be missing something, but doesn't blabbr in One to Many Pubsub share channels between the consumers? weathr does the same. Admittedly these are on the consumer side, but the aforementioned RMQ warning does not distinguish between producers and consumers: "While some operations on channels are safe to invoke concurrently, some are not and will result in incorrect frame interleaving on the wire." At the very least, if consumers can safely share channels but producers not, would it make sense to at least mention this in the docs? The Bunny docs do seem clearer ("Concurrency Considerations"). Thanks again.
CC @loganmhb

from langohr.

michaelklishin avatar michaelklishin commented on September 21, 2024

@eigenhombre feel free to submit a PR for Langohr docs.

from langohr.

michaelklishin avatar michaelklishin commented on September 21, 2024

Those examples share a channel for consuming. There is no concurrency besides what the client does internally to make delivery dispatch concurrent. I've explained above why that is safe.

from langohr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.