GithubHelp home page GithubHelp logo

Prisma 5 about typegraphql-prisma HOT 5 CLOSED

vieirai avatar vieirai commented on June 12, 2024
Prisma 5

from typegraphql-prisma.

Comments (5)

MichalLytek avatar MichalLytek commented on June 12, 2024 4

Wasn't so hard, closing by 66d3b2f 🔒

from typegraphql-prisma.

vieirai avatar vieirai commented on June 12, 2024

Hey @MichalLytek , I saw you labelled this as good first issue, would you be open for me raising a PR to add Prisma 5 support?

What I want to avoid is working on the PR and then having it sit in the Pull requests tab unmerged.

from typegraphql-prisma.

MichalLytek avatar MichalLytek commented on June 12, 2024

It's farily easy process, assuming there's no breaking changes.
All you need to do is bump prisma versions (all packages) in root package json as well as experiments folders, install all deps, run prisma generate, check for diff in generated files, run tests to see all works, bump version in peer deps, bump version in installation docs and that's it!

from typegraphql-prisma.

ramiel avatar ramiel commented on June 12, 2024

Hello. I think this change https://www.prisma.io/docs/guides/upgrade-guides/upgrading-versions/upgrading-to-prisma-5#using-private-apis-for-a-specific-runtime makes it difficult to upgrade to version 5 since things like DMMF are not exposed anymore. You need a deeper knowledge to make this work.

from typegraphql-prisma.

qlaffont avatar qlaffont commented on June 12, 2024

Maybe we can try to setup a github workflow to handle prisma update.

  • Use renovatebot to automatically detect prisma changes
  • Run on renovatebot PR tests
  • If success, merge PR on master
  • If merge PR on master, increase version and publish on master.

I have already done it on some libraries and it works perfectly. If needed to implement this : you can found a good example here : https://github.com/flexper/paginate-prisma/blob/main/.github/workflows/publish.yml

from typegraphql-prisma.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.