micnews / article-json-to-amp Goto Github PK
View Code? Open in Web Editor NEWRender article json format in the AMP format
License: Other
Render article json format in the AMP format
License: Other
First of all thanks for the two apps. It doesn't look as though embeds are rendering if they are in children elements though. Here is a JSON structure with your test alongside a child embed. The first embed works fine, while the second one is blank.
[ { "type": "paragraph", "children": [ { "type": "text", "content": "WATCH:", "href": null, "italic": false, "bold": true, "mark": false, "markClass": null, "strikethrough": false } ] }, { "type": "embed", "embedType": "youtube", "caption": [], "attribution": [], "youtubeId": "abc" }, { "type": "paragraph", "children": [ { "type": "linebreak" }, { "type": "embed", "embedType": "youtube", "caption": [], "attribution": [], "youtubeId": "abc" } ] } ]
Reading through https://www.ampproject.org/docs/reference/extended/amp-twitter.html - it sounds like tweets are going to be a bit difficult to support. Any ideas there @iefserge?
Just noting the converter unfortunately doesn't work for images that are inside paragraphs, for example https://runkit.com/589c227611ea6e0014d521d2/589c227611ea6e0014d521d3
hey,
Should we add code coverage check here?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.