run tests for invalid data about nmdc-schema

[wdduncan]

See this stackoverflow article for pointers:

https://stackoverflow.com/questions/2188376/how-to-have-gnu-make-explicitly-test-for-failure

[wdduncan]

Yes. That was going to be my approach.

[turbomam]

in addition to prefixing the negative tests with "invalid_", can we also put them in an invalid subdirectory?

[wdduncan]

in addition to prefixing the negative tests with "invalid_", can we also put them in an invalid subdirectory?

I'd prefer not.

[turbomam]

Are you thinking of breaking up

nmdc-schema/Makefile

Lines 152 to 166 in 0549185

	# datasets used test/validate the schema
	SHEMA_TEST_EXAMPLES := \
	biosample_test \
	gold_project_test \
	img_mg_annotation_objects \
	nmdc_example_database \
	MAGs_activity \
	mg_assembly_activities_test \
	mg_assembly_data_objects_test \
	nmdc_example_database \
	study_test
	# invalid_study_test # this is used to make sure invalid data is caught!
	.PHONY: test-jsonschema
	test-jsonschema: $(foreach example, $(SHEMA_TEST_EXAMPLES), validate-$(example))

into something like this

# datasets used test/validate the schema
SHEMA_TEST_EXAMPLES := \
	biosample_test \
	gold_project_test \
	img_mg_annotation_objects ...

INVALID_SHEMA_TEST_EXAMPLES := \
        invalid_study_test \
        invalid_funct_ano_ids_test ...

.PHONY: test-jsonschema ...

.PHONY: invalid_test-jsonschema ...

And using the same general recipe for test-jsonschema and invalid_test-jsonschema, but applying the ! or - negation to invalid_test-jsonschema?

[wdduncan]

@turbomam I think @sujaypatil96 fixed this :)

Closing ticket. Reopen if needed.