micronax / carbon-german-holidays Goto Github PK

Hello,

when using the library, I get the notification that the use of self in callables is deprecated in the following line:

One fix would be to change it to

return array_map(self::class . '::unix2Date', $holidays);

However, since I am not very experienced with PHP I do not know if this is best practice or not.

Maybe someone can guide me into the right direction so that I can create a PR to fix the deprecation?

Best
Hilko

Line 121: $easter = self::createFromDate($year, 03, 21);
needs startOfDay() because of in_array() check in line 94
Line 121: $easter = self::createFromDate($year, 03, 21)->startOfDay();

Line 137: $easterSunday = self::getEasterSunday($year)->format(u);
returns on Debian system a 1970 year and crashes all further eastern time calculations. Change it to

Line 137: $easterSunday = self::getEasterSunday($year)->timestamp;
because of Carbon correct timestamp method

Hi there,

thank you for this brilliant package! It is working fine but eastern doesn't show up for any year in the checks with isGermanHoliday() for me. Everything else does. I'm currently on Version 2.1.

CarbonGermanHolidays::createFromDate(2022, 04, 17)->isGermanHoliday(CarbonGermanHolidays::ALL_STATES_ALL_DAYS)
CarbonGermanHolidays::createFromDate(2022, 04, 15)->isGermanHoliday(CarbonGermanHolidays::ALL_STATES_ALL_DAYS)