DurableTaskClient.PurgeAllInstancesAsync: NotSupportedException and RpcException for .net 8 isolated about durabletask-dotnet

[dunxbc]

I've encountered this issue as well. Rolling back Microsoft.Azure.Functions.Worker.Extensions.DurableTask to 1.1.0 fixes the issue, it appears to be a regression in v1.1.2 of that package.

[davidmrdavid]

Thanks all, sorry we did not catch this. I'll see if we can fix this in our upcoming releae.

[LockTar]

For me it was enough to downgrade package Microsoft.Azure.Functions.Worker.Extensions.DurableTask from 1.1.2 to 1.1.1.

[SimonCull]

This fix doesn't appear to have made it into 1.1.3, any idea when we'll get it? (unless Microsoft.Azure.Functions.Worker.FunctionsDurableTaskClient does not support orchestration termination. is strictly speaking a different issue).

Edit: just had a look at the NotSupportedExceptions are still there for Purge too

Edit 2: Just seen 1.2.3 release notes

[SimonCull]

@gfgw I'm currently using TerminateInstanceAsync(string instanceId, object? output, CancellationToken cancellation = default(CancellationToken)) as a temporary fix, it is only Task TerminateInstanceAsync(string instanceId, TerminateInstanceOptions? options = null, CancellationToken cancellation = default(CancellationToken)) that is throwing the unintended exception in the latest version

[kemmis]

I ran into this too. Getting System.NotSupportedException: 'Microsoft.Azure.Functions.Worker.FunctionsDurableTaskClient does not support purging of orchestration instances.' when trying to call DurableTaskClient.PurgeInstanceAsync(), after upgrading from 1.0.3 -> 1.1.2.

[kemmis]

Looks like this change caused this: v1.1.1...v1.2.0#diff-c7a6ad429a79519f6c23e141c7d033c7066d66ef34af21302c877fbdd62171c7R373

[Fazer01]

I would like to confirm the issue. Because of this, we cannot delete the orchestrator instances anymore. As these instances contain PII-data and therefore we are not GDPR-compliant anymore.
We've just finished our migration and on the latest package in the DurableTaskClient class the following implementations reside:

public virtual Task<PurgeResult> PurgeInstanceAsync(
    string instanceId, PurgeInstanceOptions? options = null, CancellationToken cancellation = default)
{
    throw new NotSupportedException($"{this.GetType()} does not support purging of orchestration instances.");
}

public virtual Task<PurgeResult> PurgeAllInstancesAsync(
     PurgeInstancesFilter filter, PurgeInstanceOptions? options = null, CancellationToken cancellation = default)
 {
     throw new NotSupportedException($"{this.GetType()} does not support purging of orchestration instances.");
 }

For now, we are falling back to another version (1.1.1 also fixes the issue) as @dunxbc mentioned in hit post above.

[davidmrdavid]

FYI @jviau, and @cgillum (since you were already submitting some changes for .NET isolated already)

[gfgw]

I am running into same sort of problem when upgrading from to the latest version. But then with a NotSupportedException on DurableTaskClient.TerminateInstanceAsync. Will this be fixed as well?

[davidmrdavid]

I'm able to reproduce the issue with Terminate - I was focused only on the purging issue (as in the title) so I missed Terminate had regressed on that same PR. Sorry folks, I'm looking to see if we can implement some kind of breaking change analyzer in the CI to prevent this in the future (not sure if this is the right approach yet) but I'm on it nonetheless.