microsoft / xnat-on-azure Goto Github PK

I just wanted to suggest some improvements to the XNAT Docker implementation, based on what we learned while deploying to the JH environment:

This should be under XNAT_ROOT (e.g. /data/xnat/home)

Because of the way Docker containers are built in layers that are cached, this line should be much lower in the Dockerfile so that if the script changes, the rest of the container will be able to be loaded from the cache if there are no other changes.

This will install the latest PSQL client. It needs to match the version of PSQL that you're connecting to instead.

These folders should not be created here, as they're being made before the external storage is attached to the container so they won't persist. They should be added to the run.sh file instead.

Since this plugin persists outside of the actual XNAT install, it should probably be managed separately from the Docker/start scripts. This would also allow for upgrades to the plugin without rebuilding and redeploying the container.

What is the purpose of copying the config directory? That new folder only lives on the container and isn't referenced anywhere.

This needs to live under XNAT_ROOT (similar to the first improvement note)