microsoftgraph / microsoft-graph-training

Microsoft Graph Training

This repository holds the YAML files used to generate the Microsoft Graph Tutorials.

Microsoft Open Source Code of Conduct

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

microsoft-graph-training's Issues

test issue

Issue with Microsoft Graph Version 5.0.0.

Related to dotnet app only and dotnet

properly also related to: #144

I receive an error on "IGraphServiceUsersCollectionPage" and "Request()".

Microsoft Graph SDK v5 removed request(): Removal of request from the fluent api

My fix was updating the package reference for Microsoft graph from 5.0.0 to the latest v4: 4.54.0

Otherwise maybe update the script within GraphHelper.cs? I am not quite sure how....

initialize_graph_for_user_auth

In the section "Add user authentication", there's a reference to a function initialize_graph_for_user_auth. It doesn't appear in the code, though. I suspect that's why I get errors like this:

azure.core.exceptions.ClientAuthenticationError: Couldn't begin authentication: AADSTS50059: No tenant-identifying information found in either the request or implied by any provided credentials.

Can successfully get token, but cannot get the User Info

I followed the training step by step, for the authentication step, it is working, however for the User info, I will not, the error info does not provide more info, so could anyone meet this error? thanks for your help!

import in python tutorial: from graph import Graph

import in python tutorial: from graph import Graph, no such module

Got a token after device code login, now what?

I don't know if I managed to overlook something here, but I don't see any part in the tutorial or the code it shows that actually handles the token after the device code login.

There's code to show it, but that's it.

And I'm also not sure if I'm misinterpreting the tutorial but after the "Add user authentication" it acts as if we can just restart the program and it will NOT ask for a new device code login the next time. Which is what I'm running into.

I'd really like to know what I am supposed to do with the token and how I am supposed to reuse it, IF I am even supposed to be able to do so. The tutorial isn't even clear about this part.

Check status of mail sent using Microsoft graph.

Hello Team ,

How to know the Microsoft graph has sent a mail successfully for an email id. Make sure it hasn't failed.

This is for C#.

Kindly help.

Regards,
Libin

'MeRequestBuilder' does not contain a definition for 'Request'

On this page https://learn.microsoft.com/en-us/graph/tutorials/dotnet?tabs=aad&tutorial-step=4&source=docs

Below method generates the error 'MeRequestBuilder' does not contain a definition for 'Request':

Potential fix:

Update PHP tutorials to use Microsoft Graph SDK 2.x

Test issue

Tutorial suggests using non-browsable constructor to create credential

Page: https://github.com/microsoftgraph/microsoft-graph-training/blob/main/tutorials/dotnet.yml

In the section titled "Configure Graph client for user authentication" of that page, under step 2 ("Add the following code to the GraphHelper class"), the code example suggest creating the credential using:

_deviceCodeCredential = new DeviceCodeCredential(deviceCodePrompt,
        settings.TenantId, settings.ClientId);

But that constructor is marked with the [EditorBrowsable(EditorBrowsableState.Never)] attribute in source: https://github.com/Azure/azure-sdk-for-net/blob/276e381fa973105926f1847181d6f141585722b3/sdk/identity/Azure.Identity/src/Credentials/DeviceCodeCredential.cs#L56-L57

which prevents it from showing up in intellisense:

or among the available constructors in MS Docs: https://learn.microsoft.com/en-us/dotnet/api/azure.identity.devicecodecredential.-ctor?view=azure-dotnet

Should we be suggesting new users to use constructors that we are hiding on purpose in source? Is there an alternative way to create the credential, without using a hidden constructor?

Typo for config.cfg

graphUserScopes should be like User.Read Mail.Read Mail.Send.
Currently in Azure Identity client library for Python scopes are case sensitive.

ODataError

I followed your Tutorial (https://learn.microsoft.com/en-us/graph/tutorials/python?tabs=aad).
When running the App, I can authenticate in the browser, and by clicking 1 and enter the access token gets displayed. Unfortunatly it is not possible to list the inbox and to send a mail. When trying to send a mail I get an error. The end of the Error says "msgraph.generated.models.o_data_errors.o_data_error.ODataError" I spent the last two days figuring out how to solve it but can't find a solution. All the Scopes are set correct, in the app and in the config.cfg file. I would be very thankful if someone could help me with that issue!

There is no "Forever"

https://devblogs.microsoft.com/microsoft365dev/client-secret-expiration-now-limited-to-a-maximum-of-two-years/

These samples should be updated to reflect this, and how to use x509 and managed identities should be shown (or linked to).

AttributeError: 'GraphRequestAdapter' object has no attribute 'get_token'

Python tutorial gives the error

AttributeError: 'GraphRequestAdapter' object has no attribute 'get_token'.

Caused by the line self.user_client = GraphServiceClient(self.adapter)
which should be self.user_client = GraphServiceClient(request_adapter=self.adapter)

Test issue

confusing

In the section setting up appSettings.js, the document says the following statements:

'tenantId': 'YOUR_TENANT_ID_HERE_IF_USING_APP_ONLY',
'authTenant': 'common',

authTenant If you chose the option to only allow users in your organization to sign in, change this value to your tenant ID. Otherwise leave as common.

On the previous page we configured the in Azure to support user authentication.
These for tenantId and authTenant are confusing. Do we:

1. Leave tenantid blank because we're using user authentication?
2. add the "tenant id" to authTenant?

Side note:
I've been struggling getting anything to work with Azure + Javascript for several weeks now. By itself it's a convoluted topic made more confusing because my organization decided to make it super complicated.

Azure portal App Registration page shows the following names Application (client) ID and Directory (tenant) ID. To further help avoid confusion it would be nice if the names in the document exactly matched where we get the information.

Cannot import name 'GraphRequestAdapter' from 'msgraph'

I tried this tutorial part https://learn.microsoft.com/en-us/graph/tutorials/python-app-only?tabs=aad but can not import GraphRequestAdapter

from msgraph import GraphRequestAdapter, GraphServiceClient
ImportError: cannot import name 'GraphRequestAdapter' from 'msgraph' (/home/user/venv/lib/python3.10/site-packages/msgraph/__init__.py)

Did there change something or what might be wrong? I installed the prerequesites as needed:

python3 -m pip install azure-identity
python3 -m pip install msgraph-core

Incorrect Value Used in Code for DotNet Tutorial

On the page: https://learn.microsoft.com/en-us/graph/tutorials/dotnet?tabs=aad&tutorial-step=3

The line:

_deviceCodeCredential = new DeviceCodeCredential(deviceCodePrompt,
        settings.AuthTenant, settings.ClientId);

is incorrect and should instead read:

_deviceCodeCredential = new DeviceCodeCredential(deviceCodePrompt,
            settings.TenantId, settings.ClientId);

Otherwise it doesn't tie to the tenant you're trying to log into.

I looked for the code directly to make a PR for it but was unable to locate it.

Error running "Display access token" command

On my first pass through the JavaScript tutorial, I got the following CLI error when performing step 4 in the section "Test the DeviceCodeCredential" of Add user authentication:

Select an option [1...5 / 0]: 1
undefined
Error getting user access token: AuthenticationRequiredError: invalid_grant: 7000014 - [2022-06-02 20:15:52Z]: AADSTS7000014: The provided value for the input parameter 'device_code' is not valid.
Trace ID: 28188046-9826-4c16-8083-3e6099d67200
Correlation ID: 2322d5dc-317e-464a-95e5-06b046b88670
Timestamp: 2022-06-02 20:15:52Z - Correlation ID: 2322d5dc-317e-464a-95e5-06b046b88670 - Trace ID: 28188046-9826-4c16-8083-3e6099d67200

Update Go tutorial samples to remove prefix

Related to microsoftgraph/msgraph-sdk-go#397

Remove the package prefix in query parameter structs in tutorial documentation for go. e.g Me from package"github.com/microsoftgraph/msgraph-sdk-go/me"
i.e

query := me.MeMailFoldersItemMessagesRequestBuilderGetQueryParameters

should be

query := me.MailFoldersItemMessagesRequestBuilderGetQueryParameters

ModuleNotFoundError: No module named 'kiota_authentication_azure'

test issue

This repo is missing important files

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

Missing pip install open-telemetry step in python tutorial - Add user authentication

Tutorial: https://learn.microsoft.com/en-us/graph/tutorials/python?tabs=aad&tutorial-step=3

When running, last command, there is an error message explaining that open-telemetry is not installed.

To solve this problem, add the following pip installs:

pip install opentelemetry-api
pip install opentelemetry-sdk

I suggest adding that somewhere in the documentation.