miczeq22 / simple-chat-app

simple-chat-app

Example app written for article purpose: How to write video chat app using webrtc and nodejs

simple-chat-app's Issues

unable to run

always getting error
C:\Users\ajay\Downloads\simple-chat-app-master\simple-chat-app-master> npm run dev

@ dev C:\Users\ajay\Downloads\simple-chat-app-master\simple-chat-app-master
nodemon --watch './src/**/*.ts' --exec 'ts-node' ./src/index.ts

[nodemon] 1.19.4
[nodemon] to restart at any time, enter rs
[nodemon] watching dir(s): '.\src***.ts'
[nodemon] watching extensions: ts,json
[nodemon] starting 'ts-node' ./src/index.ts
''ts-node'' is not recognized as an internal or external command,
operable program or batch file.
[nodemon] app crashed - waiting for file changes before starting...

Question: Why call user after answer made?

On the following snippet (scripts/index.js)

socket.on("answer-made", async data => {
  await peerConnection.setRemoteDescription(
    new RTCSessionDescription(data.answer)
  );

  if (!isAlreadyCalling) {
    callUser(data.socket); // ??
    isAlreadyCalling = true;
  }
});

Why does the receiver have to make a call back to the initial caller? I looked through several tutorials, and none of them mentions that.

Deployment Over the network

Great work, I highly appreciate your work and it helps me alot in my work. However, I am facing issues on deploying it over the network. I have successfully deployed node server and everything works fine except audio and video stream. Both callers does not receive audio and video stream of each other. Can you further guide me on this issue that how can I send and receive data or audio, video on peer to peer connection.

rename the repo

Naming is actually one of the most difficult tasks in engineering. Can we put the words "nodejs" or "webrtc" into the name of the repo? I almost passed the project when I was looking through the github for the example from the blog article.

Question: Start video from on click event

Hello,

Thanks for the tutorial.
I couldn't find any other way of contacting you.

I've followed the tutorial, and it works great. However, I would like to start the camera when the user clicks a button. I've tried wrapping the navigator.getUserMedia inside a function, but it seems like the stream is being called last, so the connection is never made.

Also, how would you go and close a connection?
Thanks.