GithubHelp home page GithubHelp logo

mienaiyami / yomikiru Goto Github PK

View Code? Open in Web Editor NEW
211.0 12.0 11.0 26.56 MB

An offline desktop reader for manga, comics, and novels. Offers a customizable reading experience with extensive settings, shortcuts, themes and layouts. Manga reader / Manhwa reader / Webtoon Reader / EPUB Reader. **Not a downloader**

License: MIT License

JavaScript 0.24% TypeScript 89.02% HTML 0.29% SCSS 10.45%
windows desktop manga manga-reader manga-viewer comic-reader comic-viewer image-viewer infinite-scrolling manhwa

yomikiru's Introduction

yomikiru's People

Contributors

mienaiyami avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

yomikiru's Issues

Natural sorting for chapter lists

Description of the new feature / enhancement

As it stands, chapters are sorted alphabetically in the side list. One problem with this is the way extra/omake chapters are commonly numbered

Extra chapters end up being sorted before the main chapter:
Vol. 5 Ch. 41.cbz
Vol. 5 Ch. 42.5.cbz
Vol. 5 Ch. 42.cbz
Vol. 5 Ch. 43.cbz

An option for natural sorting would fix this:
Vol. 5 Ch. 41.cbz
Vol. 5 Ch. 42.cbz
Vol. 5 Ch. 42.5.cbz
Vol. 5 Ch. 43.cbz

Scenario when this would be used?

No response

Supporting information

No response

--topBar-hover-color

Steps to reproduce

  1. Go to --topBar-hover-color and pick a color that is different from --body-bg.

✔️ Expected Behavior

Expecting the top bar color to change to chosen color in --topBar-hover-color.

❌ Actual Behavior

Top Bar color is not changing, but the home and settings button background color changed to the selected color.

Feature Request

  • Option to show images in their 'original size' in the reader menu of manga reader.

By the way I created a listing of your application in alternativeto.net.

List View

Setup or portable version of the app?

Portable

Steps to reproduce

I have used the maximum word limit possible for both chapters and manga titles in the test file.

  • Open any manga and chapter that have long titles.
  • Or open the test file - TESTTE~1.ZIP.

✔️ Expected Behavior

  • Manga: Title to start after Manga: not from the bottom.
  • Manga, chapter titles to not clip through the margin and on to the reader.

❌ Actual Behavior

  • Manga title is not aligned to Manga: but instead starts from the bottom.
  • Manga title and chapter title clips through the margins.
List.View.mp4

Audit Usage

Issue

Audit usage of navigator.userAgent, navigator.appVersion, and navigator.platform

  • A page or script is accessing at least one of navigator.userAgent, navigator.appVersion, and navigator.platform. Starting in Chrome 101, the amount of information available in the User Agent string will be reduced.
  • To fix this issue, replace the usage of navigator.userAgent, navigator.appVersion, and navigator.platform with feature detection, progressive enhancement, or migrate to navigator.userAgentData.
  • Note that for performance reasons, only the first access to one of the properties is shown.

AFFECTED RESOURCES

  • index.js:1
  • Learn more: User-Agent String Reduction

image

Option to disable chapters read

Description of the new feature / enhancement

Do not limit the history (continue reading), but limit the highlighting of already read chapters.
If possible, add this too in the next update.

Scenario when this would be used?

No response

Supporting information

No response

Chapter Information Screen in v2.5.0

Issue

Added screen to show previous/current/next chapter when in start/end of chapter for zen mode.

  • The screen also appears outside of zen mode.
  • Please provide an option in reader settings to enable/disable the screen completely.

Reader Settings

Issue

- Since 'max image width' is linked to clamp, moving it to the size column

- And some other suggestions to make the reader settings appear more spacious.

1

History

Setup or portable version of the app?

Portable

Steps to reproduce

  • Open any manga.
  • Close it and open another chapter or manga.

Test File - TESTTE~1.ZIP

✔️ Expected Behavior

  • Explained in #69 and below comments.
  • To record all read chapters.
  • And latest read chapters at the top.
  • And manga, chapter titles to respect margins.

❌ Actual Behavior

  • Only records latest record and deletes the previous record.
  • Clips through the margins.
History.mp4

Stuttering on large Images still present

Until v2.3.5 I could see the stutter, but now the Stuttering has been fixed.

  • Even while scrolling up or down very fast, there is no stutter now.
  • Now I do not see any stutter except in large images of size (2000 x width).
  • If you want to test it yourself, I can send the images to you.

By the way, what does scroll speed 1 and 2 do?

Thank you for fixing the stuttering issue.

Zen Mode Bug

  • I have used the latest version 2.3.0 and found a problem.

  • The zen mode/full screen mode hides all UI elements, except it does not hide its scroll bar and windows taskbar.

  • I apologize if I am being particular.

UI Suggestion/Request

Issue

1. Shortcut Keys

- The highlighted buttons look good, but more space between the sentences.

4

2. Max Width

  • Renaming it to 'Images max width' would be more relevant and a button beside it.
    image

3. Large Spaces

  • The UI feels a bit cluttered mainly because of the large spaces beside the values.
  • Keep the 'px' as it is, but please remove the large space at values place. It is unnecessary.

4. Suggested UI

1

5. Some Minor UI Enhancement in Other Settings

- (by clicking the name instead of arrow) to by clicking the name instead of arrow.

- Brackets are unnecessary.

2

6. Theme

- Numbering would be better for the main sentence and bulletin for the sub sentence.

3

Bug and Feature Requests

Bug

Stuttering always happens when scrolling to the next page.

  1. The stuttering always happens when going to the next page no matter the page settings.

Feature

I noticed that the application resizes large images to the width automatically to fit them to the display.

  1. It would be better to provide an option to show images in 'original size' and 'fit to width' separately.
  2. Read with manga reader option in the 'file explorer context menu'.
  3. Customizable shortcuts at least for previous chapter / next chapter.
  4. A portable version.
  5. When opening the app show app logo instead of a colorful rectangular box.

Theme maker bugs

Issue

Text Color And Icon Color

  • These both are not linked properly in reader settings.
  • Size, pages per row, reading mode, scroll a, px, etc. These are linked to Icon Color instead of Text Color.
  • 1:1 is linked to text color instead of icon color.

Text Colour

List Item BG Color

  • This is at two places with the same name.

Body BG Color

  • Not Working properly.
BodyBG.mp4

some jpg images are not opening

Not all jpg format images, but some are not opening up in manga reader.

  • I uploaded the folder which is not opening for me in the application.
  • This is the first time I encountered this issue in the application.
  • To make sure, I checked again with another manga that is in jpg and it works fine.

This is what happens,

screenshot

Please check the below folder that has the images.

#1 - Episode 1.zip

Some Ideas

Description of the new feature / enhancement

Miscellaneous ideas.

1. Zen Mode to Zen Mode / Full Screen

  • To avoid confusion for new users to this app to know where full screen option is in shortcut keys.

1

2.

2

3.

3

4. UI Idea.

  • More Space after and before colon.
  • More Space between Manga and Chapter.
  • Border surrounding Manga and Chapter.

4

Scenario when this would be used?

Normal Use.

Supporting information

No response

Suggestion

Suggestion to make this manga reader more searchable on github.

  • I have searched github many times for a manga and webtoon reader and I could not find this manga reader, until I viewed almost all the available manga readers on github.

Tags

The tags you currently use are windows, typescript, reactjs, desktop, electronjs. Adding other relevant tags would be better, like,

  • manga reader
  • manga viewer
  • manga
  • comic
  • manhwa
  • manhua
  • webtoon
  • comic reader
  • comic viewer
  • manhwa reader
  • manhwa viewer
  • manhua reader
  • manhua viewer
  • webtoon reader
  • webtoon viewer
  • infinite scrolling
  • continuous scrolling
  • vertical scrolling
  • image viewer
  • continuous image viewer
  • vertical image viewer
  • cbz reader
  • cbz viewer
  • cbr reader
  • cbr viewer, etc.

I have used many popular manga readers like, html mangareader, CDisplay Ex, OpenComic, YAC Reader and many others, and I found this to be the best manga/webtoon reader.

Minimal CS Manga Reader is the next best only for its UI, but it takes up too much memory and cannot even open large images and is dependent on .net. But its UI is one of the best among the manga readers that I have used.

Bugs In v2.3.4

BUGS IN THEME MAKER

1. --btn-color2
It does not select all the secondary buttons and only selects some secondary buttons.

2. --input-bg
It changes the background color of buttons too.

3. --topBar-hover-color
It does not work and changes the color of top bar icons.

4. --listItem-bg-color
The pinned list color is linked to '--body-bg'. So '--listitem-bg-color' is unnecessary. It does nothing.

BUGS IN READER

2. Page Indicator

  • It freezes when the side list is pinned. This issue is also present in v2.3.3.
  • It freezes when a value greater than the total number of pages of the concerned folder is entered.

3. Memory Usage

Compared memory usage of v2.3.4 and v2.3.3 side by side.

  • Memory usage is high compared to the previous version.
  • Takes 30 - 40 MB more memory than previous version in the reader.
  • Memory usage goes down slowly in idle state compared to the previous version.
  • But it uses 4MB to 6MB less than the previous version, when only the home screen is opened.

Bookmarks and History hover

Description of the new feature / enhancement

Hover over the history/bookmarked manga/chapter in home screen and you can see the name of manga, chapter, pages, date.

  • Can you add the colon for both of them too as you did for the reader for the upcoming update. Thank you.

1

Page Number Freeze

Page number freezes only when the side list is pinned. When it is unpinned the page number counter works.

Reader Bugs

Setup or portable version of the app?

Portable

Steps to reproduce

Reader Bug

  • Open any manga in the reader.

✔️ Expected Behavior

  1. To show all pages.
  2. And to be able to scroll up the images even when the side list is pinned.

❌ Actual Behavior

  1. Only shows one page.
  2. And Cannot scroll up the images when the side list is pinned.
Reader.mp4

Theme Maker Bugs

Issue

1. --icon-color

  • 'Link' is linked to --font-color instead of --icon-color.
  • Some fonts are changing when using --icon-color. The fonts should be linked to --font-color.

2
--icon-color
2

Feature Request

Thanks for the responding to my previous suggestions. Some new feature requests.

  1. A full screen mode option.
  • To make the reading more immersive only images are to be shown and no side menus, no scroll bars, no left pin in full screen mode.
  1. An option to check or uncheck auto updates.
  2. In reader settings, under other settings, make the font larger.
  3. A pure dark/black theme option. theme1 seems like gray, theme2 dark blue, theme3 white.
  4. What I meant by portable is that the app must save the user data, bookmarks in the portable folder only.

Better options for image fit

Description of the new feature / enhancement

Really liking this reader so far, just wishing it had better image fit options. My suggestion is to replace the current options with the following ones:

  • Option to view image in 1:1 native res
  • Option to Limit to Width, Height, or Both
  • Option to Stretch Width, Height, or Both

Basically I'm describing the options on the cubari.moe online reader

Scenario when this would be used?

No response

Supporting information

No response

Setup misbehavior

Setup or portable version of the app?

Setup

Steps to reproduce

yokimiru.mp4

✔️ Expected Behavior

No response

❌ Actual Behavior

No response

.EPUB Support

Description of the new feature / enhancement

To Read novels.

Scenario when this would be used?

No response

Supporting information

No response

New and previously known Bugs

Thanks for your hard work for making customizable shortcuts and full screen mode available.

I have checked out the latest update and found some new bugs.

Bugs

Only when the side list is pinned,

  1. Scrolling is no longer possible using mouse cursor.
  2. The page number display counting does not work. The number freezes at 1.
  3. Even clicking on the center of image (little bit to the left or right) makes the chapter change. This happens even when the side list is unpinned.
  4. When full screen/zen mode is activated, the images become very small and are pinned to the left side of the screen.

Better History Recording

Description of the new feature / enhancement

  • For example, chapter 1,2,3 are opened, currently they all are recorded in history, instead only record last opened chapter i.e, 3.
  • After opening another 2 chapters from the same manga and opened chapter 3 again, then only record chapter 3 in history.
  • Only the last opened chapter should be recorded in the history column for that manga.
  • Same for different mangas.

Scenario when this would be used?

  • History record will be greatly reduced in this way.
  • In this way, each manga will have only one record of history.
  • It will be more efficient and the chapter last read from different mangas will be known easily when there large collection of mangas.

1

Supporting information

No response

Bug In Theme Maker

1. Bug '--topBar-color'

  • I changed the body of the manga reader to black using '--body-bg' property, but the side list color remained the same.
  • The side list is linked to '--topBar-color', instead of '--body-bg' property.
  • Because of it, if I try to change the side list color, top bar color also changes with it.

Screen Disable In Vertical Scroll Reading Mode

Setup or portable version of the app?

Portable

Steps to reproduce

Go to next / previous chapter by using mouse click on the right / left part of the image.

Screen.Disable.mp4

✔️ Expected Behavior

To not show the screen in vertical scrolling mode.

❌ Actual Behavior

Shows the screen.

Unexpected behaviour after Entering/Exiting Zen Mode

Setup or portable version of the app?

Portable

Steps to reproduce

  1. Open any manga.
  2. Scroll down a little bit in the same page and enter/exit zen mode.
  3. It will enter/exit the zen mode at the starting of the current reading page.

✔️ Expected Behavior

To enter/exit zen mode at the same location.

❌ Actual Behavior

When entering/exiting zen mode the app starts at the starting of the current page.

Feature Requests

1. Option to hide/show the page counter in full screen/zen mode.

  • Place the page counter at the bottom right end of the screen, only in the zen mode, if possible.

2. Reset Button beside the color/Opacity to reset to the default value.

image

Feature Request

1. Confirmation Dialogue Box On application Exit.

  • A confirmation dialogue box when trying to exit the application.
  • Example - Shortcut keys dialogue box of your app when trying to assign the same 'key' to another function.

image

2. Dialogue Box

  • The above dialogue box in in light theme, even when my system theme is set to dark theme.
  • The Manga Reader Application is also set to dark theme.

Stuttering when scrolling down large size images or too many images

If any dev reading this knows the solution, please reply.

  • Less prominent with app.disableHardwareAcceleration();
  • Appears to depend on hardware capability.
  • Does not stutter once you have scrolled to the end. So, its related to how chromium render images?
  • Images are preloaded by setting src on const img = document.createElement("img"); inside useLayoutEffect(()=>{ },[])

UI scale

Steps to reproduce

  1. Increase UI scale using Ctrl +/= (Do this 2-3 times, it depends on display, but 2-3 times should do it)
  2. Open any manga
  3. Open Reader settings

✔️ Expected Behavior

Everything works fine and the size increases for fonts, objects and all.

❌ Actual Behavior

Reader settings size also increases, but the bottom settings disappear.
What I mean is that they are not possible to scroll down to.

Going to next/previous chapter is broken with CBZ archives

Setup or portable version of the app?

Portable

Steps to reproduce

I haven't had time to check until now, but I get an error when I try to go to the next or previous chapter using either the hotkeys and clicking on the sides on the last page. Clicking directly on chapters in the sidelist works, though. This happens with every CBZ.

✔️ Expected Behavior

Going to the next/previous chapter in the list without error.

❌ Actual Behavior

Error No.: -4058
ENOENT: no such file or directory, scandir 'C:\Library\Manga\Useless Ponko\Vol. 1 Ch. 1 - Ponko The Maid [CBZ file]'

(it's supposed to be chapter 73)

error

Zoom Size

  • I am confused about the zoom size system you use in the manga reader.
  • The zoom size is depended on the screen size rather than the manga image.
  • For example when I open a manga chapter (all images containing 1000x1600), the zoom size shows < 100%, until the image is fit to the screen completely, only then it shows 100%.

Memory And Cpu Usage

  • CPU Usage When stutter keeps on happening while scrolling down images.

Cpu.Usage.When.of.Manga.Reader.Stuttering.Happens.mp4

I have also noticed the memory usage not going down even after being idle for 10 minutes.

  • After cycling through folders and going back to the starting folder, shouldn't it have the same memory usage when started. Here it is using more memory after cycling through 4 folders and going back to folder-1.
  • Some Examples below.

Example 1 - Folder Size= 4.86 MB, Total Images = 17, Resolution = 1760 x varies (height x width).

  • After cycling through 4 folders and going back to folder 1, the usage is shown below.
  1. Red = Images loaded and cycled through 4 folders and after going back to folder-1.
  2. Green = Same folder-1 loaded as red, but when it did not cycle through any folder. Remained constant at folder-1.

1 - Below 3 minutes of Being Idle, no usage

2 - After 3 to 5 Minutes of Being Idle, no usage

Example 2 - Folder Size= 27.5 MB, Total Images = 58, Resolution = 2400 x varies (height x width).

  • After cycling through 4 folders and going back to folder 1, the usage is shown below.
  1. Red = Images loaded and cycled through 4 folders and after going back to folder-1.
  2. Green = Same folder-1 loaded as red, but when it did not cycle through any folder. Remained constant at folder-1.
  3. White = Manga Reader Home Screen. No Images Loaded.
  • After 9 Minutes of Being Idle, no usage. The memory usage did not go down.

After 9 Minutes of Being Idle, no usage

Limit Gap between Pages max value px

Issue

- Please limit the gap between pages max value enterable to either 50 px or 100 px.

- Generally 10 px - 20 px is used for reading manga, if page gap is needed.

Settings Error Pop-up

Issue

  • Settings error pop-up appears on first run and every time the application is refreshed.

1

Add more types of Images support

Description of the new feature / enhancement

I have a lot of mangas and they are in different formats like webp files. when i try to open these files the program say format not supported.

Scenario when this would be used?

When i try to open webp image files

Supporting information

No response

Some Questions

I noticed the less memory usage in the update v2.3.3.

  1. How many pages does the reader cache now? Or is the caching completely disabled?
  2. The CPU usage remained the same. Is it possible to reduce the CPU usage?
  3. Image formats supported by the application?

Home Page Blank Screen

Steps to reproduce

  1. Open Yomikiru again after checking 'ask before closing window'.
  2. After opening yomikiru, close it.
  3. Dialogue box pops up, but the background will become black.
  4. It remains black until restarted or ctrl+r.
  • This only happens when manga reader is opened from the folder or without any manga. Only happens in homepage.

✔️ Expected Behavior

No blank screen.

❌ Actual Behavior

Blank screen.

image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.