GithubHelp home page GithubHelp logo

migaku-official / migaku-japanese-addon Goto Github PK

View Code? Open in Web Editor NEW
105.0 105.0 25.0 70.8 MB

Migaku Japanese is an Anki add-on to help you learn Japanese more easily. If you have an issue please report it in the "Issues" tab. Reponses to issues can be slow on GitHub, for faster support consider joining our Discord server through our Patreon page.

License: GNU General Public License v3.0

Python 97.53% JavaScript 2.47%

migaku-japanese-addon's People

Contributors

cyphar avatar kieranbrannigan avatar lucasmia avatar mikemoolenaar avatar shanrauf avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

migaku-japanese-addon's Issues

Japanese Settings window displays strange

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Kubuntu 19.04
  • Display: 1920 x 1080
    Let me know if you need more info

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:
When I open Japanese settings, it appears like this for me:
image

Build scripts for supporting libraries and executables

Nature of issue?

  • New feature request

New feature details:

It'd be nice to have scripts necessary to build files in src/support bundled with this repository, as there are certain platforms current prebuilt binaries don't cover (i.e. non-glibc Linux, the BSDs). I wouldn't mind contributing a set of generic Linux scripts, but I'd like to hear your opinion on the matter before investing what could be a decent amount of effort.

Addon conflict with pop-up dictionary

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Windows 10

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:
I've reported this problem on the pop-up dictionary github page before and so far, the problem has been resolved with the MIA Dictionary addon, but not with the MIA Japanese addon.
When the MIA Japanese addon is active, the pop-up dictionary addon will not work.
I hope you can apply the same fix as you did with the MIA Dictionary addon.
Cheers,
Hades.

壊し方 parsing error

でも[;a]   その場[そのば;h,o] 所[ところ;h] と   壊[こわ,こわす;k2]し 方[ほう;a] が 分[わ,わかる;k2]からない 。
Should be こわしかた (壊し方)

島 parsing error

E.x 島[とう] は この よう に should generate 島[しま]

In mass-generation, Audio field is replaced even if not asked to

Type:

  • [ x] bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Macos

I'm going to open a PR to resolve the issue:

  • yes
  • [ x] no

Description:
[ Write the issue description here ]

In the bulk-add-readings, everything works, except that, if there is a field called Audio, it is replaced, even if not asked to.

My scenario: I have 1000 cards, with 15 fields, including Audio. I asked the bulk-add-readings to replace the field meaningFuri (overwrite). For every card, this field is replaced, but also the field Audio.

The work around was to rename the field Audio to AudioNot and then back.

Customize colors for light/dark mode

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Win10

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:
With Dark Mode comming to native anki, would it be posible to customize the colors for light and dark mode respectively?

Underlines doesn't show for words which can hover

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Windows 10

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:
I am using Mini Format Pack to add some styles to the word. Bold and italic can be applied normally, but underline doesn't appear.
Other words that aren't annotated with [] can be underlined normally.

Card

image

Preview

image

Multiple audio files / audio files for all words or components of words in one field

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Windows

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:
There's only one feature from the old NHK accent addon (or at least the dev branch of it that I maintained) that doesn't seem to have been fully carried over to this one, and that's the ability for audio/accent graphs to be generated for multiple words at once. This is especially useful for compound words, since sentences are sort of already covered by the click to listen functionality. For example, some text I ran the old addon on gave the following results (although this example is also covered by click-to-listen, I guess...although it fails with e.g. forvo, but that's a different addon):
input: [悪性/良性]腫瘍
output: [sound:悪性.yomi0006D45B_0266.wav][sound:悪性.yomi0006D463_02FA.wav][sound:悪性.yomi0006D46C_009E.wav][sound:良性.yomi0009E915_00C2.wav]

(although in this case 腫瘍 wasn't found, for some reason I don't remember)

On the other hand, this does "work" (in that it can parse this to find the audio):
input: 鰊・鯡
output: [sound:にしん.yomi00024700_0078.mp3]

so it seems like the infrastructure for doing this exists.

There are various ways to design this: it could always return the audio for all components, it could give it only when the full value of the field isn't found, it could give all components with 2 or more characters (seems reasonable to me), or maybe something else. It would work for both compound words with no clear boundaries between components, and for sentences.

Cannot add notes with type "MIA Japanese" because of JavaScript in template

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Slackware Linux Current
  • Anki version: 2.1.17 (4cead7ef)

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:
It is impossible to add cards using the provided MIA Japanese note type. Upon filling in a card such as "お茶” for expression, "tea" for meaning, and clicking the word-fill button to provide audio, the error message "the provided input would give an empty question on all cards" and can be resolved by removing the entire JS block in the front side. I don't know what could be wrong with the code, but the card template does not like it.

Better morphemizer dict (ipadic-neologd)

There's a better dictionary for mecab called neologd, although it's quite bulky (1gb vs the 50mb currently bundled dict vs the 250mb ipadic morphman addon).

https://github.com/neologd/mecab-ipadic-neologd

It would solve a lot of accuracy issues with readings that are popping up. Also, even the latest mecab-ipadic is 8 years old (!) while neologd is a new corpus that has been updated as recently as a few weeks ago.

とおり vs どおり parsing

Nature of issue?

  • Found a bug

Details about the bug:

Should be どおり:
言葉[ことば;o] 通[とお;o]り 単純[たんじゅん;h] な 意味[いみ;a] で 分[わ,わかり;o]かり やすい[,やすい;k2] 。

[feature request] showing furigana for one word (e.g.TargetMorph) only

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Win & Android

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:
This should be a feature for introducing new words.

Imagine you have an example sentence in your expression field with a Target word in it you ought to learn (e.g. from a vocab list for japanese class).
母は私に風呂場の掃除をさせた。
In this case I am introduced to the word ふろば, bathroom for the first time for that I should not know the reading yet.
However, with the current MIA Addon, I can only read unknown (kanji) words with advanced kanji reading skills or by clicking 風呂場 to learn the reading & pitch accent.

By showing furigana on default for the unknown word, with the reading certainly unknown too, you can save one click (especially on mobile devices) and would allow faster acquiring of new words.
And after a couple of times (e.g. it reaches mature) you could switches to show just pure Kanji.

This might only seem like a small feature but would make the MIA Addon a more universal all-in-all
experience.

Front of Mia Japanese cards are blank

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Windows 10

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:

It actually happened to me more than once. The last time it happened I was adding some cards to Anki as I would, but I unintentionally clicked at "cards"(where we see the card type), didn't do anything else, and this error "the front of this card is blank" started to pop up. I could solve it after reinstalling Anki and doing the same thing.

This time around, though, the same error happened, but unlike last time, I didn't do anything. I just opened Anki next day and this error happened again. I tried the same tricks, opening and closing "cards", reinstalling, but nothing of it worked.

Anki's card are normal, but the custom Mia japanese card I made and the original Mia Japanese both stopped working properly, with this "The front of this card is blank" error.

Long history short, I tried reinstalling MiaJ but it said Anki 2.1.19(my version) wasn't supported, so I downloaded Anki 2.1.22 but Morphman didn't work, so I went to Anki 2.1.15 and reinstalled Mia Japanese through there, and MiaJ Cards started working again even in Anki 2.1.19, but my custom one didn't.

Here you can see the front/back of my custom card (I don't know if it helps, but...): https://gist.github.com/AmodeusR/1d6cfa972052e7c9858367b7d2713a2d

But before anything, it does not differ in nothing from the original, other than the field names, they are basically translated, use a text compare to see it. It was working fine for a long time and it just stopped working, that first time I said and now this time.

Edit: In the card type tab it shows the text working just fine: https://prnt.sc/s1hah6
it is only when I try to study it, it doesn't work.
Edit²: On Ankiweb cards work just fine, but for some reason, it doesn't on Anki Desktop App.

Can't change the "Audio Field(s):" in japanese settings.

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Windows 10

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:
Can't change the audio field, no matter how many times I apply these settings, it doesn't seem to change it.
"Current Audio Fields" stays stuck in "Audio".
I'm trying to use Audio for sentence audio from Voracious, and Word Audio for MIA Japanese Addon audio.
image

inconsistent conversion

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Manjaro Linux x86_64
  • Host: 13Z970-A.AAS5U1 0.1
  • Kernel: 5.3.7-2-MANJARO
  • WM: awesome

but this has nothing to do with my environment

Going to open a PR:

  • yes
  • no, cuz im not sure how it was set up. but if someone can tell me, then ill know for the future what to do

Description:
The conversion to the old japanese spelling system gives inconsistent conversions.

image

the upper line is display-type="kanji" and the lower 2 lines are both display-type="coloredkanjireading"

the upper line converts ヨウ to ヤウ, but on the second line it doesnt.
on the third it converts 今一 to ヰマイチ even though いま was never ゐま

誰 parsing error

Nature of issue?

  • Found a bug

Details about the bug:

Should be だれ, not だ.
Example: 俺[おれ;h] の 稽古[けいこ;a] は 誰[た;a]が つけて[,つける;k2] くれ[,くれる;h,o] る ん だ よ

Generation of Audio and Pitch Graph fields doesn't work with "If Empty"

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Windows 10
  • Add-on version: latest (0.6.0 I think?)
  • Anki: 2.1.22

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:
Generation of Audio and Pitch Graph fields don't work when set to If Empty, even when the target fields are empty.
image

keyboard library requires root on GNU/Linux

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: GNU/Linux

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:

It looks like the keyboard library requires root on GNU/Linux, when calling keyboard.add_hotkey from Clipthread.run(), it fails when checking for root. I'm not sure how things work inside of Anki, but prior to initializing it looks like there needs to be some sort of request for root in order to use the keyboard library (From the boppreh/keyboard readme: Works with Windows and Linux (requires sudo))

Caught exception:
  File "/home/dad/.local/share/Anki2/addons21/MIADictionary/midict.py", line 604, in run
    keyboard.add_hotkey('x', self.handleSentenceExport)
  File "/home/dad/.local/share/Anki2/addons21/MIADictionary/keyboard/__init__.py", line 637, in add_hotkey
    _listener.start_if_necessary()
  File "/home/dad/.local/share/Anki2/addons21/MIADictionary/keyboard/_generic.py", line 35, in start_if_necessary
    self.init()
  File "/home/dad/.local/share/Anki2/addons21/MIADictionary/keyboard/__init__.py", line 194, in init
    _os_keyboard.init()
  File "/home/dad/.local/share/Anki2/addons21/MIADictionary/keyboard/_nixkeyboard.py", line 113, in init
    build_device()
  File "/home/dad/.local/share/Anki2/addons21/MIADictionary/keyboard/_nixkeyboard.py", line 109, in build_device
    ensure_root()
  File "/home/dad/.local/share/Anki2/addons21/MIADictionary/keyboard/_nixcommon.py", line 174, in ensure_root
    raise ImportError('You must be root to use this library on linux.')
<class 'ImportError'>: You must be root to use this library on linux.

Parsing error with 摘まむ

Nature of issue?

* Found a bug

Details about the bug:

For example: 靴下[くつした;n2,o] を 干[ほ,ほす;k1]す 時[とき;o] は 爪先[つまさき;h] を 摘[つま,つまむ;h]ま まな[;a] い と それ[;h] だ と ゴム[;a] 伸[の,のび;o]び ちゃう でしょ

そんな parsing error

Nature of issue?

  • Found a bug

Details about the bug:

For example: そん[;a] な 限[かぎ,かぎる;k2]られた 大切[たいせつ;h] な 時間[じかん;h] を

bad historical conversion

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Manjaro Linux x86_64
  • Host: 13Z970-A.AAS5U1 0.1
  • Kernel: 5.3.7-2-MANJARO
  • WM: awesome

but this has nothing to do with my environment

Going to open a PR:

  • yes
  • no, cuz im not sure how it was set up. but if someone can tell me, then ill know for the future what to do

Description:
Historical Conversion converts character into kana outputted instead of kana expected:

character kana outputted kana expected
ジョウ ジヤウ
ウエ ウヘ
ジョウ ジヤウ
今一 ヰマイチ イマイチ

ところで pitch accent error

Nature of issue?

  • Found a bug

Details about the bug:

Should be odaka: ところで[;n3] さ ! この 火[ひ;o] って どれ[;a] くらい 保[たも,たもつ;k2]つ の?

Parsing error with くれる

Nature of issue?

  • Found a bug

Details about the bug:

For example: ちょっと[;o] これ[;h]   解[と,とく;k1]いて みて[,みる;k1] くれ[,くれる;h,o] る ? くれ[,くれる;h,o] る

Should be はんする or かえす depending on context

Nature of issue?

  • Found a bug

Details about the bug:

By itself, 返す is parsed as かえす, but in the following case, it should be はんする:
専門家[せんもんか;h] の 予想[よそう;h] に 反[そら,そらす;k2]して 、 景気[けいき;h] は 回復[かいふく;h] し[,する;h] 始[はじ,はじめる;h]めた 。

Unable to selected default text color

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS:

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:
I've set my background colour to be dark grey to reduce eye strain, but the default text colour is black and cannot be changed. Can you please add a field to change the default colour?

anki_eMmuLi0UD1

上がる sometimes does not get parsed correctly

Nature of issue?

  • Found a bug

Details about the bug:

By itself, 上がる gets parsed correctly, but in the following sentence, it does not:
ガソリン[;h] の 値段[ねだん;h] が また上[またがみ;h] がり[;k1] まし[;h] た。

Clash with "multiple windows" add-on

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Linux (Debian Buster)
  • Anki: 2.1.8

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:
When the "Opening the same window multiple time[s]" add-on is installed and in its default configuration, audio generation (語) does not work: No [sound:...] is placed in the target audio field. After uninstalling the referenced add-on, the problem goes away, but it would be nice if it could be used in parallel to the MIA Japanese add-on.

Highlighting a single kanji and pressing 削 throws TypeError

Nature of issue?

  • Found a bug

Details about the bug:

When highlighting a single kanji and pressing the 削 button, this error is thrown:
TypeError: wrapSelection is not a function or its return value is not iterable

The fact that the error mentions something about not being iterable makes me think the error is related to the fact that a single kanji/word is being highlighted as opposed to a whole selection that has been parsed by the addon.

私 から incorrect parsing

Nature of issue?

  • Found a bug

Details about the bug:

For example: 私[ひそ;n2,a]か ら は 説明[せつめい;h] し[,する;h] かね[,かねる;h] る

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.