mike-works / sass-fundamentals Goto Github PK
View Code? Open in Web Editor NEWπ¨βπ« Mike's Sass Fundamentals Course
Home Page: https://frontendmasters.com/courses/sass/
License: BSD 3-Clause "New" or "Revised" License
π¨βπ« Mike's Sass Fundamentals Course
Home Page: https://frontendmasters.com/courses/sass/
License: BSD 3-Clause "New" or "Revised" License
Branch | Build failing π¨ |
---|---|
Dependency | greenkeeper-lockfile |
Current Version | 1.13.0 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
greenkeeper-lockfile is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
The new version differs by 6 commits.
1acf3b9
fix(yarn): preserve caret ranges
f90e178
docs: show how to skip npm latest in travis example
5907bf0
chore(package): update lockfile
eb375d7
chore(package): update tap to version 11.0.0
8a99465
docs: fix typo
4fac409
docs: Codeship Support π
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
π¨ You need to enable Continuous Integration on all branches of this repository. π¨
To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because we are using your CI build statuses to figure out when to notify you about breaking changes.
Since we did not receive a CI status on the greenkeeper/initial
branch, we assume that you still need to configure it.
If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you donβt want it to run on every branch, you can whitelist branches starting with greenkeeper/
.
We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.
I cannot install the repo with npm install, seems all packages required are deprecated and so it throws and error when trying to install some of them.
System Information
After cloning the repo and run npm install a bunch of error messages appear, it happens after the [email protected] package installation. When trying to start the app using ./run -e nesting it shows the following message
node:internal/modules/cjs/loader:936
throw err;
^
Error: Cannot find module 'commander'
On registry https://registry.npmjs.org
, the "latest" version (v5.0.11) of dependency travis-deploy-once
has the following deprecation notice:
We recommend to use Travis Build Stages instead
Marking the latest version of an npm package as deprecated results in the entire package being considered deprecated, so contact the package author you think this is a mistake.
Affected package file(s): package.json
If you don't care about this, you can close this issue and not be warned about travis-deploy-once
's deprecation again. If you would like to completely disable all future deprecation warnings then add the following to your config:
"suppressNotifications": ["deprecationWarningIssues"]
Error: cannot run 'chalk'
is returned when ./run -e nesting
command is run.npm start
from sass-fundamentals foldernpm ERR! Missing script: "start"
npm ERR!
npm ERR! Did you mean one of these?
npm ERR! npm star # Mark your favorite packages
npm ERR! npm stars # View packages marked as favorites
npm ERR!
npm ERR! To see a list of scripts, run:
npm ERR! npm run
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\Nick\AppData\Local\npm-cache\_logs\2022-04-01T20_36_48_496Z-debug-0.log
Any error messages in the JS console
No errors since the app doesn't run.
Describe the bug
The app doesn't run at all, I'm not sure how to install it properly as npm install
doesn't seem to install the right packages
Branch | Build failing π¨ |
---|---|
Dependency | chalk |
Current Version | 2.4.0 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
chalk is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
The new version differs by 3 commits.
48ba5b0
2.4.1
01cfb5c
Improve Flow type definition for CommonJS interop (#268)
fc9a7e3
GitHub now natively supports SVG
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
Hi guys, I don't know if this is the correct place to post it (I'm new to both GitHub and FrontEnd Masters), but anyways:
I have a problem that whenever I save my Sass file (app.scss from Exercise 1), the Git Bash gives me an error... See attached screenshot for exact message.
I'm not sure whether it is a problem with Node, Sass compiler, VS Code or with the course's application!
PS: Node version is v6.9.5
PS2: @mike-north Do the FE Masters' courses have a forum or similar place where the students are able to chat and give feedback? Maybe a Slack channel?
Would you guys help me? :)
Thanks a bunch!
Now when doing Exercise 2 and using the VS Code embed terminal (bash), I get the error with the added info that a Segmentation Fault ocurred... First .scss save worked fine, but the second threw this:
I keep getting errors, and they differ each time... this time (exercise 4) it was:
I found https://github.com/olefredrik/FoundationPress/issues/731 and it might be the solution, but I'm clueless about where I should make use of gulp-wait or change my VS Code saving settings?
This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.
These problems occurred while renovating this repository. View logs.
Warning
These dependencies are deprecated:
Datasource | Name | Replacement PR? |
---|---|---|
npm | travis-deploy-once |
These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.
These updates have all been created already. Click a checkbox below to force a retry/rebase of any.
package.json
chalk 2.4.2
commander 2.20.3
express 4.19.2
livereload 0.9.3
@mike-works/js-lib-renovate-config 2.0.0
@mike-works/workshop-semantic-release-config 1.0.0
node-sass-middleware 0.11.0
semantic-release 15.14.0
travis-deploy-once 5.0.11
.travis.yml
node 8.17.0
Node v7.7.3 doesn't work any longer. Few dependencies have bumped their minimum node version to higher version. Node v8.16 is required to run the exercises.
14.3.0
(...)
throw new Error(errors.unsupportedEnvironment());
^
Error: Node Sass does not yet support your current environment: Windows 64-bit with Unsupported runtime (83)
For more information on which environments are supported please see:
https://github.com/sass/node-sass/releases/tag/v4.9.3
at module.exports (C:\Users\ (...)
Any error messages in the JS console
Describe the bug
git clone [email protected]:mike-works/sass-fundamentals.git
cd sass-fundamentals
yarn install
./run -e nesting
, for example. Expected behavior
The exercise should be running.
Screenshots (optional)
If applicable, add screenshots to help explain your problem.
Additional context (optional)
I redid initital package installation, this time with npm install
, and there was no problem. I wonder why this is not the case with yarn install
. Can you help me figure out why?
System Information
internal/fs/utils.js:229 throw err; ^ Error: ENOENT: no such file or directory, scandir 'C:\Users\Robert\Documents\Personal\Learning\sass\sass-workshop\node_modules\node-sass\vendor' at Object.readdirSync (fs.js:886:3) at Object.getInstalledBinaries (C:\Users\Robert\Documents\Personal\Learning\sass\sass-workshop\node_modules\node-sass\lib\extensions.js:132:13) at foundBinariesList (C:\Users\Robert\Documents\Personal\Learning\sass\sass-workshop\node_modules\node-sass\lib\errors.js:20:15) at foundBinaries (C:\Users\Robert\Documents\Personal\Learning\sass\sass-workshop\node_modules\node-sass\lib\errors.js:15:5) at Object.module.exports.missingBinary (C:\Users\Robert\Documents\Personal\Learning\sass\sass-workshop\node_modules\node-sass\lib\errors.js:45:5) at module.exports (C:\Users\Robert\Documents\Personal\Learning\sass\sass-workshop\node_modules\node-sass\lib\binding.js:15:30) at Object.<anonymous> (C:\Users\Robert\Documents\Personal\Learning\sass\sass-workshop\node_modules\node-sass\lib\index.js:14:35) at Module._compile (internal/modules/cjs/loader.js:1139:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1159:10) at Module.load (internal/modules/cjs/loader.js:988:32) { errno: -4058, syscall: 'scandir', code: 'ENOENT', path: 'C:\\Users\\Robert\\Documents\\Personal\\Learning\\sass\\sass-workshop\\node_modules\\node-sass\\vendor' }
Describe the bug
After cloning the sass-fundamentals repo, I ran npm i
, i did get some deprecation errors but nothing failed to install. Then I ran ./run -e nesting
and got the error message above.
Is your feature request related to a problem? Please describe.
When editing several items, it's hard to tell which change made a SASS error in the terminal. I may be several saves along before I notice that there was an error.
Describe the solution you'd like
It would be beneficial for the exercise terminal to log out every time the CSS file- like browser-sync does when files are saved. It would immediately tell me how long ago I made the mistake so I know how far to back-track.
Describe alternatives you've considered
Include @debug "compiled"
at the bottom of app.scss
Browser type and version: Microsoft Edge Version 92.0.902.84 (Official build) (64-bit)
Terminal type: cmd.exe
Node version: v16.8.0
NPM version: 7.21.1
node-sass version: 6.0.1
OS type and version: Microsoft Windows (Version: 21H1 - OS build: 19043.1165)
Describe the bug
Following the guide from README.md, after executing npm i
, these npm ERRs were thrown, the issue seems to be not able to install node-sass to the current folder:
To Reproduce (on WINDOWS)
Steps to reproduce the behavior:
npm i
which
succeeded C:\Users\ASUS.windows-build-tools\python27\python.exe C:\Users\ASUS.windows-build-tools\python27\python.exeC:\Users\ASUS\.windows-build-tools\python27\python.exe -c "import sys; print "2.7.15 npm ERR! gyp verb check python version .%s.%s" % sys.version_info[:3];"
returned: %jnode --trace-deprecation ...
to show where the warning was created)node-gyp
.npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\ASUS\AppData\Local\npm-cache_logs\2021-08-28T11_49_37_792Z-debug.log
Expected behavior
To be able to complete npm i
and move on to the next step from README.md
Additional context (optional)
I tried to run the following commands and these are their output:
npm install node-sass@latest
npm WARN deprecated [email protected]: Critical bug fixed in v3.0.1, please upgrade to the latest version.
npm WARN deprecated [email protected]: Critical bug fixed in v2.0.1, please upgrade to the latest version.
npm WARN deprecated [email protected]: Please update to ini >=1.3.6 to avoid a prototype pollution issue
npm WARN deprecated [email protected]: Critical bug fixed in v3.0.1, please upgrade to the latest version.
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated [email protected]: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (debug-js/debug#797)
npm WARN deprecated [email protected]: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (debug-js/debug#797)
npm WARN deprecated [email protected]: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (debug-js/debug#797)
npm WARN deprecated [email protected]: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (debug-js/debug#797)
npm WARN deprecated [email protected]: We recommend to use Travis Build Stages instead
npm WARN deprecated @babel/[email protected]: π¨ This package has been deprecated in favor of separate inclusion of a polyfill and regenerator-runtime (when needed). See the @babel/polyfill docs (https://babeljs.io/docs/en/babel-polyfill) for more information.
npm WARN deprecated [email protected]: request has been deprecated, see request/request#3142
npm WARN deprecated [email protected]: request has been deprecated, see request/request#3142
npm WARN deprecated [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which
is known to be problematic. See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated [email protected]: This version of tar is no longer supported, and will not receive security updates. Please upgrade asap.
npm WARN deprecated [email protected]: core-js@<3.3 is no longer maintained and not recommended for usage due to the number of issues. Because of
the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
npm ERR! code 1
npm ERR! path D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-sass
npm ERR! command failed
npm ERR! command C:\WINDOWS\system32\cmd.exe /d /s /c node scripts/build.js
npm ERR! Building: C:\Program Files\nodejs\node.exe D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-gyp\bin\node-gyp.js rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp verb cli [
npm ERR! gyp verb cli 'C:\Program Files\nodejs\node.exe',
npm ERR! gyp verb cli 'D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-gyp\bin\node-gyp.js',
npm ERR! gyp verb cli 'rebuild',
npm ERR! gyp verb cli '--verbose',
npm ERR! gyp verb cli '--libsass_ext=',
npm ERR! gyp verb cli '--libsass_cflags=',
npm ERR! gyp verb cli '--libsass_ldflags=',
npm ERR! gyp verb cli '--libsass_library='
npm ERR! gyp verb cli ]
npm ERR! gyp info using [email protected]
npm ERR! gyp info using [email protected] | win32 | x64
npm ERR! gyp verb command rebuild []
npm ERR! gyp verb command clean []
npm ERR! gyp verb clean removing "build" directory
npm ERR! gyp verb command configure []
npm ERR! gyp verb check python checking for Python executable "C:\Users\ASUS.windows-build-tools\python27\python.exe" in the PATH
npm ERR! gyp verb which
succeeded C:\Users\ASUS.windows-build-tools\python27\python.exe C:\Users\ASUS.windows-build-tools\python27\python.exe
npm ERR! gyp verb check python version C:\Users\ASUS\.windows-build-tools\python27\python.exe -c "import sys; print "2.7.15 npm ERR! gyp verb check python version .%s.%s" % sys.version_info[:3];"
returned: %j
npm ERR! gyp verb get node dir no --target version specified, falling back to host node version: 16.8.0
npm ERR! gyp verb command install [ '16.8.0' ]
npm ERR! gyp verb install input version string "16.8.0"
npm ERR! gyp verb install installing version: 16.8.0
npm ERR! gyp verb install --ensure was passed, so won't reinstall if already installed
npm ERR! gyp verb install version is already installed, need to check "installVersion"
npm ERR! gyp verb got "installVersion" 9
npm ERR! gyp verb needs "installVersion" 9
npm ERR! gyp verb install version is good
npm ERR! gyp verb get node dir target node version installed: 16.8.0
npm ERR! gyp verb build dir attempting to create "build" dir: D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-sass\build
npm ERR! gyp verb build dir "build" dir needed to be created? D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-sass\build
npm ERR! gyp verb find vs2017 Found installation at: C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools
npm ERR! gyp verb find vs2017 - Found Microsoft.VisualStudio.Component.VC.Tools.x86.x64
npm ERR! gyp verb find vs2017 - Found Microsoft.VisualStudio.Component.Windows10SDK.19041
npm ERR! gyp verb find vs2017 - Found Microsoft.VisualStudio.VC.MSBuild.Base
npm ERR! gyp verb find vs2017 - Using this installation with Windows 10 SDK
npm ERR! gyp verb find vs2017 using installation: C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools
npm ERR! gyp verb build/config.gypi creating config file
npm ERR! gyp verb build/config.gypi writing out config file: D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-sass\build\config.gypi
npm ERR! (node:6676) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
npm ERR! (Use node --trace-deprecation ...
to show where the warning was created)
npm ERR! gyp verb config.gypi checking for gypi file: D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-sass\config.gypi
npm ERR! gyp verb common.gypi checking for gypi file: D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-sass\common.gypi
npm ERR! gyp verb gyp gyp format was not specified; forcing "msvs"
npm ERR! gyp info spawn C:\Users\ASUS.windows-build-tools\python27\python.exe
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args 'D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-gyp\gyp\gyp_main.py',
npm ERR! gyp info spawn args 'binding.gyp',
npm ERR! gyp info spawn args '-f',
npm ERR! gyp info spawn args 'msvs',
npm ERR! gyp info spawn args '-G',
npm ERR! gyp info spawn args 'msvs_version=2015',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args 'D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-sass\build\config.gypi',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args 'D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-gyp\addon.gypi',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args 'C:\Users\ASUS\.node-gyp\16.8.0\include\node\common.gypi',
npm ERR! gyp info spawn args '-Dlibrary=shared_library',
npm ERR! gyp info spawn args '-Dvisibility=default',
npm ERR! gyp info spawn args '-Dnode_root_dir=C:\Users\ASUS\.node-gyp\16.8.0',
npm ERR! gyp info spawn args '-Dnode_gyp_dir=D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-gyp',
npm ERR! gyp info spawn args '-Dnode_lib_file=C:\Users\ASUS\.node-gyp\16.8.0\<(target_arch)\node.lib',
npm ERR! gyp info spawn args '-Dmodule_root_dir=D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-sass',
npm ERR! gyp info spawn args '-Dnode_engine=v8',
npm ERR! gyp info spawn args '--depth=.',
npm ERR! gyp info spawn args '--no-parallel',
npm ERR! gyp info spawn args '--generator-output',
npm ERR! gyp info spawn args 'D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-sass\build',
npm ERR! gyp info spawn args '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! gyp verb command build []
npm ERR! gyp verb build type Release
npm ERR! gyp verb architecture x64
npm ERR! gyp verb node dev dir C:\Users\ASUS.node-gyp\16.8.0
npm ERR! gyp verb found first Solution file build/binding.sln
npm ERR! gyp verb using MSBuild: C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\15.0\Bin\MSBuild.exe
npm ERR! gyp info spawn C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\15.0\Bin\MSBuild.exe
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args 'build/binding.sln',
npm ERR! gyp info spawn args '/nologo',
npm ERR! gyp info spawn args '/p:Configuration=Release;Platform=x64'
npm ERR! gyp info spawn args ]
npm ERR! gyp ERR! UNCAUGHT EXCEPTION
npm ERR! gyp ERR! stack Error: spawn C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\15.0\Bin\MSBuild.exe ENOENT
npm ERR! gyp ERR! stack at Process.ChildProcess._handle.onexit (node:internal/child_process:282:19)
npm ERR! gyp ERR! stack at onErrorNT (node:internal/child_process:477:16)
npm ERR! gyp ERR! stack at processTicksAndRejections (node:internal/process/task_queues:83:21)
npm ERR! gyp ERR! System Windows_NT 10.0.19043
npm ERR! gyp ERR! command "C:\Program Files\nodejs\node.exe" "D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-gyp\bin\node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
npm ERR! gyp ERR! cwd D:\Self-Guided\HTML-CSS\sass-fundamentals\node_modules\node-sass-middleware\node_modules\node-sass
npm ERR! gyp ERR! node -v v16.8.0
npm ERR! gyp ERR! node-gyp -v v3.8.0
npm ERR! gyp ERR! This is a bug in node-gyp
.
npm ERR! gyp ERR! Try to update node-gyp and file an Issue if it does not help:
npm ERR! gyp ERR! https://github.com/nodejs/node-gyp/issues
npm ERR! Build failed with error code: 7
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\ASUS\AppData\Local\npm-cache_logs\2021-08-28T12_05_00_436Z-debug.log
node-sass seems to be available in global scope as i check its info with PowerShell Admin privilege:
Branch | Build failing π¨ |
---|---|
Dependency |
greenkeeper-lockfile
|
Current Version | 1.14.0 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
greenkeeper-lockfile is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
The new version differs by 26 commits.
d675ee5
fix: run semantic release correctly
0ba723e
docs: add Drone.io support
a3b997e
fix: add gitUrl to config
0ec78cd
fix(style): run standard
6f47b75
feat: Add Drone.io support
f88d950
support different jenkins plugin branch name formats
d150d65
Get greenkeeper-lockfile working for Jenkins pipelines.
2c33fa9
feat: reduce required travis builds
29d33d0
chore(package): update lockfile
b985097
chore(package): update sinon to version 5.0.0
64ae163
Fix TeamCity typos
5042c03
bitrise now sets BITRISE_IO
28b81a8
Adds fallback when gk-origin remote exists
ab50403
docs: add teamcity docs
6a1068a
feat: add team city support
There are 26 commits in total.
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
I'm trying to follow along for the exercises on front end masters, but the ./run /run or run command doesn't get recognised and gives me this error:
'run' is not recognized as an internal or external command,
operable program or batch file.
I don't know how to fix this, or what other command I can use. (I have node.js installed and up to date)
Branch | Build failing π¨ |
---|---|
Dependency | commander |
Current Version | 2.15.1 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
commander is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
The new version differs by 17 commits.
4cc348b
Merge pull request #822 from abetomo/version_bump_2.16.0
8db14db
version bump 2.16.0
1f9354f
Remove Makefile and test/run
(#821)
3f4f5ca
Make 'npm test' run on Windows (#820)
3b8e519
Merge pull request #807 from styfle/patch-1
77ffd4f
Merge pull request #814 from DanielRuf/chore/cache-node-modules
6889693
chore: cache node_modules
ff2f618
Merge pull request #813 from DanielRuf/chore/remove-nodejs-4-add-nodejs-10
d5c1d7d
chore: remove Node.js 4 (EOL), add Node.js 10
c05ed98
Merge pull request #812 from yausername/fixReadme
55ff22f
fixed typo in readme
2415089
Add badge to display install size
89edef0
Fix types (#804)
001d560
Update eslint to resolve vulnerabilities in lodash
988d09b
Merge pull request #791 from yausername/master
There are 17 commits in total.
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
Hey Mike, first off, I wanted to say that your courses are top notch! Keep up the great work!
I wanted to report what I think is a bug at this line:
testTheme('theme-2', '#660099', '#003322', '#332200', '#113300'); // last three values darkened by 20%
Should be this:
testTheme('theme-2', '#660099', '#006644', '#664400', '#226600'); // last three values darkened by 10%
The above line is testing the resulting values for this mixin call site:
.theme-2 {
@include theme(#609, $darkenpct: 10%);
}
In the Frontend Masters video Challenge 6: Solution at the 9:34 mark, you begin to demonstrate the solution for darkening non-primary buttons. You give this as the final solution:
@mixin theme($primary-color, $rotate: 120deg, $darkenpct: 20%) {
$other-color: adjust-hue($primary-color, $rotate);
$other2-color: adjust-hue($primary-color, 180deg);
$secondary-color: adjust-hue($primary-color, -$rotate);
.btn-primary {
@include btn-base($primary-color, 0);
}
.btn-secondary {
@include btn-base($secondary-color);
}
.btn-other {
@include btn-base($other-color);
}
.btn-other2 {
@include btn-base($other2-color);
}
}
@mixin btn-base($bg, $darken_pct: 20%) {
background-color: darken($bg, $darken_pct);
border-color: darken($bg, 20%);
&:hover {
background-color: lighten(saturate($bg, 20%), 10%);
}
}
However, this skips passing along $darkenpct
to the btn-base mixin. This works for all but theme-2 since the defaults for that parameter are both the same.
.btn-secondary {
@include btn-base($secondary-color); // missing $darkenpct
}
.btn-other {
@include btn-base($other-color); // missing $darkenpct
}
.btn-other2 {
@include btn-base($other2-color); // missing $darkenpct
}
These calls should be:
.btn-secondary {
@include btn-base($secondary-color, $darkenpct);
}
.btn-other {
@include btn-base($other-color, $darkenpct);
}
.btn-other2 {
@include btn-base($other2-color, $darkenpct);
}
Which would feed the theme-2 10% value into the btn-base mixin.
At the 11:30 minute mark in the video you corrected the ordering of test color values, but to do so, you used the running app's colors, among which were the aforementioned incorrectly darkened hex values for non-primary theme-2 buttons.
Thanks for teaching this great course - I caught it on frontendmasters
I had node an installation of nodeJS from the pre io.js days that failed, so I upgraded to 5.0 (which is the default that comes with homebrew) which gave me the following error.
"SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode"
Next I installed 6.11 and it worked fine. So, just a recommendation that somewhere in the docs you note the min version.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. πππ
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google β€οΈ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.