Comments (2)
I've noticed that issue as well. I think the is_integral
assertion also fails for boost::multiprecision.
Edit: I see you're asking about IntermediateType, not BaseType. Yes, then the is_signed
check is all that matters. My comment is basically #8.
I've tried to think of better alternatives, but there's really no good way to verify that a type acts like an integer. I don't think even C++20's concepts allow you to test that e.g. T{0} / 2 == T{0}
(a property usually true for integers). In other words, C++ has no static "duck-typing" checks.
There may be no option than removing those checks, adding proper documentation and hoping people only use integer-like types. If you (or anyone) has other alternatives, I'm all ears.
And I'm glad to hear you find this library useful! The trigonometry stuff might be improvable in accuracy or performance, but that requires a level of knowledge of math I don't posses :)
from fpm.
As a side note, this isn't a big deal/high priority for me at all as I just need to comment out the relevant static_assert (and very carefully test). Unfortunately this does prevent me from using this library directly as a git submodule, but that's not a significant concern at all.
On a different note, thank you very very much for making this library. It's much easier to use than CNL as well has the trig functionality I needed, plus the various documentation with library comparisons incl. regarding performance made me very comfortable starting to use this library. This is overall saving me a ton of time in making a cross-platform deterministic game with fixed points under the hood. Ty again ^_^
from fpm.
Related Issues (20)
- Conversion of max() and lowest() to float HOT 6
- Question about having to resort to floats for initialization. HOT 1
- Provide a way to serialize fpm::fixed HOT 2
- How to convert from fixed to float or int? HOT 1
- Avoid using floating point arithmetic to compute static_cast<double>(fpm::fixed_16_16) HOT 6
- Unable to compile when minwindef.h is (implicitly) included before fixed.hpp HOT 2
- Support for Shift Operators HOT 5
- std::numeric_limits<>::has_denorm shall be of type float_denorm_style, not bool
- Please allow to use the external libfixmath HOT 3
- Feature Proposal: optionally disable rounding HOT 3
- Support fraction-only unsigned numbers
- Cannot result in a constant expression errors HOT 1
- Is there a way to initialize a fpm value from the string expression of a float number? HOT 3
- std::numeric_limits<fp>::min() vs. lowest() HOT 2
- Use types larger than 32bit HOT 5
- Include a link in your docs to this GitHub HOT 1
- [feature request] include a sin() that accept degrees instead of radians HOT 3
- Docs bug? Signed vs Unsigned integer types HOT 1
- Docs: mention rounding mode(s)?
- Is Division of two fixed point numbers implemented? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fpm.