`remove_host_restrictions` functionality no longer in the public interface about pytest-socket

[miketheman]

Hi @chadwhawkins !
Thanks for the kind words.

With 0.5.0 a bit of restructuring went on, and the original approach of an autouse fixture was replaced by a test-specific setup and teardown step that should restore the original behaviors post-test.

I'm curious what led to the creation of your custom fixture - is it possible that was a workaround due to the autouse fixture misbehaving and its removal should change the need for the custom fixture?

It should be the case that if you pass the plugin's socket_enabled fixture to a test, that should enable the network requests as you wish?

[chadwhawkins]

@miketheman thanks for the reply!

I'm not sure what lead to the creation of the custom fixture as that predates my involvement in the code. Before creating this issue I tried to get socket_enabled to work with no luck. My test setup function looked like this:

def pytest_runtest_setup():
    socket_allow_hosts(allowed=["127.0.0.1", MOTO_RESOURCE_ADDRESS])

However, with a bit more investigation it looks like I need to explicitly disable everything before allowing select hosts, e.g.:

def pytest_runtest_setup():
    disable_socket()
    socket_allow_hosts(allowed=["127.0.0.1", MOTO_RESOURCE_ADDRESS])

I was assuming that allowing only specific hosts implied that all others would be disabled. Just wanted to confirm that's the intended pattern. Thanks!

[miketheman]

@chadwhawkins glad it's working out!
I usually prefer the command-line options pytest ... --disable-socket --socket-allow-hosts="127.0.0.1,..." as a way to not have to use a custom pytest_runtest_setup(), but see that you're using a constant for the moto address, so this approach ought to work in a similar fashion.

Closing this one out!