ability to specify different exception instead of custom `SocketBlockedError` about pytest-socket

[miketheman]

Hey @fopinappb ! Thanks for reporting - this is an interesting use case. Do you think that having SocketBlockedError inherit from ConnectionRefusedError instead of RuntimeError would work here?

The original choice of RuntimeError was to raise the issue to the visibility of the operator that they had expressed a test condition without explicitly allowing it.

I was looking for ConnectionRefusedError in tldextract and couldn't find it - could you share where you're seeing that exception raised?

[fopinappb]

hey @miketheman I've been monkeypatching socket before I found this package (which I prefer now, for main tenability).
I also used a custom RuntimeError at first to easily spot the "unexpected internet usage" but then there were all these packages that used requests or urllib3 in background and handled requests exceptions but not the rest.

And RuntimeError are not supposed to be handled so requests/urllib3 do not indeed..

Switching to ConnectionRefusedError (as an official exception thrown by socket.socket) did sort it out, but I haven't checked exactly where...

For tldextract specifically I believe it's here https://github.com/john-kurkowski/tldextract/blob/0b876fa863bc54fa86c2a4d8b4f58391873e2281/tldextract/suffix_list.py#L33-L34

A RuntimeError won't be a requests exception and won't land there.

Custom subclass of ConnectionRefusedError should work. Can't be sure, but I guess it will land here in requests https://github.com/psf/requests/blob/1466ad713cf84738cd28f1224a7ab4a19e50e361/requests/adapters.py#L497-L498

so any socket error will be handled gracefully

[github-actions]

This issue is stale because it has been open for 90 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 30 days since being marked as stale.

[fopinappb]

not a good enough point? :)