mikeyamadeo / catan-node-server Goto Github PK

• does not update the color picker once you open it
• also, when you rejoin with another color, other players still see you in your previous color in the players panel in the bottom left

We should check for not 200 statuses in serverProxy and display an error

• Sometimes hangs on next player, most likely after discard
• when all 4 players discard gets stuck in discard phase

Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
at client.communication.LogComponent.draw(LogComponent.java:92)
at client.communication.LogComponent.getPreferredHeight(LogComponent.java:65)
at client.communication.LogComponent.updateSize(LogComponent.java:55)
at client.communication.LogComponent.setEntries(LogComponent.java:49)
at client.communication.ChatView.setEntries(ChatView.java:79)
at client.communication.ChatController.initFromModel(ChatController.java:61)
at client.communication.ChatController.update(ChatController.java:68)
at java.util.Observable.notifyObservers(Observable.java:159)
at client.model.Populator.populateModel(Populator.java:83)
at client.communication.ChatController.sendMessage(ChatController.java:41)
at client.communication.ChatView.sendMessage(ChatView.java:88)
at client.communication.ChatView.access$1(ChatView.java:85)

Sometimes after buying a dev card, I see it correctly on the next turn. Sometimes, on the next turn the byuDevCard icon is still enabled, but the devCards icon not. If you buy it again, it's available correctly next turn.

Join the game with 4 players. When the 4th player joins, the map shows up in his game and it says "waiting for other players", but for 3 other players the map never shows up and the game never starts.

There is workaround for now: for the player whose turn it is, stop the client and restart it. It advances to starting a game

• Does not increase the army size
• Does not make anyone discard (not sure that it should)

Join the game with one color, turn off the client, re-join with another color. The first color still shows as player's color

On initial round, the ordering of players should be 0,1,2,3,3,2,1,0. We have 0,1,2,3,0,1,2,3.

First, the ports' directions were not set. For now, I set all ports to NW just to make it not throw an error (ines 67, 70 games.controller.helper). I am not sure on which edges they should be.

Second, I am no expert on map, but the port locations look a little weird to me. This is the randomized map:

When the game starts, the first player gets a trade offer. That probably happens because we set tradeOffer to {offer: } in the JSON, and somehow serializer populates the fields with some bogus data.

Once the game has 4 players, it shows it as full and doesn't let you join even if you're one of these players

We are enforcing not building roads next to each other in the server, but not in the client. I am not sure which one is correct, but we should either enforce it in client, or not enforce it in server, cause it's causing an error

• never goes away, you can reuse it
• not sure about other functionality

The client throws an error about the game cookie on join game.
Error output:
Exception in thread "AWT-EventQueue-0" java.lang.NumberFormatException: For input string: ""
...
at client.network.ServerProxy.doPost(ServerProxy.java:134)
at client.network.ServerProxy.joinGame(ServerProxy.java:340)
at client.join.JoinGameController.joinGame(JoinGameController.java:232)
...

Right now, "Add a computer player" button in the waiting view makes the client freeze. It should be either disabled, since we don't have AI's, or deleted, or should do nothing.

Still could not advance turn without restarting after initial rounds (finishTurn button doesn't work)