GithubHelp home page GithubHelp logo

react-workshop's People

Contributors

mikeyamadeo avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar

react-workshop's Issues

SimplePokemonForm reducer.js mutates state

switch (type) { case POKEMON_SUBMITTED: const { newPokemon } = payload return state.concat(newPokemon) default: return state }

The state is concatenated, where it should be something like return [...state, newPokemon]

Take the analytics keys out of webpack.config.js

I don't think that the google analytics and errorception stuff should be in the webpack.config.js. But even if you want that in there, I think the ancestor cloud keys should be taken out. But if you're going to leave the other stuff in there then there needs to be some way for other people to put their own keys in.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.