react-workshop's People
react-workshop's Issues
WildPokemon doesn't kill its interval when the component is destroyed
It will continue to fetch pokemon and updating the state even after moving away.
SimplePokemonForm reducer.js mutates state
switch (type) { case POKEMON_SUBMITTED: const { newPokemon } = payload return state.concat(newPokemon) default: return state }
The state is concatenated, where it should be something like return [...state, newPokemon]
Take the analytics keys out of webpack.config.js
I don't think that the google analytics and errorception stuff should be in the webpack.config.js. But even if you want that in there, I think the ancestor cloud keys should be taken out. But if you're going to leave the other stuff in there then there needs to be some way for other people to put their own keys in.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.