GithubHelp home page GithubHelp logo

Comments (13)

Milad-Akarie avatar Milad-Akarie commented on July 19, 2024 1

@long1eu yes, fyi resolver. redirect is meant to be used for temp-redirects, I think it's better if you use router.push or router.replace instead, also you should always call resolver.next, in your case it should always be called with resolver.next(false)

from auto_route_library.

Milad-Akarie avatar Milad-Akarie commented on July 19, 2024

@long1eu if you're not navigating by path then inside BookDetailsPage have a constructor param named id and annotate it with @PathParam() so it's automatically parsed for you

from auto_route_library.

long1eu avatar long1eu commented on July 19, 2024

Indeed I have something like this:

  const BookDetailsPage({@PathParam('id') required this.bookId, super.key});

  final String bookId;

my issue here is that the parsing result in this case is :id.

from auto_route_library.

Milad-Akarie avatar Milad-Akarie commented on July 19, 2024

@long1eu how do you navigate to this page?

from auto_route_library.

long1eu avatar long1eu commented on July 19, 2024

It's the initial page.

from auto_route_library.

Milad-Akarie avatar Milad-Akarie commented on July 19, 2024

where are you supposed to get value of 'id' from? deeplink?

from auto_route_library.

long1eu avatar long1eu commented on July 19, 2024

I have it inside AppRouter for List<AutoRoute> get routes. I also have a AutoRouteGuard that makes sure the value is selected.

from auto_route_library.

Milad-Akarie avatar Milad-Akarie commented on July 19, 2024

can you share the code inside AutoRouteGuard?

from auto_route_library.

long1eu avatar long1eu commented on July 19, 2024
class BookSelectedGuard implements AutoRouteGuard {
  BookSelectedGuard(this.store);

  final Store<AppState> store;

  @override
  void onNavigation(NavigationResolver resolver, StackRouter router) {
    final String? bookId = store.state.bookId;
    if (bookId != null) {
      resolver.redirect(BookDetailsPage(bookId: bookId));
    } else {
      resolver.redirect(SelectBookRoute(onResult: resolver.next));
    }
  }
}

from auto_route_library.

Milad-Akarie avatar Milad-Akarie commented on July 19, 2024

this BookDetailsPage should be BookDetailsRoute right?
in the below line you are resuming the initial destination with id=null when calling resolver.next;
resolver.redirect(SelectBookRoute(onResult: resolver.next));
you need to always abort with resolver.next(false); inside on result obtain the book id then re-push BookDetailsRoute with the it

from auto_route_library.

long1eu avatar long1eu commented on July 19, 2024

Something like this?

class BookSelectedGuard implements AutoRouteGuard {
  BookSelectedGuard(this.store);

  final Store<AppState> store;

  @override
  void onNavigation(NavigationResolver resolver, StackRouter router) {
    final String? bookId = store.state.books.selectedBookId;
    if (bookId != null) {
      resolver.redirect(BookDetailsRoute(bookId: bookId));
    } else {
      resolver.redirect(
        SelectBookRoute(
          onResult: (String? bookId) {
            resolver.next(false);
            if (bookId != null) {
              resolver.redirect(BookDetailsRoute(bookId: bookId));
            }
          },
        ),
      );
    }
  }
}

from auto_route_library.

long1eu avatar long1eu commented on July 19, 2024

I've send you an email at [email protected]

from auto_route_library.

Milad-Akarie avatar Milad-Akarie commented on July 19, 2024

@long1eu resend on [email protected] please

from auto_route_library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.