GithubHelp home page GithubHelp logo

Comments (9)

JonasJW avatar JonasJW commented on July 19, 2024 1

@Milad-Akarie that's perfect! Thank you very much!

Just letting you know, in the docs it says "This of course requires includePrefixMatches to be true in the root config (default is true)", while the default value is actually !kIsWeb.

from auto_route_library.

Milad-Akarie avatar Milad-Akarie commented on July 19, 2024

@JonasJW where do you expect/home/child to pop to?

from auto_route_library.

JonasJW avatar JonasJW commented on July 19, 2024

@Milad-Akarie I would expect it to pop to /home as the ChildRoute is a child of the HomeRoute. This is how GoRouter handles it and routers of other frameworks.

Btw, I very much appreciate your work! AutoRoute is a great package and I would really like to use it in my app, I just have a few minor issues like this one but overall it's already much easier to use as GoRouter.

from auto_route_library.

Milad-Akarie avatar Milad-Akarie commented on July 19, 2024

@JonasJW does HomeRoute have an AutoRouter widget inside of it? your setup doesn't make sense

from auto_route_library.

JonasJW avatar JonasJW commented on July 19, 2024

@Milad-Akarie no it does not. Why doesn't it make sense? This is just a random example but it can be applied to many use cases, such as having a UserListPage and opening a specific UserProfile as a child route. I don't see why having another AutoRouter inside the UserListPage would be necessary when it would work just as well with the root AutoRouter (except the described issue)

from auto_route_library.

Milad-Akarie avatar Milad-Akarie commented on July 19, 2024

You need an AutoRouter widget to render child routes

from auto_route_library.

JonasJW avatar JonasJW commented on July 19, 2024

@Milad-Akarie Thanks for clarifying, I must have miss understood this.

However, the issue still persists. I don't want to use nested routers by having an AutoRouter on my HomePage. I want to use the same route for the ChildRoute and HomeRoute.

Am I correct that the routes should then look like this:

AutoRoute(
  path: "/home",
  page: HomeRoute.page,
  initial: true,
),
AutoRoute(
  path: "/home/child",
  page: ChildRoute.page,
  initial: false,
),

If I do this and open the app at /home/child/ the app starts at the HomePage. I would expect it to show the ChildPage and include a back button that pops to /home, i.e. the HomePage.

from auto_route_library.

Milad-Akarie avatar Milad-Akarie commented on July 19, 2024

@JonasJW with the current setup you only have to set includePrefixMatches to true inside router.config()

from auto_route_library.

Milad-Akarie avatar Milad-Akarie commented on July 19, 2024

Ya must've forgotten to change that

from auto_route_library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.