mileswu / jetsubstructuretools Goto Github PK

Hi,

Thanks a lot for implementing this tool! I notice there might be some kinematics cuts missing:

1. for track-jets, we want to require number of constituents to be at least 2. This should be nearly 100% efficiency, but it is better to have it since occasionally I see some track-jets in derivation with only one constituent. In addition, we require origin vertex of track-jet to be type xAOD::VxType::PriVtx (which I think should be always the case)
2. For muon, we also add |eta|<2.5 during our pre-recommendation study
3. In pre-recommendation study, we use the track-jet ghost associated to the un-groomed jet area (i.e. parent jet of trimmed fat-jet) to do the b-tagging, which can help improve b-tagging efficiency a little bit.

Thanks,
Qi Zeng

Best to add a prefix to it

See the diff here: https://gist.github.com/kratsg/bbbf60b973da700ae198c0dd73175f99

This is needed to get AnaToolHandle working with these tools in RootCore.

BosonTag: pT > 200 GeV and |eta| < 2.0
BoostedXbbTag: pT > 250 GeV and |eta| < 2.0

Maximum pT on both: 2 TeV

Empty line at end

Currently grabs from groomed input jet

separate integer decisions on whether it passes the mass, btagging, or substructure (or all)

This introduces a bad aux var

New configuration options are added for the ICHEP analysis. Check that the return value -5 ever gets returned now that there is no upper pT cut as we have calibrations above that level now.

See #18 for the related PR.

Hi Giordon, Miles,

sorry, I somehow never really know who is responsible for which steps of the tool etc.

Looking at BoostedXbbTag in line 403, shouldn’t it be fabs(jet->eta()) > 2.5 instead of abs(jet->eta()) > 2.5 or at least std::abs?

https://github.com/mileswu/JetSubstructureTools/blob/master/JetSubStructureUtils/Root/BoostedXbbTag.cxx#L403

https://github.com/mileswu/JetSubstructureTools/blob/master/JetSubStructureUtils/Root/BosonTag.cxx#L406-L409

  if(jet.pt()/1.e3 > 2000.0){
    printf("<%s>: Warning, jet has pT > 2 TeV!\r\nJet Pt: %0.6f GeV", APP_NAME, jet.pt()/1.e3);
    return -5;
  }