GithubHelp home page GithubHelp logo

mindctrl / alienship Goto Github PK

View Code? Open in Web Editor NEW
122.0 122.0 32.0 3.71 MB

Not actively maintained right now. Alien Ship is a starter theme for WordPress with Bootstrap integration.

Home Page: http://www.johnparris.com/alienship/

License: GNU General Public License v2.0

PHP 29.85% JavaScript 20.30% CSS 49.85%

alienship's People

Contributors

mindctrl avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

alienship's Issues

Post pagination links

The latest Bootstrap changed markup for pagination links. This affected the pagination within posts and needs to be updated.

Error when saving options

When I click save in the options panel, I get this error message:

Notice: Undefined index: alienship_featured_posts_tag in /mydomain/wp-content/themes/alienship/admin/options-framework.php on line 309

Warning: Cannot modify header information - headers already sent by (output started at /mydomain/wp-content/themes/alienship/admin/options-framework.php:309) in /mydomain/wp-includes/pluggable.php on line 866

Clean up comments.php

It's too messy for my taste. Clean it up.

Also, make use of comment_form() so the theme passes the Theme Check plugin.

Theme layout issues

Merge the labels for "Default" and "Content left. Sidebar right".

Change alienship_do_sidebar function to output footer widgets on full-width layouts.

Nav Bar Search 404

When searching for keywords using navbar results in 404, however same keyword when searched from sidebar search shows results

Theme Options

system: alienship 1.2.5, wordpress 4.0

Admin > Appearance > Theme Options
theme options are not available on wordpress 4.0

LESS files

Maybe you can provide the .LESS files for easy customization?

cannot find alienship_comment on alienship/functions.php

in comments.php file there is

/* Loop through and list the comments. Tell wp_list_comments()

  • to use alienship_comment() to format the comments.
    • If you want to overload this in a child theme then you can
  • define alienship_comment() and that will be used instead.
  • See alienship_comment() in alienship/functions.php for more.
    */

but i cannot find alienship_comment on alienship/functions.php

any help ? I try modified the comments css

Regards

Jetpack's Infinite Scroll support

It seems to be something easy enough to do following these steps: http://jetpack.me/support/infinite-scroll/

But I'm not having much success.

I've added this to my 'functions.php':

function twenty_twelve_infinite_scroll_init() { add_theme_support( 'infinite-scroll', array( 'container' => 'content' ) ); } add_action( 'after_setup_theme', 'twenty_twelve_infinite_scroll_init' );

Since Alienship does have 'content.php' this should be enough.

It loads but fails to add the next article then fallbacks to default pagination.

Maybe I'm missig something?

Typos in do_action() calls

There are several places in the latest master branch like

do_action (' alienship_content_before' );

Obviously, the ' and the space got mixed up.

Also, I'd recommend to remove the space between do_action and (.

Image brand in the navbar?

It's possible to upload an image as brand in the navbar?

It Should be useful to have a file upload form to make this simple...

Wrong span4-display with bigger width

Hi,

first off: Thanks for your theme, I really start to love it. It's the best bootstrap integration for Wordpress I've seen so far.

One question or issue (this is a test site):
This is how it should look like (3 columns á span4 side by side)
http://www.clickfire.de/cfire1.jpg

This is how it should look like:
http://www.clickfire.de/cfire2.jpg

The third column is being put underneath the second one. This happens when I increase the width of my browser window (Resolution 1920x1200). Is that a bug or is it normal? If it's normal, how can I pretend it?

Thanks
Andreas

Unclear Distinction Between get_template_part and do_action

It seems that in may places the theme is getting sections of the post via a get_template, but in other cases there's the much less familiar do_action in use. For me, this has slowed my build time considerably. For the short term, I think that more explanatory comments might help to speed things, but for the long term perhaps this distinction could be eliminated, at least wherever do_action is doing anything that could be reasonably accomplished with get_template_part.

Remove things unrelated to a theme

John, I really like the Alien Ship theme. Thanks a lot for your work on it!

Now, there are few things however, that I feel are annoying and don't even belong in a theme. Please take my following notes/list as a feedback, not as an offense :-) I'm well aware that you probably added most of these things because you needed/wanted them for your site, but in my opinion, they don't really need to be shipped with the theme.

  • Why is the small "WP" logo removed in the WP Admin Dashboard?
  • Is there really a need for the "Hide admin bar for all users?" option?
  • Why is the theme hiding update nags for non-admins? This is not something a theme should do.
  • Isn't the "Customize outgoing emails" better implemented in a separate plugin?
  • The same goes for the stuff related to changing/adjusting the login page, IMHO.

Favicon

:)

Maybe its not something really important but i think you forgot to include the favicon in header.php ....

something like

<link rel="Shortcut Icon" href="<?php echo get_stylesheet_directory_uri(); ?>/img/favicon.ico" type="image/x-icon" />

Go to Admin > Appearance > Theme Options

Hi there,

Im new with this theme, just learning boostrap. So, there is this line "Go to Admin > Appearance > Theme Options", but it is not showing up on my Admin page. Any idea?

Thank you,

p class lead is not honored

Hello!

I noticed that if I put a p class="lead" in a page contents, the font size is not honored due to these lines in style.css:

.entry-content, .entry-summary, .entry-content p, .entry-summary p {
    font-size: 17px;
    font-weight: 300;
    line-height: 1.667em;
}

The .lead class is defined in Bootstrap (http://getbootstrap.com/css/#type-body-copy).

Any ideas what would be the most elegant solution?

Modals Opens on load of page

The example code from Bootstrap below works when closed again but it opens by default you then have to press the open button again to close it.

<a class="btn" href="#myModal" data-toggle="modal">Launch demo modal</a>

&nbsp;
<div id="myModal" class="modal">
<div class="modal-header"><button class="close" type="button" data-dismiss="modal">×</button>
<h3 id="myModalLabel">Modal header</h3>
</div>
<div class="modal-body">

One fine body…

</div>
<div class="modal-footer"><button class="btn" data-dismiss="modal">Close</button>
<button class="btn btn-primary">Save changes</button></div>
</div>

Sliding animations aren't working

I'm having trouble creating carousels that aren't in a "featured post". For instance, I wanted to create a carousel on my home page, featuring a few different quotes. The content is switching fine, but there's no animation. I've checked the theme options to make sure bootstrap-transitions is enabled.

Is there a trick to getting animations to work?

Allow site visitors to disable responsive

I've had this request several times. Some people simply don't like responsive sites, and they want a way to disable the "mobile version". To clarify, this is not the "Theme Option" for responsive. This is a way for site visitors to override and view the site in "desktop mode".

I'm thinking a cookie would work for this feature, if it's decided that I go forward with it. This might be better suited as a plugin of some sort, and may not even be needed at all. I'm adding this issue here to get other viewpoints about the idea. Any input is most welcome.

alienship_change_admin_footer_content() should use existing arguments.

I suggest to remove alienship_change_admin_footer_content() or to at least change it to

/* Change footer text in admin dashboard */
function alienship_change_admin_footer_content( $footer_content ) {
  $alienship_admin_footer_text = 'Copyright &copy ' . date('Y') . ' ' . get_bloginfo('name') . '. All Rights Reserved.';
  return apply_filters( 'alienship_admin_footer_text', $alienship_admin_footer_text, $footer_content );
}
add_filter('admin_footer_text', 'alienship_change_admin_footer_content');

(Sorry for not creating a proper pull request. I hope that's ok.)

Remove support for < WP 3.4 in header image code

WP 3.4 introduced a better way to handle header images, and since 3.4.2 contained security updates, I don't want to support anything less than 3.4, so there's no need for the code that supports versions lower than 3.4.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.