mindkomm / theme-lib-mix Goto Github PK

Using mix() on a custom theme with laravel mix works great. But noticed it won't find the manifest if the $manifest_directory is in the child-theme.

In line 24 get_theme_file_pathfirst checks get_stylesheet_directory which returns the path to the parent theme before get_template_directory which would be the child-theme.

Nobody should be modifying or adding anything to the parent theme and should compile all assets to the child, or would you recommend leaving the mix-manifest.json outside the theme entirely and pass the $manifest_directory every time?

Hi,

it'd be useful to be able to globally set the path to something other than build so it doesn't need to be called every time I call mix

I will probably be using it a lot in my templates, but my files are in dist, so ideally I could configure this in my bootstrap functions

<script src="{{ mix('js/app.js') }}"></script>
<link rel="stylesheet" href="{{ mix('css/app.css')" />

also it would be good if you could namespace your class/methods to Mindkomm maybe?

anyway in the meantime I've done it like this (adding the namespace to your file):

public function add_to_twig( $twig ) {
    $twig->addFunction( new \Timber\Twig_Function( 'mix', [$this, 'mix']));
    return $twig;
}

public function mix($path) {
    return \Mindkomm\mix($path, ['manifest_directory' => 'dist']);
}

hope that's useful to somebody.