mindscapehq / grunt-raygun-deployment Goto Github PK

I was testing deployments tracking for my project using your grunt task, and it completed without any error. But on my deployments list panel on raygun dashboard, i get a blank view. i have attached the snapshot of my browser console

how can we send multiple deployments to raygun, as we are using more than one application?

First, congrats on launching the Deployments API. It's a great feature and we're excited to start using it.

We were also really happy to see a grunt plugin since we're big users of grunt. After reviewing the docs, a few things stuck out to me so I chose to fork. The changes I've made are pretty substantial. I don't think it makes sense to open a Pull Request, but I hope this general feedback helps others use one or the other to ultimately track deployments in raygun.

The first thing that stuck out to me is the configuring grunt with your application's API key and your personal external auth token. By making these options you define, you're implicitly encouraging developers to commit those keys and tokens into version control which is a bad practice. Please correct me if I'm misguided about the sensitivity of the key or token.

The second thing that didn't jive with how we continuously release is the Release.yml. There's nothing wrong with this approach. It's nice that markdown is supported. We'd rather rely on git tags that link back to releases in GitHub which are most likely a merged Pull Request. I image both plugins will evolve to allow more customizations around this part.

Lastly, I wanted to have some tests. Grunt plugins are hard to unit tests because of their dependence on grunt and most plugins just rely on it running and checking the output. If and when this plugin evolves, I wanted to have more assurance everything should work as expected.

Hope this feedback is helpful. I wanted to contribute what I thought made sense upstream. Keep putting out APIs for us to hack on