minetest-mods / character_creator Goto Github PK

Some big changes landed a few months ago, with support for a new minetest version -- that probably means it merits a new release?

Every time I'm reconnecting to a server when I set up my custom skin, the server crashes with:

2018-07-05 22:49:18: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'skinsdb' in callback on_joinplayer(): /home/black/.minetest/mods/character_creator/init.lua:163: attempt to index local 'indexes' (a nil value) 2018-07-05 22:49:18: ERROR[Main]: stack traceback: 2018-07-05 22:49:18: ERROR[Main]: /home/black/.minetest/mods/character_creator/init.lua:163: in function 'get_texture' 2018-07-05 22:49:18: ERROR[Main]: .../black/.minetest/mods/minetest-skinsdb/skin_meta_api.lua:74: in function 'apply_skin_to_player' 2018-07-05 22:49:18: ERROR[Main]: /home/black/.minetest/mods/minetest-skinsdb/init.lua:49: in function 'update_player_visuals' 2018-07-05 22:49:18: ERROR[Main]: .../black/.minetest/mods/minetest-3d_armor/3d_armor/api.lua:307: in function 'set_player_armor' 2018-07-05 22:49:18: ERROR[Main]: /home/black/.minetest/mods/minetest-skinsdb/api.lua:36: in function 'update_player_skin' 2018-07-05 22:49:18: ERROR[Main]: /home/black/.minetest/mods/minetest-skinsdb/init.lua:57: in function </home/black/.minetest/mods/minetest-skinsdb/init.lua:56> 2018-07-05 22:49:18: ERROR[Main]: /usr/share/minetest/builtin/game/register.lua:420: in function </usr/share/minetest/builtin/game/register.lua:400>
After that I can restart the server and connect, but if I leave and reconnect on a working server, the same stuff happens.

Hi!
I get the following error with the latest git checkout of the mod:

2017-05-14 14:44:08: ERROR[Main]: ServerError: Lua: Runtime error from mod 'character_creator' in callback on_joinplayer(): /usr/share/games/minetest/mods/character_creator/init.lua:102: attempt to call method 'get_attribute' (a nil value) 2017-05-14 14:44:08: ERROR[Main]: stack traceback: 2017-05-14 14:44:08: ERROR[Main]: /usr/share/games/minetest/mods/character_creator/init.lua:102: in function 'load_skin' 2017-05-14 14:44:08: ERROR[Main]: /usr/share/games/minetest/mods/character_creator/init.lua:219: in function </usr/share/games/minetest/mods/character_creator/init.lua:218> 2017-05-14 14:44:08: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:412: in function </usr/share/games/minetest/builtin/game/register.lua:392>

Hi,

could you please tag releases so I can make packages for Debian?

Thanks!

Snark on #minetest

https://forum.minetest.net/viewtopic.php?f=47&t=20935

I want to add the supporting of sfinv to this. If skinsdb is available, don't need to add a tab to sfinv.

@pinkysnowman
Would you delete your character_creator repo if you aren't using it?
I deleted my one, yours became this repo's parent now...🤔

@sofar
Could you detach fork relationships?

On a (reasonably recent) 5.0.0 minetest (server & client) when I log out and log in again, the player has reverted to the default skin. If I start /character_creator again I see that the mod has remembered my settings, but not applied them. As soon as I click one button the correct skin is loaded.

Change this to this to actually avoid the race condition.
minetest.after(1, change_skin, player)

Hi, i just got an ServerError: Runtime error from mod 'character_creator' in callback environment_Step(): ...in/../games/minetest_game/mods/3d_armor/3d_armor/api.lua:158: bad argument #1 to 'gsub' (string expected, got nil) error - seems like 3d_armor got a breaking change for character_creator.