minitex / pdfreader-android Goto Github PK

We'll want to use the most up to date support libraries in any new development where possible.

See https://developer.android.com/jetpack

The png works, but really we should be using vector graphics where possible.

This might need to wait from NYPL, but there could be some good options at https://material.io/tools/icons

Want to use a system where we put most of the config in the main build.gradle and then just manage dependencies in each module's build.gradle.

This includes padding, the amount we're indenting, height, width, etc.

The README should provide documentation on how to add the library via Maven Central.

Despite being quite simple, if possible, we should prefer ConstraintLayout where possible.

As part of #11, we'll be publishing as edu.umn.minitex so our classes should use that namespace.

To allow others to build the app, we should be publishing the PDF module to Maven Central rather than NYPL's nexus repository.

In the TableOfContents adapter, we've had to use a const in a companion object to get the RecyclerView.ViewHolder to honor the integer value for leftIndent here:

        fun bindContents(content: TableOfContentsItemWrapper) {
            this.content = content
            view.reader_toc_element_title.text = content.title
            view.reader_toc_element_page_number.text = content.pageNumber.toString()

            val params = RelativeLayout.LayoutParams(
                ViewGroup.LayoutParams.WRAP_CONTENT,
                ViewGroup.LayoutParams.WRAP_CONTENT
            )

            val leftIndent = content.indent * INDENT_PIXELS

            params.setMargins(leftIndent, 0, 0, 0)

            view.layoutParams = params
        }

This should really be in a resource file of some sort, but attempts to put it into dimens yielded results that pushed anything with an indent off the screen.

val pixels = R.dimen.table_of_contents_element_indent_width as Int
val leftIndent = content.indent * pixels

pixels ends up being 2131099867 when I hit the breakpoint in the above code.

The rest of the dimensions were properly moved over in #5, but this still remains.

This will avoid a failure displaying data that might seem valid, but isn't.

Want to make sure we are explaining what the parts of the library are trying to accomplish.

We're not using bookmarks yet so we shouldn't include them in the library.