minj / foxtrick Goto Github PK

Original issue 32 created by spambot.de on 2008-12-16T03:00:21.000Z:

Error:
cfUserInfo is undefined
chrome://foxtrick/content/forum/forummovelinks.js Line 56

What steps will reproduce the problem?

1. Open a thread

What version of the product are you using? On what operating system?
*no supporter
*reduced skin

Original issue 42 created by deepbluedot on 2008-12-16T19:40:40.000Z:

What steps will reproduce the problem?

1. Any forum

What is the expected output? What do you see instead?

• No flag next to replied to user

What version of the product are you using? On what operating system?
0.4.0, Win Vista

Please provide any additional information below.
It would be nice to see flag next to replied user nick, just as we see it
next to user that posted the link

Original issue 33 created by larswortel on 2008-12-16T09:00:55.000Z:

What steps will reproduce the problem?

1. Log in to Hattrick.org

What is the expected output? What do you see instead?
I expect a growl notification saying 'Welcome larsw84'. Instead, nothing
happens. The console displays the following error:
FoxtrickAlert.js run: TypeError: doc is undefined

Using the latest 45f6b46 r158).

Original issue 5 created by larsts on 2008-05-25T21:54:37.000Z:

What steps will reproduce the problem?

1. Go to the challenges page (https://www.hattrick.org/goto.ashx?path=/common/challanges.asp%3F)

What is the expected output? What do you see instead?
Would be excellent to have information about the team (flag and division)
showed, similiary as for users in the conference. This would make it easier
to check further which team to accept.

Please provide any additional information below.

The only id available at the challenges page is the TeamID. Userflags on
alltid uses the UserID as the .gif name.
But weird_ed seems very open to creating a new set of flags (or links to
the existing set of flags) to accomodate this feature.
Maybe something like ?

DetteErMeg has had a dialog with weird_ed, but a detailed solution should
probably be discussed between foxtrick dev (kolmis) and alltid admin
(weird_ed) directly.
Thread on foxtrick forum: http://foxtrick.px.cz/forum/2_1761_0.html
Thread on alltid forums: http://alltid.org/forum/viewtopic.php?id=1083

Original issue 8 created by kolmis on 2008-07-10T18:49:48.000Z:

Implement Hattrick language guessing - if the value has not been set by the
user try to guess the language for ratings and other language dependent
things to work.

Doesn't have to be 100% correct, the main purpose is to minimize the
endlessly repeating questions "i can't see tha match ratings"

Original issue 41 created by m.eekels on 2008-12-16T19:18:29.000Z:

The Dutch translation files, corresponding with d39dfdd r167 of foxtrick.dtd and
8ce8825 r194 of foxtrick.properties.

Original issue 4 created by larsts on 2008-05-25T21:31:34.000Z:

What steps will reproduce the problem?

1. Check match report for matchid 164631299
   (https://www.hattrick.org/goto.ashx?path=/Common/matchdetails.aspx%3FmatchID%3D164631299)

What is the expected output? What do you see instead?
Pedrosa is mentioned at the end of the first half, should be colored black
as he is part of déchaînés.

What version of the product are you using? On what operating system?
Foxtrick 0.3.65, XP.

Please provide any additional information below.
Seems playing 5-5-0 (no forwards) makes the player name extraction fail to
extract the first player in the formation (Pedrosa).
This is probably true for all formations with no people in one of the 4
parts of the formation (keeper/defender/midfielder/forward).

Hattrick adds a - after the last player in the formation for this match,
this makes matchDetailPlayerColoring extract an empty string as the first
playername in the playersOfTeamB array. index has reached 11 before coming
to Pedrosa.

Could probably (?) be amended by parsing the string left to right (with
indexOf instead of lastIndexOf), or by adding a if(newPlayerName=="")
index--; "hack".

Original issue 45 created by wimvey on 2008-12-16T20:00:41.000Z:

Those features in the old design were very good.
Especially the player-ad to clipboard will be very useful when displaying
the skills as bars. When just copying the stats from the player's page, it
looks awful.

Original issue 44 created by dendertig on 2008-12-16T19:50:18.000Z:

It would be great to have the old way of displaying the attack vs defence
bars back. It gives a quick overview without needing to study the bars (or
ratings) in detail. That has become impossible with the new lay-out. Can
the old style come back there?

Original issue 39 created by p.osciak on 2008-12-16T18:47:59.000Z:

.

Original issue 31 created by spambot.de on 2008-12-15T23:34:02.000Z:

The Strings seams to fit, but the Encoding must be fixed.

Original issue 13 created by p.osciak on 2008-12-12T18:27:11.000Z:

.

Original issue 22 created by larswortel on 2008-12-13T12:38:51.000Z:

bummerlands work probably enables me to enhance the Leave Conf button, so
that you only have to hit the 'Save' button on the Forum Preferences page
after trying to leave a conference (now, you have to press 'Leave' yourself
first).

Original issue 47 created by larswortel on 2008-12-17T00:04:23.000Z:

Lazily copypasting HT-weirdeds post on the Foxtrick conf:

There is one "problem" with the new foxtrick which made my alltid extension
stop working as well. Maybe it's the same with PsicoTSI.

The stringbundle id is "string-bundle" , which is what the documentation
uses as an example. The problem is if two extensions uses the same name
("string-bundle"), then one of them won't get the correct bundle.

So Foxtrick should change that ID in the XUL file to for instance
"foxtrick-strings" or some such. And remember to change it to that when you
load the strings too ;)

Original issue 48 created by stephan.cardot on 2008-12-17T00:11:45.000Z:

French translation files

Original issue 35 created by spambot.de on 2008-12-16T11:19:30.000Z:

What steps will reproduce the problem?

1. Open a match, HatStats and bars are shown
2. click on the arrow (last game) - no stats, also if you swith back to the
   last first game.

On single games, it works fine.

Original issue 37 created by ljushaff on 2008-12-16T15:04:03.000Z:

Hi,

finished Srbian translation, I've changed the file names (only!!) so if
that was wrong please change them back to original ones. The rest is fine.

best,

Ljushaff

Original issue 6 created by kolmis on 2008-07-04T22:15:58.000Z:

This is a feature request.

I use transfer filters a lot, and keep them up to date. But for that I need
to right click, suppress the filter and make a new one.

I would love to see an update button beside each filter, which updates the
filter with current fields from the transfer search page.

request by
roselan

Original issue 25 created by p.osciak on 2008-12-14T14:18:07.000Z:

.

Original issue 46 created by tiziano.m on 2008-12-16T21:29:30.000Z:

Always returns a localization error string.

Original issue 17 created by p.osciak on 2008-12-12T18:42:12.000Z:

What steps will reproduce the problem?

1. Visit bookmark page
2. The jsconsole displays an error:
   "Error: commentObj.firstChild is null
   Source file: chrome://foxtrick/content/bookmarkadjust.js
   Line: 50"

Original issue 24 created by p.osciak on 2008-12-14T13:11:55.000Z:

.

Original issue 26 created by p.osciak on 2008-12-14T17:40:06.000Z:

.

Original issue 3 created by larsts on 2008-05-18T11:42:05.000Z:

What steps will reproduce the problem?

1. Check any match report (matchdetails.aspx)

What is the expected output? What do you see instead?
Player coloring (black/white), nothing is colored.

What version of the product are you using? On what operating system?
Firefox/2.0.0.14 / Win XP.

Please provide any additional information below.
Seems HT has changed the DOM a bit, the nodes containg the team lineups are
no longer 13 and 16, but 12 and 15.
Lines 3407+3408 in foxtrick.js needs to be updated, or the entire lineup
extraction needs to be rewritten to be more robust.

Reported on the forum here: http://foxtrick.px.cz/forum/1_1344_0.html

Original issue 20 created by tiziano.m on 2008-12-12T19:46:00.000Z:

Copied code from old foxtrick. Need the review of initialization to be
terminated.

Original issue 9 created by tiziano.m on 2008-07-29T08:20:57.000Z:

I've written down a few lines to make the bookmark color function work
again. I hope the developer will include it in the next update. I've also
posted it in the forum. Here there are the 3 functions to change:

[code]
function isBookmarksUrl(href) {
return href.search(/bookmarks.aspx/i) > -1;
}

function bookmarkColor(inputObj, regexp, spanObj, color) {
//Modified by Taised for aspx page: inputObj is the button with the img,
spanObj is the object with the comment
if (spanObj.firstChild.nodeValue.search(regexp) > -1) {
inputObj.src = "chrome://foxtrick/content/resources/notes/" + color +
".png";
spanObj.firstChild.nodeValue =
spanObj.firstChild.nodeValue.replace(regexp, "");
}
}

function bookmarksAdjustment(doc) {
//Modified by Taised
if (!isBookmarksUrl(doc.location.href)) return;

addStyleSheet(doc, "chrome://foxtrick/content/resources/css/bookmark_
comments.css");

var tableObj=doc.getElementById('ctl00_ctl00_CM_CI_repB');
tableObj=tableObj.childNodes[1];

for (var i=0; i<tableObj.rows.length; i++) {
//If there aren't 4 cells on the row is a separator row
if (tableObj.rows[i].cells.length==4) {
//if the first cell has 6 childs the row has comments
if (tableObj.rows[i].cells[0].childNodes.length>5) {
var spanObj=tableObj.rows[i].cells[0].childNodes[5];
var inputObj=tableObj.rows[i].cells[2].childNodes[1];
bookmarkColor(inputObj, /[aqua]/i, spanObj, "aqua");
bookmarkColor(inputObj, /[black]/i, spanObj, "black");
bookmarkColor(inputObj, /[blue]/i, spanObj, "blue");
bookmarkColor(inputObj, /[brown]/i, spanObj, "brown");
bookmarkColor(inputObj, /[darkpurple]/i, spanObj,
"darkpurple");
bookmarkColor(inputObj, /[green]/i, spanObj, "green");
bookmarkColor(inputObj, /[lightblue]/i, spanObj,
"lightblue");
bookmarkColor(inputObj, /[lightgreen]/i, spanObj,
"lightgreen");
bookmarkColor(inputObj, /[orange]/i, spanObj, "orange");
bookmarkColor(inputObj, /[pink]/i, spanObj, "pink");
bookmarkColor(inputObj, /[purple]/i, spanObj, "purple");
bookmarkColor(inputObj, /[red]/i, spanObj, "red");
bookmarkColor(inputObj, /[white]/i, spanObj, "white");
bookmarkColor(inputObj, /[yellow]/i, spanObj, "yellow");
}
}
}

}

[/code]

Original issue 18 created by p.osciak on 2008-12-12T19:23:58.000Z:

.

Original issue 36 created by jurosz on 2008-12-16T14:37:20.000Z:

Czech translation of strings for actual Foxtrick version.

Original issue 38 created by spambot.de on 2008-12-16T16:54:53.000Z:

Update German Language (rev. 188)

Maybe the languages should be included at chrome.manifest?

Original issue 7 created by danial.olsen on 2008-07-06T21:39:23.000Z:

What steps will reproduce the problem?

1. Match ID: 183994513

What is the expected output? What do you see instead?
Player Osmo Jokimies is wrong colour.

What version of the product are you using? On what operating system?
0.3.70 - Windows XP SP3

Please provide any additional information below.

Original issue 19 created by tiziano.m on 2008-12-12T19:43:16.000Z:

needed: language definitions for skills

Original issue 1 created by larsts on 2008-04-06T16:19:12.000Z:

What steps will reproduce the problem?

1. Check a derby match, example matchid 162909227
   (https://www.hattrick.org/goto.ashx?path=/Common/MatchDetails.aspx%3FmatchID%3D162909227%26amp%3BuseArchive%3DTrue)

What is the expected output? What do you see instead?
Should see player coloring, no coloring is added.

What version of the product are you using? On what operating system?
Foxtrick 0.3.64, FF 2.0.0.13, Windows XP.

Please provide any additional information below.

For derby matches, Hattrick now adds a link to the region the teams are in.
From the example: People from all over Oslo had joined up for the derby.

Extraction of the variables TeamA and TeamB in matchDetailPlayerColoring()
fails with the extra region nodes in the DOM.

Original issue 43 created by deepbluedot on 2008-12-16T19:48:37.000Z:

Having htstats include defense/midfield/attack as well as total would be
nice :)

Original issue 27 created by tiziano.m on 2008-12-15T09:43:38.000Z:

What steps will reproduce the problem?

1. enter the forum
2. console shows those errors:
   Errore: XPathResult is not defined
   File sorgente: chrome://foxtrick/content/forum/forumstaffmarker.js
   Riga: 36

Errore: cfUserInfo is undefined
File sorgente: chrome://foxtrick/content/forum/forummovelinks.js
Riga: 32

the forum staff names are not colored anymore

Original issue 50 created by larswortel on 2008-12-17T00:36:42.000Z:

Several users have reported problems with the Italian language version.
taised, since you're Italian I guess you should be the one to look into this :)

Comments include:
"
some problem due to traslation/localization:
i got
** Localization error **
on

• caption (mouse over team name)
• just over this edit message/ text box
• in the match page, the last block on the left (just after Supp
  orterStats) different % tagged as localz error"

and

"thank to all the team for the great job ...
someone can help cos' I've found in many pages localization error ,
expecially in the page where I have to post the team un the traditional way
and I can't post the left defender.
What means ... please"

Original issue 12 created by p.osciak on 2008-12-12T18:26:21.000Z:

adding direct team links to conference posts

Original issue 23 created by larswortel on 2008-12-13T12:40:45.000Z:

Modidy smates' code to our system:

1. wrapping it up in a standard module class (and adding a new
   YouthAcademyPlayer page to module.js)
2. replacing GM_getValue and GM_setValue with our FoxtrickPrefs.get* and
   set* functions, maybe a slightly different naming convention for those
   variables while you are at it (I'm thinking:
   "YouthPlayer.playerid.skillGK", etc...).
3. Moving strings in STR_* variables to localization file.
4. removing the listener and function calls on the bottom of the file.

Original issue 28 created by spambot.de on 2008-12-15T10:22:18.000Z:

What steps will reproduce the problem?

1. Open a match report.
2. "matches.js run: TypeError: doc.getElementById("mainBody").childNodes[3]
   is undefined" appears in the console.

What version of the product are you using? On what operating system?
2102725 r143

Attached a file with a fix of htlang.xml
(added German skill levels, found 1 single space at skill "brilliant " (en))

Original issue 14 created by p.osciak on 2008-12-12T18:29:28.000Z:

.

Original issue 2 created by larsts on 2008-04-06T17:02:21.000Z:

What steps will reproduce the problem?

1. Install skin
2. Apply/choose skin

What is the expected output? What do you see instead?
Expect to see skin applied, no change in appearance though.

What version of the product are you using? On what operating system?
Foxtrick 0.3.64, FF 2.0.0.13, Windows XP.

Please provide any additional information below.
With FF 2.0.0.10 the behavior of the jar protocol was changed.
(http://www.mozilla.org/security/announce/2007/mfsa2007-37.html)
The jar protocol would only work for files with content-type
application/java-archive or application/x-jar in the header.

After this, Foxtrick is not able to access the skin zips using the jar
protocol. (At least not without deactivating the new jar behavior with the
FF network.jar.open-unsafe-types setting.)

Kolmis proposed changing the install procedure to extract the zip file
instead of just saving it, and accordingly make changes in how foxtrick
accesses the skin files.
(http://foxtrick.px.cz/forum/1_1714_0.html)

Original issue 11 created by heinrichruoff on 2008-11-03T23:00:16.000Z:

There is a new transfer search & result page in HT introduced 03.11.2008,
that stopped foxtrick transfer tools from working.

Original issue 34 created by francisco.ory on 2008-12-16T11:12:56.000Z:

Translation into spanish for foxtrick.dtd and properties.
Anyting, don't hesitate to contact me.
Regards

Original issue 29 created by tiziano.m on 2008-12-15T15:02:25.000Z:

What steps will reproduce the problem?

1. goes to a match
2. enable the lineup setting in flash
3. the console shows this error:
   Errore: doc.getElementById("startlineup") is null
   File sorgente:
   chrome://foxtrick/content/shortcuts_and_tweaks/matchOrdersFlipSides.js
   Riga: 28

there should be a check to avoid it.

Original issue 30 created by el.fiera on 2008-12-15T22:21:55.000Z:

What steps will reproduce the problem?

1. Open a match report with Spanish Report

What is the expected output? What do you see instead?
The graphics don't appeared

What version of the product are you using? On what operating system?
2209569 r149

Please provide any additional information below.
In Spanish lang I'd Noticed that the source code of the page is:

    <td><a href="/Help/Rules/AppDenominations.aspx?lt=skill&ll=3#skill"

class="skill">pobre</a> (<i><font color="gray">bajo</font></i>)</td>
<td><a href="/Help/Rules/AppDenominations.aspx?lt=skill&amp;ll=4#skill"
class="skill">débil</a> (<i><font color="gray">alto</font></i>)</td>

In other languages the difference is that the sublevel isn't in gray color. For
example in English:

    <td><a href="/Help/Rules/AppDenominations.aspx?lt=skill&ll=3#skill"

class="skill">poor</a> (low)</td>
<td><a href="/Help/Rules/AppDenominations.aspx?lt=skill&amp;ll=4#skill"
class="skill">weak</a> (high)</td>

That's the reason why the Spanish language doesn't work

Original issue 49 created by konved on 2008-12-17T00:21:10.000Z:

Russian translation files

Original issue 15 created by p.osciak on 2008-12-12T18:33:55.000Z:

.

Original issue 21 created by p.osciak on 2008-12-12T19:49:21.000Z:

.

Original issue 10 created by helderfraga on 2008-09-24T17:57:38.000Z:

i think this is not working since i dont get any numbers near the player
skill names

Original issue 40 created by marcin.nowakowski on 2008-12-16T18:59:05.000Z:

It's rather an enhancement request than a bug report: the staff nicks are
colored even if the message is an 'as answer to' message by a staff member.
It would be more useful if the staff nick was highlighted only when the
message is written by a staff member. Optionally a different highlighting
scheme (much less visible, eg. only a thin frame) could be applied to the
'as answer to ... by staff' field.

Original issue 16 created by p.osciak on 2008-12-12T18:38:14.000Z:

.