minkphp / minkwunitdriver Goto Github PK

This driver is not tested (see #9 and #4). It is duplicating the code of https://github.com/weavora/wunit (which also looks unmaintained) which does not care at all about the composer era (see weavora/wunit#12)

I suggest marking this driver as deprecated (and unmaintained), acknowledging the fact that we haven't worked on it since years. If anyone is using the driver and wants to bring it uptodate, we can still make them a driver maintainer and undeprecate the driver (once properly tested and green.

/cc @minkphp/core-team @minkphp/wunit

Right now there are no unit tests or Travis CI integration, which makes it pretty hard to safely make changes to the driver code.

@patrickdreyer can you please add tests (I'm guessing this will be similar to ones, done in MinkGoutteDriver, where MinkBrowserKitDriver tests are executed).

Even though all the driver logic is actually inherited from MinkBrowserKitDriver, it could be interesting to run the driver testsuite on this repo as well. This could also allow detecting mistakes in WUnit itself (if they don't implement the HttpKernel/BrowserKit integration properly) as we know that MinkBrowserKitDriver works fine.

See https://github.com/minkphp/Mink/tree/master/driver-testsuite for the way to use this testsuite and https://github.com/minkphp/MinkBrowserKitDriver/tree/master/tests for the way BrowserKitDriver does to avoid relying on a webserver being running

@patrickdreyer currently, you are the only guy with maintainer access to this package on Packagist. given that you are not really active anymore on the driver, could you add me as a Packagist maintainer as well ?