Comments (3)
It seems like unwrapping ability.destroy()
from the run call works fine and all tests pass locally.
@Exelord would you be ok with removing the wrapping run call when destroying?
from discord:
is it expected that running in a runloop creates a huge amount of dependencies for autotracking?
run() runs everything in the runloop synchronously, so if you have things scheduled that will cause updates, yes
By contrast, if you schedule into say actions normally, that will schedule it to run in the next runloop (usually, especially during render)
from ember-can.
Hey! Thanks for debugging this. I'm not in context now, why we have the run loop there. From what I remember out tests suit checks things very well. If it works without it, it probably fine to test it first in real apps :)
from ember-can.
I've already started using #110 in our app and everything is working well.
from ember-can.
Related Issues (20)
- Cannot Mock Ember-can in tests to always return true HOT 2
- Cannot use `Ember-can` in Polymorphism HOT 1
- Path ember-can/services/can is not resolving HOT 1
- Dependencies outdated HOT 1
- Update doc for testing HOT 3
- Stuck at 1.1.1 HOT 7
- Explicitly passed ability and property name HOT 2
- alias and computed not working for can HOT 1
- Relying on unknownProperty breaks can helper HOT 5
- ability computed doesn't work with @glimmer/component
- Use native ES6 classes instead of EmberObject for Ability HOT 3
- No "exports" main defined in @babel/helper-compilation-targets/package.json
- Error when running tests: this version of ember-auto-import requires the app to have a dependency on webpack HOT 10
- TypeScript support HOT 2
- Release HOT 2
- `can` helper error HOT 3
- Errors when attempting to create a native class extending from Ability HOT 2
- Interested moving to a V2 addon ? HOT 1
- async abilities
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-can.