GithubHelp home page GithubHelp logo

Comments (3)

makepanic avatar makepanic commented on June 12, 2024

It seems like unwrapping ability.destroy() from the run call works fine and all tests pass locally.

@Exelord would you be ok with removing the wrapping run call when destroying?

from discord:

is it expected that running in a runloop creates a huge amount of dependencies for autotracking?

run() runs everything in the runloop synchronously, so if you have things scheduled that will cause updates, yes
By contrast, if you schedule into say actions normally, that will schedule it to run in the next runloop (usually, especially during render)

from ember-can.

Exelord avatar Exelord commented on June 12, 2024

Hey! Thanks for debugging this. I'm not in context now, why we have the run loop there. From what I remember out tests suit checks things very well. If it works without it, it probably fine to test it first in real apps :)

from ember-can.

makepanic avatar makepanic commented on June 12, 2024

I've already started using #110 in our app and everything is working well.

from ember-can.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.