Relying on unknownProperty breaks can helper about ember-can

[Exelord]

How about if we would use Ember.get(ability, key) :) Would that solve your issue?

[oakho]

Yes, using return get(ability, propertyName); would indeed fix my issue :) ! (Quite better than my initial solution).

I can open a PR, if you like !

[Exelord]

Hi,
Thank you for raising this up! That indeed could be a solution, however, I'm not sure If we want to support EmberObject further (open on others' voices) as it has been kind of deprecated.

Another solution for your case could be defining abilities in the constructor if you are able to get all the keys. I usually follow this path. So instead of relaying on unknownProperty you could do:

abilities.forEach((key) => {
  Object.defineProperty(this, key, { get() { return this.hasAbility(key) } })
})

Let me know If that would solve your issue :)

[oakho]

Hello @Exelord,

I agree with you that with the soft deprecation of EmberObject this might not be the best solution but then I think there might be some confusion for other users with the current state of ember-can.

Currently, the ability class still extends EmberObject itself so as a user I would expect to be able to rely on public APIs exposed by EmberObject without breakings.

From my point of view, ember-can should either get rid of EmberObject and release a major release with breaking changes (this may also resolve #92) or stay backward compatible with features supported by EmberObject.

What do you think ?

That said, I understand this is an open source project and you might not want to do that for a small edge case you didn't encounter.

Regarding your solution (thanks for it), it is in fact what I've done first, this works pretty well and I also think It's the go to solution to not rely on EmberObject. But, in our case, we also sometimes override the unknownProperty in our abilities' subclasses and that would involve a refactor that is out of scope of my initial work to get our app up to date and octane ready.

Anyway, I'm totally cool with keeping my can helper override until we can afford to spend some time to refactor our abilities with your solution :) !

[Exelord]

Ok, cool! I will accept it :)