The api-client-php from mittwald

api-client-php's People

Contributors

Stargazers

Watchers

api-client-php's Issues

Patching SoftwareVersions

In general patching software versions does work as described in the developer portal:

PATCH /v2/appinstallations/{appInstallationId} HTTP/1.1
Content-Type: application/json

{
  "systemSoftware": {
    "<insert system software id>": {
      "systemSoftwareVersion": "<insert system software version id>",
      "updatePolicy": "patchLevel"
    }
  }
}

However, in the client it is only possible to define the systemSoftwareVersion, but not systemSoftwareId:
/src/Generated/V2/Clients/App/PatchAppinstallation/PatchAppinstallationRequestBodySystemSoftwareItem.php

    private static array $schema = [
        'properties' => [
            'systemSoftwareVersion' => [
                'type' => 'string',
            ],
            'updatePolicy' => [
                '$ref' => '#/components/schemas/de.mittwald.v1.app.SystemSoftwareUpdatePolicy',
            ],
        ],
        'type' => 'object',
    ];

The schema for the request looks like this:

            'systemSoftware' => [
                'additionalProperties' => [
                    'properties' => [
                        'systemSoftwareVersion' => [
                            'type' => 'string',
                        ],
                        'updatePolicy' => [
                            '$ref' => '#/components/schemas/de.mittwald.v1.app.SystemSoftwareUpdatePolicy',
                        ],
                    ],
                    'type' => 'object',
                ],
                'type' => 'object',
            ],

Providing keys with the id to systemSoftware will lead to a JSON validation error.

Schema validation fails for AppUpdatePolicy when requesting AppInstallation

In SchemaStorage.php line 145:

File: internal://provided-schema/ is found, but could not resolve fragment: #/components/schemas/de.mittwald.v1.app.AppUpdatePolicy

Code:

        $input = [
            'appVersionId' => $createAppStruct->appVersionIdentifier,
            'description' => $createAppStruct->name,
            'updatePolicy' => AppUpdatePolicy::none->value,
            'userInputs' => [],
        ];
        $requestBody = RequestAppinstallationRequestBody::buildFromInput($input);

Disabling validation and using the body in the request works.