mixu / minilog Goto Github PK

The commit bcf518b changed the blacklist deny test from < to <= which disagrees with the docs http://mixu.net/minilog/filter.html

This configures the default filter to hide logs where the level is < 'warn'. 

I don't understand why this change was made as you can no longer use:

Minilog.suggest.deny(/mymodule\/.*/, 'debug');

to filter out debug items etc.

/minilog/lib/node/console.js:22:82

I tried to update zendesk/radar to use minilog 2 and discovered that backends.console.filterEnv may have some problem here.

Here is the init statements:

var Minilog = require('minilog');
Minilog
  .pipe(Minilog.backends.console.filterEnv((process.env.radar_log ? process.env.radar_log : '*')))
  .pipe(Minilog.backends.console.formatWithStack)
  .pipe(Minilog.backends.console);

And then it goes with the following error:

<...>/node_modules/radar/node_modules/minilog/lib/common/transform.js:28
  dest.emit('pipe', s);
       ^
TypeError: Object function filter(name, level) {
    return whitelist.some(function(expr) {
      return expr.topic && expr.topic.test(name) && levelMap[level] >= expr.level;
    });
  } has no method 'emit'
    at ConsoleBackend.Transform.pipe (<...>/node_modules/radar/node_modules/minilog/lib/common/transform.js:28:8)
    at Object.<anonymous> (<...>/node_modules/radar/server.js:17:4)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:901:3

The offending part would then be filterEnv in lib/node/console.js, and commenting that filter out in Minilog.pipe would render no problems.

Using the Documented example:

var Minilog = require('minilog'),
    consoleBackend = Minilog.backends.nodeConsole;
Minilog.pipe(consoleBackend).format(consoleBackend.formatClean);

I get:
[Error: Warning: .format() is deprecated in Minilog v2! Use .pipe(formatter).pipe(final) instead.]

It isn't clear to me what 'final' should be.

Given a single Minilog instance can I output all log levels to console, but only warnings and errors to Redis. ie. Can I use separate Filters for different Backends with a single Minilog instance or do I need to create separate Minilog instances for each backend.

I have tried to get it to work but with no avail. From looking at the code it seems like it is not supported.

From the website:
"Unsent logs from localStorage are sent the next time the backend is activated (on your domain, localStorage is isolated)."
So it seems like it should be implemented already.
Could you explain how to set that up?

Many Thanks,
Itay.

For the life of me, can't get redis backend to work:
var Minilog=require('minilog'); Minilog.pipe(new Minilog.backends.redis({client:redis,key:key}))
Getting exception:
Unhandled rejection TypeError: dest.emit is not a function at Transform.pipe (C:\...\node_modules\minilog\lib\common\transform.js:28:8) at Function.exports.pipe (C:\...\node_modules\minilog\lib\common\minilog.js:23:14) at Function.module.exports.pipe (C:\...\node_modules\minilog\lib\index.js:21:20)
Am I missing some wrapper? Is there an example of setting up redis backend? Thanks!

I modified the themes example to add some filters to block the debug level messages but I can't seem to make them work. Presumably I'm doing something wrong but it seems pretty straightforward so I'm confused. Here's the code:

var log = require('minilog')('app'),
    ConsoleBackend = require('minilog').backends.console;

function out() {
  log
    .debug('debug message')
    .info('info message')
    .warn('warning')
    .error('this is an error message');
};

var minilog = require('minilog');

console.log('\n== Default style\n');

minilog.enable();
var filter = new minilog.Filter();
filter.defaultResult = true;
filter.deny('app','debug');
minilog.pipe(filter);
out();
minilog.disable();
});

and here's the resulting output:

== Default style

app debug debug message
app info info message
app warn warning
app error this is an error message

I also tried just setting defaultResult to false and using allow rules but without success - all the messages seem to come through no matter what I try.

In your examples, jquery_server.js, is listening to post requests on /log and your jquery_example.html is sending the post request with a parameter.

The switch case is failing because it is listening to /log only and the request it gets is /log?client_id=xxxxxx Took a while to catch it.

Hi there!

I wanted to check and ask what license minilog is released under? I can't find one in the usual places (package.json, README.md, or LICENSE.md).

Thank you!

This is a super handy idea of yours, would be cool if this would work when using browserify to make the final browser bundle.

The readme says "Minilog output is suppressed by default." however in Node this is not the case.

Further if I call enable() then the Formatter I've specified is lost and goes to the default formatter.

The microee dependency is locked to 0.0.2, which doesn't have a specific license attached to it. This is a bit of a problem when wanting to verify all licenses in a project using minilog. Could you consider bumping up the microee dependency to at least 0.0.3 where the license field was added?

This is related to mixu/microee#2 I just opened - if switching to SPDX-compliant license ID there, it would obviously be great to update the dependency here to that one instead of 0.0.3. Not sure if the functional changes in microee versions > 0.0.3 break this lib then, though :/.

To white list, we do:

       Minilog.suggest.defaultResult = false; // Enable Whitelist Mode
        Minilog
            .suggest
            .clear()
            .allow(component,level);
        Minilog.enable();

Would if be possible to target angular2 components to steer the logging on the granular level like with node js modules?

Currently each line is individually a valid JSON string, but the whole body itself is not. Currently it looks like:

["myApp","info",some text"]
["myApp","info","some more text"]
["myApp","info","even more text"]

when really it should look like this:

{"logs: [
  ["myApp","info",some text"]
  ["myApp","info","some more text"]
  ["myApp","info","even more text"]
]}

If we're not prepared to do this, we should absolutely not set the contentType to be 'application/json'. This screws up the node json body-parser, which will try to JSON.parse the whole body if the contentType matches.

As the subject

Upon loading the test/example page jquery_example.html in Chrome (either as a local page or served from a local web server) I see in the console:

Uncaught TypeError: undefined is not a function jquery_example.html:6

When I click the "Add log message", I see in the Chrome console:

Uncaught TypeError: Object #<HTMLInputElement> has no method 'info' jquery_example.html:25

If I comment out the line
var jq = new Minilog.backends.jquery({ url: 'http://localhost:8080/log', interval: 1000, format: 'json' });
and the line

`````` //.pipe(jq)I get a different errorUncaught TypeError: Object # has no method 'emit' minilog.js:15````

Perhaps the instructions are missing steps?

Some browsers don't support colorization and make the logging difficult to read.

Is there a way to turn off colors?

I see how you can send from browser to a log server.

Is there example of sending from one node server to another?
ie, How do I setup a node client to send ?

I want to easily disable/enable console output, without using the localStorage configuration mechanism which requires that you remember a specific string.

I also want to set the logging level (e.g. only warn etc.).

I also want to enable/disable by particular logging scopes.

I also want an alternative to localstorage, such as being able to pass a string via the URL in the browser, for example:

?minilog=true
?minilog=warn
?minilog=chat.warn,radar*.debug

In v1 there was a extras property on a backend that would be posted to the endpoint specified.

How can I do this in v2?

Minilog is a little confused by Electron (https://github.com/atom/electron) since it's a Node + Chrome hybrid.

I've submitted a pull request to detect Electron and use the Chrome formatter instead.

Thank you for the excellent logger.

stacktraces are aweful.

I'm trying to setup Minilog to use in the Browser as follows:

    Minilog
      .pipe(Minilog.suggest)                  // filter
      .pipe(Minilog.backends.browser.color)   // also tried .formatColor
      .pipe(Minilog.backends.browser);        // backend

and get:

Uncaught TypeError: Cannot call method 'emit' of undefined   minilog.js:15

If I leave the above code out I do get basic minilog working ok. I am loading minilog using require.js in case that is relevant.

I love Minilog, And I'd like to use it for an open-source project I'm working on, but I would like to make it optional. The default implementation uses the browser's console, and Node's stdio's console objects for logging.

Problem: both these objects provide a log() that Minilog doesn't provide:

Node     Browser  Minilog
log()    log()    N/A
N/A      N/A      debug()
info()   info()   info()
warn()   warn()   warn()
error()  error()  error()

I know that log.log() isn't pretty, but I think Minilog should offer this method in order to be a drop-in replacement of the console implementations. log() could simply proxy to debug().

If that makes sense to you, I can work on a patch.

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/minilog/lib/node/formatters/npm.js b/node_modules/minilog/lib/node/formatters/npm.js
index c0b7a23..2de3061 100644
--- a/node_modules/minilog/lib/node/formatters/npm.js
+++ b/node_modules/minilog/lib/node/formatters/npm.js
@@ -6,12 +6,12 @@ Transform.mixin(FormatNpm);
 
 FormatNpm.prototype.write = function(name, level, args) {
   var out = {
-        debug: '\033[34;40m' + 'debug' + '\033[39m ',
-        info: '\033[32m' + 'info'  + '\033[39m  ',
-        warn: '\033[30;41m' + 'WARN' + '\033[0m  ',
-        error: '\033[31;40m' + 'ERR!' + '\033[0m  '
+        debug: '\x1b[34;40m' + 'debug' + '\x1b[39m ',
+        info: '\x1b[32m' + 'info'  + '\x1b[39m  ',
+        warn: '\x1b[30;41m' + 'WARN' + '\x1b[0m  ',
+        error: '\x1b[31;40m' + 'ERR!' + '\x1b[0m  '
       };
-  this.emit('item', (name ? '\033[37;40m'+ name +'\033[0m ' : '')
+  this.emit('item', (name ? '\x1b[37;40m'+ name +'\x1b[0m ' : '')
           + (level && out[level]? out[level] : '')
           + args.join(' '));
 };
diff --git a/node_modules/minilog/lib/node/formatters/util.js b/node_modules/minilog/lib/node/formatters/util.js
index 4288e6c..ad1e90b 100644
--- a/node_modules/minilog/lib/node/formatters/util.js
+++ b/node_modules/minilog/lib/node/formatters/util.js
@@ -1,20 +1,20 @@
 var styles = {
     //styles
-    'bold'      : ['\033[1m',  '\033[22m'],
-    'italic'    : ['\033[3m',  '\033[23m'],
-    'underline' : ['\033[4m',  '\033[24m'],
-    'inverse'   : ['\033[7m',  '\033[27m'],
+    'bold'      : ['\x1b[1m',  '\x1b[22m'],
+    'italic'    : ['\x1b[3m',  '\x1b[23m'],
+    'underline' : ['\x1b[4m',  '\x1b[24m'],
+    'inverse'   : ['\x1b[7m',  '\x1b[27m'],
     //grayscale
-    'white'     : ['\033[37m', '\033[39m'],
-    'grey'      : ['\033[90m', '\033[39m'],
-    'black'     : ['\033[30m', '\033[39m'],
+    'white'     : ['\x1b[37m', '\x1b[39m'],
+    'grey'      : ['\x1b[90m', '\x1b[39m'],
+    'black'     : ['\x1b[30m', '\x1b[39m'],
     //colors
-    'blue'      : ['\033[34m', '\033[39m'],
-    'cyan'      : ['\033[36m', '\033[39m'],
-    'green'     : ['\033[32m', '\033[39m'],
-    'magenta'   : ['\033[35m', '\033[39m'],
-    'red'       : ['\033[31m', '\033[39m'],
-    'yellow'    : ['\033[33m', '\033[39m']
+    'blue'      : ['\x1b[34m', '\x1b[39m'],
+    'cyan'      : ['\x1b[36m', '\x1b[39m'],
+    'green'     : ['\x1b[32m', '\x1b[39m'],
+    'magenta'   : ['\x1b[35m', '\x1b[39m'],
+    'red'       : ['\x1b[31m', '\x1b[39m'],
+    'yellow'    : ['\x1b[33m', '\x1b[39m']
   };
 
 exports.levelMap = { debug: 1, info: 2, warn: 3, error: 4 };

This issue body was partially generated by patch-package.