mmoomocow / digital-commendations Goto Github PK

Based on feedback from Mr Milne

When there is the "You have been awarded 5 commendations since you last logged in" message there is no way to quickly identify the new commendations. Highlighting them would make it quick and easy to see

Describe the bug

The formatting action with github actions is creating random branches when trying to commit changes.

To Reproduce

Steps to reproduce the behavior:

1. Open pull request
2. formatting action will be run
3. new branch may be created

Expected behavior

No new branches. If applicable changes should be committed to the PR branch or not pushes at all

##Screenshots

Additional context
Add any other context about the problem here.

Describe the bug

Debug print statement remains in
https://github.com/mmoomocow/digital-commendations/blob/37dae56f9ee4259693699771b9e65230242f3300/home/views_errors.py#LL19C9-L19C14

Short description of the feature

Add SMS notifications when students receive commendations

Describe the solution you would like

Using modica

import requests
uri = 'https://api.modicagroup.com/rest/gateway/messages'
json_payload ='{"content": "Hello world!", "destination": "+64123456789"}'
response = requests.post(uri, auth=('username', 'password'), data=json_payload)

print 'HTTP %s' % response.status_code
print response.text

Why should this be implemented

Informs students when the receive commendations

Short description of the feature

Separate production requirements from developer requirements

Describe the solution you would like

Split requirements into requirements.txt and requirements_dev.txt

Why should this be implemented

Smoother developer experience, reduces number of packages in production environments reducing bug risk and install time

Short description of the feature

Login with Microsoft authentication.

Describe the solution you would like

Option to use microsoft Oauth to login to site

Why should this be implemented

Could entirely remove need for student and teacher password management, as all students and teachers have a school linked microsoft account

Describe the bug

When generating fake users to populate the database, passwords are stored in plain text and not hashed

Expected behavior

Passwords should be hashed and set using user.set_password()

##Screenshots

Short description of the feature

Add custom error pages to display for common error codes

Describe the solution you would like

Why should this be implemented

Short description of the feature

Add media queries to CSS to create a responsive design

Describe the solution you would like

Media queries modifying the layout

Why should this be implemented

Better experience on devices with smaller screens

ToDo

• #141
• #142

Describe the bug

See GHSA-r3xc-prgr-mg9p.

Based on feedback from Mr Beagley, some examples of what could be included are:

• Commendations awarded per teacher
• Commendation types awarded
• Commendations received by student

Describe the bug

Database models allow Null in the database, can cause issues when checking data as you need to check for a None before performing string operations on it.

Expected behaviour

Replace null=True with default='' for applicable fields to default to using a blank string instead of a none type

Screenshots

https://app.deepsource.com/gh/mmoomocow/digital-commendations/issue/PTC-W0901/occurrences?listindex=0

Cool way to do it

Short description of the feature

Could adding pre-made selectable reasons for awarding commendations be good?
e.g. "Scoring highly on test", "Being respectful" etc

Describe the solution you would like

Selectable reasons, probably radio buttons or a dropdown

Why should this be implemented

Saves time for teachers, lots will need to award the same thing multiple times

Describe the bug

If there is no trailing slash then you are shown the 404 page. Many links do not have a trailing slash

To Reproduce

Steps to reproduce the behavior:

1. From any page click on the contact link in the navbar
2. You will be taken to /contact
3. 404

Expected behavior

No 404 and contact page displayed correctly

##Screenshots

• Save commendation certificates as an image?
• Display certificates on the list page?
• Display a bayfield logo on page?

Describe the bug

Real check requests to the API endpoint using basicauth fail

To Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior

A clear and concise description of what you expected to happen.

##Screenshots
If applicable, add screenshots to help explain your problem.

##Device and enviroment

• Device: [e.g. i-phone, desktop computer]
• OS: [e.g. iOS/windows]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

When students log in, display a message saying they have earned x commendations since they last logged in

Short description of the feature

Headings need to restyled to make more sense

Describe the solution you would like

Changes to H* tags with better font sizes etc

Why should this be implemented

Based on feedback from Mr Milne!

Having 'locations' for example in the classroom, extra-curricular etc would allow parents and caregivers to see where the student is doing well. For example is the student getting a good balance between classroom and extracurricular commendations?

Could also be communicated with a progress bar, that splits as a percentage of in class & out of class

Describe the bug

After login there is no link to navigate back to the portal

To Reproduce

Steps to reproduce the behavior:

1. login, you will be redirected to the respective portal (student, teacher etc)
2. Then navigate to another page
3. Then try to go to the portal without going back (You can't)

Expected behavior

A clear way to access the portal with navigation

##Screenshots

Describe the bug

When viewing the login page on a mobile device (Or any device with a small screen) the 2 column layout breaks

When viewing an individual commendation on a device with a small screen it also looks strange and unusable