Does not compile under GCC 4.7 CentOS 6.6 about pbrt-v3

[mmp]

I believe that #2 has been fixed and I think #1 may have been fixed, but am less confident about that one. If you have a chance to try again with top of tree and report how it goes, I'd appreciate it!

[Delwin9999]

pbrt-v3/src/integrators/bdpt.h:149:29: error: member ‘EndpointInteraction Vertex::::ei’ with constructor not allowed in anonymous aggregate

pbrt-v3/src/integrators/bdpt.h:150:27: error: member ‘MediumInteraction Vertex::::mi’ with constructor not allowed in anonymous aggregate

pbrt-v3/src/integrators/bdpt.h:151:28: error: member ‘SurfaceInteraction Vertex::::isect’ with constructor not allowed in anonymous aggregate

pbrt-v3/src/core/mipmap.h:135:9: error: call of overloaded ‘ParallelFor(MIPMap::MIPMap(const Point2i&, const T*, bool, Float, ImageWrap) [with T = RGBSpectrum; Point2i = Point2; Float = float]::<lambda(int)>, int&, int)’ is ambiguous
pbrt-v3/src/core/mipmap.h:135:9: note: candidates are:
In file included from pbrt-v3/src/core/api.cpp:37:0:
pbrt-v3/src/core/parallel.h:49:6: note: void ParallelFor(const std::function<void(int)>&, int, int)
pbrt-v3/src/core/parallel.h:53:6: note: void ParallelFor(const std::function<void(int, int)>&, int, int)

Also a warning right at the end
pbrt-v3/src/tests/bitops.cpp:23:7: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null]

It looks like neither are fixed. This is after a clean -xdf, pull against master and re-running cmake and make.

Is ac19125 the proper commit for the head of master? I'm wondering if maybe I didn't get the right code.

[Delwin9999]

Gah, not kidding about every button being dangerous.

[Delwin9999]

OK, updated to 1eaa295 and the union issues are gone. Only thing preventing compiling now is the ambiguous overload between

pbrt-v3/src/core/parallel.h:49:6: note: void ParallelFor(const std::function<void(int)>&, int, int)

and

pbrt-v3/src/core/parallel.h:53:6: note: void ParallelFor(const std::function<void(int, int)>&, int, int)

[Delwin9999]

I found a stackoverflow that mentions why overloading on std::function is delicate.

http://stackoverflow.com/questions/22542780/c11-auto-stdfunction-and-ambiguous-call-to-overloaded-function

[mwkm]

For the ParallelFor(), it iooks like the same for Windows side on VS2015 RC, I applied casts and they are gone.

[mmp]

Both the anonymous union and the ParallelFor issue should be fixed in top of tree now, so I'm optimistically closing this. Please reopen this if you're still seeing issues (and sorry for the delay!)