Comments (7)
I believe that #2 has been fixed and I think #1 may have been fixed, but am less confident about that one. If you have a chance to try again with top of tree and report how it goes, I'd appreciate it!
from pbrt-v3.
pbrt-v3/src/integrators/bdpt.h:149:29: error: member ‘EndpointInteraction Vertex::::ei’ with constructor not allowed in anonymous aggregate
pbrt-v3/src/integrators/bdpt.h:150:27: error: member ‘MediumInteraction Vertex::::mi’ with constructor not allowed in anonymous aggregate
pbrt-v3/src/integrators/bdpt.h:151:28: error: member ‘SurfaceInteraction Vertex::::isect’ with constructor not allowed in anonymous aggregate
pbrt-v3/src/core/mipmap.h:135:9: error: call of overloaded ‘ParallelFor(MIPMap::MIPMap(const Point2i&, const T*, bool, Float, ImageWrap) [with T = RGBSpectrum; Point2i = Point2; Float = float]::<lambda(int)>, int&, int)’ is ambiguous
pbrt-v3/src/core/mipmap.h:135:9: note: candidates are:
In file included from pbrt-v3/src/core/api.cpp:37:0:
pbrt-v3/src/core/parallel.h:49:6: note: void ParallelFor(const std::function<void(int)>&, int, int)
pbrt-v3/src/core/parallel.h:53:6: note: void ParallelFor(const std::function<void(int, int)>&, int, int)
Also a warning right at the end
pbrt-v3/src/tests/bitops.cpp:23:7: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null]
It looks like neither are fixed. This is after a clean -xdf, pull against master and re-running cmake and make.
Is ac19125 the proper commit for the head of master? I'm wondering if maybe I didn't get the right code.
from pbrt-v3.
Gah, not kidding about every button being dangerous.
from pbrt-v3.
OK, updated to 1eaa295 and the union issues are gone. Only thing preventing compiling now is the ambiguous overload between
pbrt-v3/src/core/parallel.h:49:6: note: void ParallelFor(const std::function<void(int)>&, int, int)
and
pbrt-v3/src/core/parallel.h:53:6: note: void ParallelFor(const std::function<void(int, int)>&, int, int)
from pbrt-v3.
I found a stackoverflow that mentions why overloading on std::function is delicate.
from pbrt-v3.
For the ParallelFor(), it iooks like the same for Windows side on VS2015 RC, I applied casts and they are gone.
from pbrt-v3.
Both the anonymous union and the ParallelFor issue should be fixed in top of tree now, so I'm optimistically closing this. Please reopen this if you're still seeing issues (and sorry for the delay!)
from pbrt-v3.
Related Issues (20)
- Radiometry Pack For Beginner like me
- A bug in OrthographicCamera::GenerateRay of pbrt-v3
- Git repository and CDN does not work HOT 2
- Two questions about spectral rendering and output HOT 6
- Sphere::Pdf does not return zero when wi points away from the sphere.
- Black marks on bump mapped area.
- What happens in `BVHAccel::Intersect` when the ray has one component == 0.0 ? HOT 1
- How to run rendering on GPU instead of CPU (pbrt v3) HOT 1
- build error on windows using mingw HOT 1
- pbrt-v3 failed to build due to error MSB8066 using MSVC for ARM64EC target on Windows HOT 1
- PBRT wouldn't finish building on FreeBSD
- Samples "leak out" from the medium due to imperfect ray-intersection logic
- No PDF cutoff for light samples with a zero BxDF probability HOT 2
- win10/Visual studio 2019 install HOT 4
- nan values during rendering (HairBxDF?)
- Is refraction implemented correctly in v3 BDPT? HOT 1
- MSVC 14.37 has compilation issue when building `lmfAttribute.cpp`
- Mathematical confusion of Global sampler array samples
- compilation error HOT 3
- about the formular 16.1 in pbrt-v3-book
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pbrt-v3.