GithubHelp home page GithubHelp logo

mmtk / openjdk Goto Github PK

View Code? Open in Web Editor NEW
4.0 4.0 12.0 381.8 MB

License: GNU General Public License v2.0

Makefile 0.01% Shell 0.22% JavaScript 1.06% M4 0.11% sed 0.01% Roff 0.17% HTML 0.35% CSS 0.01% Python 0.07% Java 78.00% C++ 14.01% XSLT 0.22% Perl 0.01% Batchfile 0.01% C 5.35% Assembly 0.03% DTrace 0.01% GDB 0.01% Objective-C 0.38% Red 0.01%

openjdk's People

Stargazers

avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar

Forkers

rouanebannister yiluowei paigereeves dbggg wks xiaowang7777 tianleq angussidney chflood caizixian balajicv

openjdk's Issues

The INCLUDE_ZGC macro should be used as a value

In src/hotspot/share/opto/matcher.cpp, there is a line #if defined(INCLUDE_ZGC) && !defined(INCLUDE_THIRD_PARTY_HEAP). Supposedly the code following that should only be enabled when ZGC is enabled.

However, the INCLUDE_ZGC macro should not be used by testing if it is defined. It is always defined (as 0 or 1) and should be used as a boolean value. Therefore defined(INCLUDE_ZGC) is always true.

This is causing compilation error when compiling OpenJDK where neither ZGC nor third-party heap is enabled. Because OpenJDK 11 only supports ZGC on Linux/x64, attempting to compile this openjdk repo on MacOS or AArch64 without third-party heap will result in compilation error because the code enclosed by this macro is erroneously enabled. This problem can also be reproduced on Linux/x64 by disabling ZGC manually.

How to reproduce:

On Linux/x86, follow README.md in `mmtk-openjdk, but

  • add --enable-jvm-features=-zgc to sh configure
  • remove THIRD_PARTY_HEAP=$PWD/../../openjdk from make

Then compilation will fail.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.