GithubHelp home page GithubHelp logo

irony's People

Contributors

datokrat avatar mnemonic101 avatar

Stargazers

 avatar

Watchers

 avatar

Forkers

datokrat

irony's Issues

BodyParam() knows no "name" variable but is using one

I just tried to start the disco-node server after upgrading to the last commit of irony, encountering the following error:

[...]/irony/build/lib/system/router/decorators/decorators.js:102
        processDecoratedParameter(target, propertyKey, parameterIndex, enums_1.ParamType.body, name);
                                                                                               ^

ReferenceError: name is not defined
    at [...]/irony/build/lib/system/router/decorators/decorators.js:102:96

This seems logical to me, reviewing this snippet from the decorators.ts:

export function BodyParam() {
  return function (target: Object, propertyKey: string, parameterIndex: number) {
    processDecoratedParameter(target, propertyKey, parameterIndex, ParamType.body, name);
  };
}

In contrast to the other *Param decorators, BodyParam does not expect the "name" parameter but is passing one to processDecoratedParameter. TypeScript does not fail because the name property was defined in some DOM specific typing file...

Should we simply add a name parameter?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.